FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: prevent extraneous HOSTNAME substitution in test-runner-output by Renegade334 · Pull Request #58076 · nodejs/node · GitHub

/ node Public

test: prevent extraneous HOSTNAME substitution in test-runner-output - #58076

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Renegade334:test-runner-output-hostname
May 1, 2025
ConversationCommits (1)ChecksFiles changed
Merged

test: prevent extraneous HOSTNAME substitution in test-runner-output#58076
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Renegade334:test-runner-output-hostname

Conversation

Renegade334 commented Apr 29, 2025

Copy link
Copy Markdown
Member

I have a box named "io". This got a good chuckle out of me.

=== release test-runner-output ===                                            
Path: parallel/test-runner-output
Test failure: 'test-runner/output/junit_reporter.js'
Location: test/parallel/test-runner-output.mjs:330:5
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected
... Skipped lines

+ '<?xml versHOSTNAMEn="1.0" encoding="utf-8"?>\n' +
- '<?xml version="1.0" encoding="utf-8"?>\n' +
    '<testsuites>\n' +
    '\t<testcase name="sync pass todo" time="*" classname="test">\n' +
    '\t\t<skipped type="todo" message="true"/>\n' +
    '\t</testcase>\n' +
    '\t<testcase name="sync pass todo with message" time="*" classname="test">\n' +
...
    '\t</testcase>\n' +
+   '\t<testcase name="async assertHOSTNAMEn fail" time="*" classname="test" failure="Expected values to be strictly equal:true !== false">\n' +
-   '\t<testcase name="async assertion fail" time="*" classname="test" failure="Expected values to be strictly equal:true !== false">\n' +
    '\t\t<failure type="testCodeFailure" message="Expected values to be strictly equal:true !== false">\n' +
    '[Error [ERR_TEST_FAILURE]: Expected values to be strictly equal:\n' +
    '\n' +
    'true !== false\n' +
    '] {\n' +
    "  code: 'ERR_TEST_FAILURE',\n" +
    "  failureType: 'testCodeFailure',\n" +
+   '  cause: AssertHOSTNAMEnError [ERR_ASSERTION]: Expected values to be strictly equal:\n' +
-   '  cause: AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:\n' +
    '  \n' +
    '  true !== false\n' +
    '  \n' +
    '      *\n' +
    '      *\n' +
...
    '\t</testcase>\n' +
+   '\t<testcase name="unhandled rejectHOSTNAMEn - passes but warns" time="*" classname="test"/>\n' +
+   '\t<testcase name="async unhandled rejectHOSTNAMEn - passes but warns" time="*" classname="test"/>\n' +
-   '\t<testcase name="unhandled rejection - passes but warns" time="*" classname="test"/>\n' +
-   '\t<testcase name="async unhandled rejection - passes but warns" time="*" classname="test"/>\n' +
    ...,
  operator: 'strictEqual'
}

nodejs-github-bot commented Apr 29, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 29, 2025
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 29, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2025

nodejs-github-bot commented Apr 29, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66505/

codecov Bot commented Apr 29, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (53abd1a) to head (ca3e005).
Report is 18 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58076      +/-   ##
==========================================
- Coverage   90.20%   90.20%   -0.01%     
==========================================
  Files         630      630              
  Lines      186391   186391              
  Branches    36612    36611       -1     
==========================================
- Hits       168134   168127       -7     
+ Misses      11068    11062       -6     
- Partials     7189     7202      +13

see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot commented Apr 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66513/

nodejs-github-bot commented May 1, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66527/

pmarchini added the commit-queue Add this label to land a pull request using GitHub Actions. label May 1, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 1, 2025
nodejs-github-bot merged commit 2b4f554 into nodejs:main May 1, 2025

nodejs-github-bot commented May 1, 2025

Copy link
Copy Markdown
Collaborator

Landed in 2b4f554

RafaelGSS pushed a commit that referenced this pull request May 2, 2025
test: prevent extraneous HOSTNAME substitution in test-runner-output
1f2b261 
PR-URL: #58076
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
RafaelGSS mentioned this pull request May 2, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 6, 2025
test: prevent extraneous HOSTNAME substitution in test-runner-output
4002ec7 
PR-URL: #58076
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request May 6, 2025
test: prevent extraneous HOSTNAME substitution in test-runner-output
3cc58bb 
PR-URL: #58076
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
test: prevent extraneous HOSTNAME substitution in test-runner-output
56dc4c8 
PR-URL: #58076
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request May 16, 2025
test: prevent extraneous HOSTNAME substitution in test-runner-output
dd474bb 
PR-URL: #58076
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request May 17, 2025
test: prevent extraneous HOSTNAME substitution in test-runner-output
0d1121c 
PR-URL: #58076
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request May 18, 2025
test: prevent extraneous HOSTNAME substitution in test-runner-output
2eb5347 
PR-URL: #58076
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
github-actions Bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
test: prevent extraneous HOSTNAME substitution in test-runner-output
103034b 
PR-URL: #58076
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Renegade334 deleted the test-runner-output-hostname branch May 31, 2025 19:01
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
test: prevent extraneous HOSTNAME substitution in test-runner-output
abb706c 
PR-URL: #58076
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
test: prevent extraneous HOSTNAME substitution in test-runner-output
86229cb 
PR-URL: #58076
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
marco-ippolito mentioned this pull request Jun 5, 2025
Merged
ghost mentioned this pull request Jun 8, 2025
Closed
marco-ippolito pushed a commit that referenced this pull request Jun 10, 2025
test: prevent extraneous HOSTNAME substitution in test-runner-output
56fce66 
PR-URL: #58076
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
aduh95 aduh95 approved these changes
marco-ippolito marco-ippolito approved these changes
pmarchini pmarchini approved these changes
atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL