doc: correct deprecation type of assert.CallTracker - #57997
Merged
nodejs-github-bot merged 1 commit intoApr 24, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
marco-ippolito
approved these changes
Apr 24, 2025
jasnell
approved these changes
Apr 24, 2025
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Really no reason for this one to wait the 48 hours. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/57997 ✔ Done loading data for nodejs/node/pull/57997 ----------------------------------- PR info ------------------------------------ Title doc: correct deprecation type of `assert.CallTracker` (#57997) Author René <contact.9a5d6388@renegade334.me.uk> (@Renegade334) Branch Renegade334:doc-calltracker-deprecation -> nodejs:main Labels doc, fast-track, author ready, deprecations, dont-land-on-v18.x Commits 1 - doc: correct deprecation type of `assert.CallTracker` Committers 1 - Renegade334 <contact.9a5d6388@renegade334.me.uk> PR-URL: https://github.com/nodejs/node/pull/57997 Refs: https://github.com/nodejs/node/pull/47740 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57997 Refs: https://github.com/nodejs/node/pull/47740 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 24 Apr 2025 07:01:00 GMT ✔ Approvals: 2 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/57997#pullrequestreview-2791347686 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57997#pullrequestreview-2791348226 ℹ This PR is being fast-tracked ✘ This PR needs to wait 38 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/14647104058 |
Sorry, something went wrong.
lpinca
approved these changes
Apr 24, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assert.CallTracker was runtime-deprecated at the outset.
ref: #47740