FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v20.x] tools: update sccache version to v0.10.0 by marco-ippolito · Pull Request #57994 · nodejs/node · GitHub

/ node Public

[v20.x] tools: update sccache version to v0.10.0 - #57994

Closed
marco-ippolito wants to merge 2 commits into
nodejs:v20.x-stagingfrom
marco-ippolito:fix-conflicts
ConversationCommits (2)ChecksFiles changed
Closed

[v20.x] tools: update sccache version to v0.10.0#57994
marco-ippolito wants to merge 2 commits into
nodejs:v20.x-stagingfrom
marco-ippolito:fix-conflicts

Conversation

marco-ippolito commented Apr 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

The update in 29c0324 was overwritten by d45517c.

Also this line breaks the test 29c0324#diff-9e078b64804cbda5c87567835a5da2f1314788813ec5c5e9809a2f96519b9b01R99
not sure why it worked during the release 🤔

@nodejs/releasers

nodejs-github-bot commented Apr 23, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

nodejs-github-bot added meta Issues and PRs related to the general management of the project. v20.x labels Apr 23, 2025

aduh95 commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

not sure why it worked during the release 🤔

No GHA tests were run on the release commit, only Jenkins. The failure on the previous commit were ignored I guess

marco-ippolito commented Apr 24, 2025

Copy link
Copy Markdown
Member Author

I dont see test-linux being run but I think its important to run it 🤔

richardlau commented Apr 24, 2025

Copy link
Copy Markdown
Member

I dont see test-linux being run but I think its important to run it 🤔

It's not run because this PR hasn't changed any paths not ignored by:

node/.github/workflows/test-linux.yml

Lines 4 to 19 in 5357d0b

pull_request:
paths-ignore:
- README.md
- .github/**
- '!.github/workflows/test-linux.yml'
types: [opened, synchronize, reopened, ready_for_review]
push:
branches:
- main
- canary
- v[0-9]+.x-staging
- v[0-9]+.x
paths-ignore:
- README.md
- .github/**
- '!.github/workflows/test-linux.yml'

aduh95 commented Apr 24, 2025

Copy link
Copy Markdown
Contributor

I dont see test-linux being run but I think its important to run it 🤔

Both commits are unrelated to test-linux though, why would you expect it to have any impact on it?

marco-ippolito commented Apr 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

I have the feeling the test is broken too due to the folder with weird chars tests being added, maybe I can run it manually ?

marco-ippolito commented Apr 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Yeah test-linux is broken too, Ill fix the change that broke it

marco-ippolito force-pushed the fix-conflicts branch 2 times, most recently from 2a711ce to 766d237 Compare April 29, 2025 13:23
richardlau mentioned this pull request May 1, 2025
Closed

marco-ippolito commented May 16, 2025

Copy link
Copy Markdown
Member Author

I'm not sure why the test is broken on linux arm64, but its unrelated, can we backport this PR? At least it will allow other backports to run the tests

aduh95 commented May 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@marco-ippolito if you remove 766d237 from this PR, you'll have a green CI and it can land immediately, I suggest you do that and take 766d237 to a separate PR

aduh95 commented May 16, 2025

Copy link
Copy Markdown
Contributor

I opened #58351 to address the linux failure

marco-ippolito added a commit that referenced this pull request Jun 3, 2025
tools: update sccache version to v0.10.0
d164dc2 
PR-URL: #57994
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
marco-ippolito added a commit that referenced this pull request Jun 3, 2025
tools: fix tarball testing directory
7c449ed 
PR-URL: #57994
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

marco-ippolito commented Jun 3, 2025

Copy link
Copy Markdown
Member Author

Landed in debd3c2...7c449ed

marco-ippolito mentioned this pull request Jun 5, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

richardlau richardlau approved these changes
aduh95 aduh95 approved these changes
geeksilva97 geeksilva97 approved these changes

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL