FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: remove unused variable in crypto_x509.cc by targos · Pull Request #57754 · nodejs/node · GitHub

/ node Public

src: remove unused variable in crypto_x509.cc - #57754

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:rm-unused-x509
Apr 5, 2025
ConversationCommits (1)ChecksFiles changed
Merged

src: remove unused variable in crypto_x509.cc#57754
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:rm-unused-x509

Conversation

targos commented Apr 5, 2025

Copy link
Copy Markdown
Member

No description provided.

nodejs-github-bot commented Apr 5, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Apr 5, 2025

targos commented Apr 5, 2025

Copy link
Copy Markdown
Member Author

Not sure how it wasn't caught, but here is the error I get in an unrelated PR: https://github.com/nodejs/node/actions/runs/14280449557/job/40029374410

targos added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 5, 2025

github-actions Bot commented Apr 5, 2025

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

panva added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 5, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 5, 2025

nodejs-github-bot commented Apr 5, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66041/

codecov Bot commented Apr 5, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (e739559) to head (a7f1c42).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57754      +/-   ##
==========================================
- Coverage   90.26%   90.25%   -0.01%     
==========================================
  Files         630      630              
  Lines      185181   185180       -1     
  Branches    36281    36279       -2     
==========================================
- Hits       167147   167142       -5     
- Misses      10995    10996       +1     
- Partials     7039     7042       +3
Files with missing lines Coverage Δ
src/crypto/crypto_x509.cc 70.44% <ø> (-0.05%) ⬇️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot commented Apr 5, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66044/

panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 5, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 5, 2025
nodejs-github-bot merged commit fb26fa1 into nodejs:main Apr 5, 2025

nodejs-github-bot commented Apr 5, 2025

Copy link
Copy Markdown
Collaborator

Landed in fb26fa1

targos deleted the rm-unused-x509 branch April 5, 2025 15:32
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
src: remove unused variable in crypto_x509.cc
23cc162 
PR-URL: #57754
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
src: remove unused variable in crypto_x509.cc
db8b29d 
PR-URL: #57754
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
src: remove unused variable in crypto_x509.cc
216c268 
PR-URL: #57754
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
src: remove unused variable in crypto_x509.cc
25da922 
PR-URL: #57754
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
src: remove unused variable in crypto_x509.cc
86a4d80 
PR-URL: #57754
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
src: remove unused variable in crypto_x509.cc
8ac9345 
PR-URL: #57754
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
github-actions Bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
src: remove unused variable in crypto_x509.cc
bec053a 
PR-URL: #57754
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
src: remove unused variable in crypto_x509.cc
9bd583a 
PR-URL: #57754
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
src: remove unused variable in crypto_x509.cc
5480c73 
PR-URL: #57754
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito mentioned this pull request Jun 5, 2025
Merged
ghost mentioned this pull request Jun 8, 2025
Closed
marco-ippolito pushed a commit that referenced this pull request Jun 10, 2025
src: remove unused variable in crypto_x509.cc
f004ccc 
PR-URL: #57754
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit that referenced this pull request Jun 11, 2025
src: remove unused variable in crypto_x509.cc
d582954 
PR-URL: #57754
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

panva panva approved these changes
lpinca lpinca approved these changes
pimterry pimterry approved these changes
anonrig anonrig approved these changes
richardlau richardlau approved these changes
+1 more reviewer
mertcanaltin mertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL