FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: implement interface converter and use it for AbortSignal validation by jazelly · Pull Request #54965 · nodejs/node · GitHub

/ node Public

lib: implement interface converter and use it for AbortSignal validation - #54965

Closed
jazelly wants to merge 2 commits into
nodejs:mainfrom
jazelly:validate-abort-signal
ConversationCommits (2)ChecksFiles changed
Closed

lib: implement interface converter and use it for AbortSignal validation#54965
jazelly wants to merge 2 commits into
nodejs:mainfrom
jazelly:validate-abort-signal

Conversation

jazelly commented Sep 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This PR contains 2 commits.

The first one implements interface converter as per the spec.
The one after uses the implemented interface converter to properly validate AbortSiganls in AbortSignal.any

Fixes: #54962

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 16, 2024
jazelly force-pushed the validate-abort-signal branch from dd6e62f to 8f1cafc Compare September 16, 2024 11:30
jazelly marked this pull request as ready for review September 16, 2024 11:56
aduh95 reviewed Sep 16, 2024
View reviewed changes
Comment thread lib/internal/abort_controller.js Outdated

codecov Bot commented Sep 16, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.03%. Comparing base (53ede87) to head (82da5e9).
Report is 185 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/webidl.js 94.11% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54965      +/-   ##
==========================================
- Coverage   88.07%   88.03%   -0.05%     
==========================================
  Files         652      652              
  Lines      183542   183778     +236     
  Branches    35862    35855       -7     
==========================================
+ Hits       161653   161783     +130     
- Misses      15144    15249     +105     
- Partials     6745     6746       +1
Files with missing lines Coverage Δ
lib/internal/abort_controller.js 97.90% <100.00%> (-0.01%) ⬇️
lib/internal/webidl.js 93.89% <94.11%> (-0.69%) ⬇️

... and 46 files with indirect coverage changes

avivkeller added abortcontroller Issues and PRs related to the AbortController API web-standards Issues and PRs related to Web APIs labels Sep 16, 2024
jazelly commented Sep 16, 2024
View reviewed changes
Comment thread lib/internal/webidl.js Outdated
atlowChemi reviewed Sep 16, 2024
View reviewed changes
Comment thread lib/internal/webidl.js Outdated
KhafraDev reviewed Sep 16, 2024
View reviewed changes
Comment thread lib/internal/webidl.js Outdated
jazelly force-pushed the validate-abort-signal branch from 8f1cafc to ad5664f Compare September 17, 2024 11:49
atlowChemi added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 18, 2024

atlowChemi commented Sep 18, 2024

Copy link
Copy Markdown
Member

I am marking this as semver-major PRs that contain breaking changes and should be released in the next major version. since as far as I understand, this would break for any user-land implementation of AbortSignal (https://www.npmjs.com/package/abort-controller etc)

jazelly commented Sep 18, 2024

Copy link
Copy Markdown
Member Author

I am marking this as semver-major

I agree this would be a semver-major. Does it mean a CITGM is required?

this would break for any user-land implementation of AbortSignal

Would it be better to remove this change? This is unrelated to the issue that the PR is fixing and it can be avoided.

KhafraDev commented Sep 18, 2024

Copy link
Copy Markdown
Member

Is there any documentation for supporting third party abortcontrollers? If not I could see this landing as a bug fix.

anonrig added the needs-benchmark-ci PR that need a benchmark CI run. label Sep 18, 2024

jazelly commented Sep 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

There is only one benchmark test coverring abort_controller and it's only covering the AbortController.abort, which is, IMO, not affected by this PR.

@anonrig In that case, would it be better if I raise another PR to add benchmark tests to cover AbortSignal.any and aborted, which are the ones affected by this PR, before proceeding this?

KhafraDev reviewed Sep 19, 2024
View reviewed changes
Comment thread test/parallel/test-internal-webidl.js Outdated
jazelly force-pushed the validate-abort-signal branch from ad5664f to 82da5e9 Compare September 19, 2024 02:37
jakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2024

nodejs-github-bot commented Sep 19, 2024 •
edited by jakecastelli
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62549/ 💛

jakecastelli added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 19, 2024

avivkeller commented Sep 19, 2024

Copy link
Copy Markdown
Member

@nodejs/tsc per nodejs/Release#1034

benjamingr requested changes Sep 19, 2024
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Not brand checking AbortSignal was an intentional design choice in order to enable userland to migrate to using Node's AbortSignal.

We can choose to break that compatibility but it would have to be semver-major and require @nodejs/tsc's opinion since it's an ecosystem concern (this is likely to break userland code)

benjamingr commented Sep 19, 2024

Copy link
Copy Markdown
Member

To be clear - since this breaks userland I want to see how the TSC and namely people who were involved in the original discussion ( @jasnell @mcollina @ronag ) feel about this change.

I'm personally +0 (I'd like it but not at the cost of extensive breakage)

KhafraDev commented Sep 19, 2024

Copy link
Copy Markdown
Member

We made the same decision in undici to drop third party AbortController/AbortSignal support.

mcollina commented Sep 20, 2024

Copy link
Copy Markdown
Member

I'd like it but not at the cost of extensive breakage

The cost of keeping support for 3rd party implementation is maintainers' headaches. Long-term is an untenable proposition.

benjamingr commented Sep 21, 2024

Copy link
Copy Markdown
Member

v7, which is releasing soon-ish. Breakage is unimportant here - it was undocumented behavior that broke compatibility with other implementations and the spec. If we implement a spec, we need to accept its burden too.

This is true for AbortSignal.any and fetch but none of the other many Node.js APIs that currently take AbortSignals. The breakage can be nontrivial and at the very least this would need a CITGM run given userland implementations of AbortSignal have tens of millions of weekly downloads.

If we remove a feature, we need to assess breakage and minimize it.

jakecastelli added the needs-citgm PRs that need a CITGM CI run. label Sep 22, 2024

jazelly commented Sep 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

If we remove a feature, we need to assess breakage and minimize it.

In addition to CITGM, is there anything else I can do to help assess the breakage? IIUC, the users we concern here are mostly the users using 3rd party AbortSignal library with the code running on Node.

To minimize the influence, would it be helpful if this goes into deprecation cycle, considering this was a feature. (not a suggestion but just having this question : ))

jakecastelli commented Sep 26, 2024

Copy link
Copy Markdown
Member

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3477/

benjamingr approved these changes Sep 29, 2024
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

CITGM looks good and this only replaces the one place, I pinged Matteo if there is interest we should follow up with a PR that replaces validateAbortSignal with the brand check

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Sep 29, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2024
nodejs-github-bot pushed a commit that referenced this pull request Sep 29, 2024
lib: implement interface converter in webidl
a5a946d 
PR-URL: #54965
Fixes: #54962
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot commented Sep 29, 2024

Copy link
Copy Markdown
Collaborator

Landed in 27dab9d...e973c3e

nodejs-github-bot pushed a commit that referenced this pull request Sep 29, 2024
lib: validate signals with interface converter
e973c3e 
PR-URL: #54965
Fixes: #54962
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS mentioned this pull request Oct 9, 2024
Merged
RafaelGSS added a commit that referenced this pull request Oct 9, 2024
2024-10-15, Version 23.0.0 (Current)
1c258f4 
Semver-Major Commits:

assert,util:
  * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495
buffer:
  * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588
  * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613
build:
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077
  * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077
  * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081
  * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079
  * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184
  * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427
child_process:
  * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793
cli:
  * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761
  * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747
  * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723
  * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611
  * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564
crypto:
  * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019
  * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305
  * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552
deps:
  * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536
  * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077
  * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077
doc:
  * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967
  * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338
esm:
  * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848
events:
  * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889
fs:
  * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741
  * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050
lib:
  * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965
  * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965
  * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355
net:
  * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470
path:
  * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224
process:
  * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035
src:
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077
  * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077
  * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174
  * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347
stream:
  * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241
string_decoder:
  * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957
test:
  * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077
test_runner:
  * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881
  * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548
  * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403
timers:
  * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678
tls:
  * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627
tools:
  * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536
  * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077
util:
  * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744
zlib:
  * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020

PR-URL: #55338
RafaelGSS added a commit that referenced this pull request Oct 11, 2024
2024-10-15, Version 23.0.0 (Current)
2ba706f 
Semver-Major Commits:

assert,util:
  * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495
buffer:
  * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588
  * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613
build:
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077
  * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077
  * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081
  * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079
  * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184
  * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427
child_process:
  * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793
cli:
  * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761
  * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747
  * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723
  * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611
  * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564
crypto:
  * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019
  * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305
  * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552
deps:
  * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536
  * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077
  * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077
doc:
  * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967
  * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338
esm:
  * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848
events:
  * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889
fs:
  * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741
  * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050
lib:
  * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965
  * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965
  * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355
net:
  * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470
path:
  * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224
process:
  * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035
src:
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077
  * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077
  * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174
  * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347
stream:
  * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241
string_decoder:
  * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957
test:
  * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077
test_runner:
  * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881
  * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548
  * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403
timers:
  * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678
tls:
  * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627
tools:
  * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536
  * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077
util:
  * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744
zlib:
  * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020

PR-URL: #55338
RafaelGSS added a commit that referenced this pull request Oct 16, 2024
2024-10-16, Version 23.0.0 (Current)
80c8998 
Semver-Major Commits:

assert,util:
  * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495
buffer:
  * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588
  * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613
build:
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077
  * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077
  * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081
  * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079
  * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184
  * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427
child_process:
  * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793
cli:
  * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761
  * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747
  * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723
  * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611
  * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564
crypto:
  * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019
  * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305
  * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552
deps:
  * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536
  * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077
  * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077
doc:
  * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967
  * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338
esm:
  * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848
events:
  * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889
fs:
  * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741
  * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050
lib:
  * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965
  * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965
  * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355
net:
  * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470
path:
  * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224
process:
  * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035
src:
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077
  * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077
  * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174
  * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347
stream:
  * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241
string_decoder:
  * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957
test:
  * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077
test_runner:
  * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881
  * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548
  * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403
timers:
  * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678
tls:
  * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627
tools:
  * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536
  * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077
util:
  * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744
zlib:
  * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020

PR-URL: #55338
RafaelGSS added a commit that referenced this pull request Oct 16, 2024
2024-10-16, Version 23.0.0 (Current)
fa8f149 
Semver-Major Commits:

assert,util:
  * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495
buffer:
  * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588
  * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613
build:
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077
  * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077
  * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081
  * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079
  * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184
  * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427
child_process:
  * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793
cli:
  * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761
  * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747
  * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723
  * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611
  * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564
crypto:
  * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019
  * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305
  * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552
deps:
  * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536
  * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077
  * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077
doc:
  * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967
  * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338
esm:
  * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848
events:
  * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889
fs:
  * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741
  * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050
lib:
  * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965
  * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965
  * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355
net:
  * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470
path:
  * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224
process:
  * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035
src:
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077
  * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077
  * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174
  * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347
stream:
  * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241
string_decoder:
  * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957
test:
  * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077
test_runner:
  * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881
  * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548
  * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403
timers:
  * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678
tls:
  * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627
tools:
  * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536
  * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077
util:
  * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744
zlib:
  * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020

PR-URL: #55338
jazelly deleted the validate-abort-signal branch November 25, 2024 22:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 left review comments
atlowChemi atlowChemi left review comments
mcollina mcollina approved these changes
jasnell jasnell approved these changes
benjamingr benjamingr approved these changes
KhafraDev KhafraDev approved these changes

Assignees

No one assigned

Labels

abortcontroller Issues and PRs related to the AbortController API commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-benchmark-ci PR that need a benchmark CI run. needs-ci PRs that need a full CI run. needs-citgm PRs that need a CITGM CI run. semver-major PRs that contain breaking changes and should be released in the next major version. web-standards Issues and PRs related to Web APIs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

{aborted: false} is treated as valid AbortSignal but not in other runtimes
Back | FazBrowse Home | New Git URL