deps: patch V8 to 12.9.202.19 - #55057
Closed
nodejs-github-bot wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Review requested:
|
Sorry, something went wrong.
gengjiawen
approved these changes
Sep 22, 2024
richardlau
approved these changes
Sep 22, 2024
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
Sorry, something went wrong.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Author
Sorry, something went wrong.
targos
approved these changes
Sep 22, 2024
marco-ippolito
approved these changes
Sep 22, 2024
RafaelGSS
approved these changes
Sep 22, 2024
Copy link
Copy Markdown
Collaborator
Author
Commit Queue failed- Loading data for nodejs/node/pull/55057 ✔ Done loading data for nodejs/node/pull/55057 ----------------------------------- PR info ------------------------------------ Title deps: patch V8 to 12.9.202.19 (#55057) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/update-v8-patch -> nodejs:main Labels v8 engine, needs-ci, dependencies, dont-land-on-v18.x, dont-land-on-v20.x Commits 1 - deps: patch V8 to 12.9.202.19 Committers 1 - Node.js GitHub Bot <github-bot@iojs.org> PR-URL: https://github.com/nodejs/node/pull/55057 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55057 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 22 Sep 2024 00:35:00 GMT ✔ Approvals: 5 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/55057#pullrequestreview-2319954818 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/55057#pullrequestreview-2319955425 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/55057#pullrequestreview-2320080342 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/55057#pullrequestreview-2320652136 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/55057#pullrequestreview-2320832422 ✘ GitHub CI is still running ℹ Last Full PR CI on 2024-09-22T05:57:15Z: https://ci.nodejs.org/job/node-test-pull-request/62662/ - Querying data for job/node-test-pull-request/62662/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11004789220 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
The CQ failure would be solved by nodejs/node-core-utils#857. |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Sep 25, 2024
Refs: v8/v8@12.9.202.18...12.9.202.19 PR-URL: #55057 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated patch update of V8 to 12.9.202.19.