fix(git-node): ignore all non-gha nodes when checking for GitHub CI - #857
Merged
aduh95 merged 3 commits intoSep 26, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This was referenced Sep 24, 2024
Comment thread
lib/pr_checker.js
| // GitHub new Check API | ||
| for (const { status, conclusion, app } of checkSuites.nodes) { | ||
| if (app && IGNORED_CHECK_SLUGS.includes(app.slug)) { | ||
| if (app.slug !== 'github-actions') { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Suggested change
| if (app.slug !== 'github-actions') { | |
| if (app && app.slug !== 'github-actions') { |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
| if (app.slug !== 'github-actions') { | |
| if (app?.slug !== 'github-actions') { |
a suggestion upon your suggestion
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
I'm not sure this is needed.
Sorry, something went wrong.
avivkeller
reviewed
Sep 24, 2024
Comment thread
lib/pr_checker.js
Outdated
richardlau
approved these changes
Sep 24, 2024
Co-authored-by: Aviv Keller <redyetidev@gmail.com>
Copy link
Copy Markdown
Member
Now I don't understand:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
One way is to apply the following diff and run git node land on a PR which head branch in on nodejs/node. diff --git a/lib/pr_checker.js b/lib/pr_checker.js
index 064c647..129b9a5 100644
--- a/lib/pr_checker.js
+++ b/lib/pr_checker.js
@@ -381,6 +381,7 @@ export default class PRChecker {
}
if (status !== 'COMPLETED') {
+ console.log(checkSuites.nodes);
cli.error('GitHub CI is still running');
return false;
}
@@ -395,6 +396,7 @@ export default class PRChecker {
if (commit.status) {
const { state } = commit.status;
if (state === 'PENDING') {
+ console.log(checkSuites.nodes);
cli.error('GitHub CI is still running');
return false;
} |
Sorry, something went wrong.
targos
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #838 (comment). The problem has come back now that we have a new jenkins-node-js-ci (see nodejs/admin#916), and IMO it only makes sense to check for GHA-related jobs only when checking the state of the GitHub CI.