[v20.x backport] buffer: fix out of range for toString - #55213
Closed
jazelly wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
jazelly
force-pushed
the
backport-54553
branch
2 times, most recently
from
8eecdb8 to
0df499a
Compare
October 2, 2024 11:39
targos
approved these changes
Oct 2, 2024
targos
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
Co-authored-by: Michaël Zasso <targos@protonmail.com> PR-URL: nodejs#54553 Fixes: nodejs#52298 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
jazelly
force-pushed
the
backport-54553
branch
from
0df499a to
e53b79c
Compare
October 3, 2024 07:31
Copy link
Copy Markdown
Member
Author
|
The coverage report seems strange. I don't think this commit would drag down the coverage that much, nor did I see other merged commits with this coverage check. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
We have this problem with all pull requests on v22.x and v20.x. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
marco-ippolito
pushed a commit
that referenced
this pull request
Nov 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the failing test by decreasing the buffer allocation size.
Refs: #54553
cc @targos