buffer: fix out of range for toString - #54553
Merged
nodejs-github-bot merged 2 commits intoSep 6, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
jazelly
force-pushed
the
fix-buffer-out-of-range
branch
from
b7c5b2f to
5e8d38a
Compare
August 25, 2024 15:19
Copy link
Copy Markdown
Member
|
Hi! It seems part of the commit may have been posted by @targos in the original issue, could you add him as a Co-Author? |
Sorry, something went wrong.
jasnell
approved these changes
Aug 25, 2024
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #54553 +/- ##
=======================================
Coverage 87.34% 87.34%
=======================================
Files 649 649
Lines 182562 182562
Branches 35023 35031 +8
=======================================
+ Hits 159451 159458 +7
+ Misses 16396 16382 -14
- Partials 6715 6722 +7
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@redyetidev Of course! Thanks for the heads up |
Sorry, something went wrong.
jazelly
force-pushed
the
fix-buffer-out-of-range
branch
from
5e8d38a to
f223e15
Compare
August 25, 2024 22:38
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Michaël Zasso <targos@protonmail.com>
jazelly
force-pushed
the
fix-buffer-out-of-range
branch
from
f223e15 to
93befdf
Compare
August 28, 2024 14:25
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jakecastelli
approved these changes
Aug 31, 2024
Copy link
Copy Markdown
Member
|
Benchmark result https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1627/ 🟢 Results confidence improvement accuracy (*) (**) (***)
buffers/buffer-atob.js n=1000000 size=128 0.06 % ±0.50% ±0.66% ±0.86%
buffers/buffer-atob.js n=1000000 size=16 0.77 % ±1.03% ±1.37% ±1.79%
buffers/buffer-atob.js n=1000000 size=32 -0.08 % ±0.96% ±1.28% ±1.68%
buffers/buffer-atob.js n=1000000 size=64 -0.44 % ±0.89% ±1.19% ±1.55%
buffers/buffer-base64-decode-wrapped.js n=32 linesCount=524288 charsPerLine=76 0.13 % ±0.35% ±0.46% ±0.60%
buffers/buffer-base64-decode.js size=8388608 n=32 0.00 % ±0.17% ±0.23% ±0.30%
buffers/buffer-base64-encode.js n=32 len=67108864 -0.02 % ±0.11% ±0.15% ±0.19%
buffers/buffer-base64url-decode.js size=8388608 n=32 * -0.16 % ±0.16% ±0.21% ±0.27%
buffers/buffer-base64url-encode.js n=32 len=67108864 0.03 % ±0.08% ±0.10% ±0.13%
buffers/buffer-btoa.js n=1000000 size=1024 *** 1.51 % ±0.61% ±0.81% ±1.06%
buffers/buffer-btoa.js n=1000000 size=128 -0.46 % ±1.61% ±2.15% ±2.79%
buffers/buffer-btoa.js n=1000000 size=16 0.26 % ±0.84% ±1.12% ±1.46%
buffers/buffer-btoa.js n=1000000 size=256 -1.37 % ±1.45% ±1.93% ±2.51%
buffers/buffer-btoa.js n=1000000 size=32 1.03 % ±1.90% ±2.54% ±3.33%
buffers/buffer-btoa.js n=1000000 size=64 * -1.13 % ±1.08% ±1.44% ±1.91%
buffers/buffer-bytelength-buffer.js n=4000000 len=16 -0.75 % ±2.29% ±3.05% ±3.97%
buffers/buffer-bytelength-buffer.js n=4000000 len=2 0.36 % ±1.87% ±2.49% ±3.24%
buffers/buffer-bytelength-buffer.js n=4000000 len=256 1.76 % ±2.50% ±3.33% ±4.34%
buffers/buffer-bytelength-string.js n=4000000 repeat=1 encoding='base64' type='four_bytes' 0.05 % ±1.90% ±2.53% ±3.31%
buffers/buffer-bytelength-string.js n=4000000 repeat=1 encoding='base64' type='latin1' -0.05 % ±1.92% ±2.55% ±3.32%
buffers/buffer-bytelength-string.js n=4000000 repeat=1 encoding='base64' type='one_byte' -0.47 % ±2.23% ±2.96% ±3.86%
buffers/buffer-bytelength-string.js n=4000000 repeat=1 encoding='base64' type='three_bytes' 0.45 % ±2.21% ±2.95% ±3.84%
buffers/buffer-bytelength-string.js n=4000000 repeat=1 encoding='base64' type='two_bytes' 0.23 % ±2.21% ±2.95% ±3.84%
buffers/buffer-bytelength-string.js n=4000000 repeat=1 encoding='utf8' type='four_bytes' -0.35 % ±0.88% ±1.18% ±1.53%
buffers/buffer-bytelength-string.js n=4000000 repeat=1 encoding='utf8' type='latin1' 0.02 % ±1.29% ±1.72% ±2.24%
buffers/buffer-bytelength-string.js n=4000000 repeat=1 encoding='utf8' type='one_byte' 0.02 % ±2.03% ±2.71% ±3.52%
buffers/buffer-bytelength-string.js n=4000000 repeat=1 encoding='utf8' type='three_bytes' -0.94 % ±1.79% ±2.39% ±3.11%
buffers/buffer-bytelength-string.js n=4000000 repeat=1 encoding='utf8' type='two_bytes' 0.02 % ±0.65% ±0.87% ±1.14%
buffers/buffer-bytelength-string.js n=4000000 repeat=16 encoding='base64' type='four_bytes' -0.37 % ±1.64% ±2.18% ±2.84%
buffers/buffer-bytelength-string.js n=4000000 repeat=16 encoding='base64' type='latin1' 0.70 % ±1.76% ±2.34% ±3.05%
buffers/buffer-bytelength-string.js n=4000000 repeat=16 encoding='base64' type='one_byte' -1.10 % ±2.00% ±2.65% ±3.45%
buffers/buffer-bytelength-string.js n=4000000 repeat=16 encoding='base64' type='three_bytes' 0.20 % ±1.68% ±2.24% ±2.92%
buffers/buffer-bytelength-string.js n=4000000 repeat=16 encoding='base64' type='two_bytes' * -1.39 % ±1.28% ±1.70% ±2.22%
buffers/buffer-bytelength-string.js n=4000000 repeat=16 encoding='utf8' type='four_bytes' 0.11 % ±0.12% ±0.16% ±0.21%
buffers/buffer-bytelength-string.js n=4000000 repeat=16 encoding='utf8' type='latin1' *** -0.39 % ±0.18% ±0.23% ±0.31%
buffers/buffer-bytelength-string.js n=4000000 repeat=16 encoding='utf8' type='one_byte' * -0.79 % ±0.69% ±0.92% ±1.20%
buffers/buffer-bytelength-string.js n=4000000 repeat=16 encoding='utf8' type='three_bytes' -0.21 % ±0.22% ±0.29% ±0.38%
buffers/buffer-bytelength-string.js n=4000000 repeat=16 encoding='utf8' type='two_bytes' 0.21 % ±0.28% ±0.37% ±0.48%
buffers/buffer-bytelength-string.js n=4000000 repeat=2 encoding='base64' type='four_bytes' -0.34 % ±1.83% ±2.43% ±3.16%
buffers/buffer-bytelength-string.js n=4000000 repeat=2 encoding='base64' type='latin1' 0.11 % ±1.74% ±2.32% ±3.02%
buffers/buffer-bytelength-string.js n=4000000 repeat=2 encoding='base64' type='one_byte' -1.11 % ±1.84% ±2.45% ±3.19%
buffers/buffer-bytelength-string.js n=4000000 repeat=2 encoding='base64' type='three_bytes' -0.94 % ±1.80% ±2.40% ±3.12%
buffers/buffer-bytelength-string.js n=4000000 repeat=2 encoding='base64' type='two_bytes' -0.10 % ±1.91% ±2.55% ±3.32%
buffers/buffer-bytelength-string.js n=4000000 repeat=2 encoding='utf8' type='four_bytes' 0.44 % ±0.73% ±0.97% ±1.26%
buffers/buffer-bytelength-string.js n=4000000 repeat=2 encoding='utf8' type='latin1' -0.56 % ±0.60% ±0.80% ±1.05%
buffers/buffer-bytelength-string.js n=4000000 repeat=2 encoding='utf8' type='one_byte' 0.47 % ±1.84% ±2.45% ±3.19%
buffers/buffer-bytelength-string.js n=4000000 repeat=2 encoding='utf8' type='three_bytes' 0.20 % ±1.20% ±1.60% ±2.09%
buffers/buffer-bytelength-string.js n=4000000 repeat=2 encoding='utf8' type='two_bytes' -0.73 % ±1.75% ±2.33% ±3.03%
buffers/buffer-bytelength-string.js n=4000000 repeat=256 encoding='base64' type='four_bytes' 0.67 % ±1.75% ±2.33% ±3.03%
buffers/buffer-bytelength-string.js n=4000000 repeat=256 encoding='base64' type='latin1' 0.34 % ±1.96% ±2.61% ±3.40%
buffers/buffer-bytelength-string.js n=4000000 repeat=256 encoding='base64' type='one_byte' -0.53 % ±2.31% ±3.08% ±4.01%
buffers/buffer-bytelength-string.js n=4000000 repeat=256 encoding='base64' type='three_bytes' -0.41 % ±1.50% ±2.00% ±2.60%
buffers/buffer-bytelength-string.js n=4000000 repeat=256 encoding='base64' type='two_bytes' -1.00 % ±1.66% ±2.21% ±2.87%
buffers/buffer-bytelength-string.js n=4000000 repeat=256 encoding='utf8' type='four_bytes' -0.00 % ±0.01% ±0.01% ±0.01%
buffers/buffer-bytelength-string.js n=4000000 repeat=256 encoding='utf8' type='latin1' -0.02 % ±0.06% ±0.08% ±0.10%
buffers/buffer-bytelength-string.js n=4000000 repeat=256 encoding='utf8' type='one_byte' -0.11 % ±0.11% ±0.14% ±0.18%
buffers/buffer-bytelength-string.js n=4000000 repeat=256 encoding='utf8' type='three_bytes' -0.00 % ±0.02% ±0.03% ±0.04%
buffers/buffer-bytelength-string.js n=4000000 repeat=256 encoding='utf8' type='two_bytes' -0.03 % ±0.10% ±0.13% ±0.17%
buffers/buffer-compare-instance-method.js n=1000000 args=1 size=16 1.19 % ±3.38% ±4.50% ±5.86%
buffers/buffer-compare-instance-method.js n=1000000 args=1 size=16386 -0.87 % ±1.18% ±1.59% ±2.10%
buffers/buffer-compare-instance-method.js n=1000000 args=1 size=4096 -1.33 % ±2.35% ±3.14% ±4.11%
buffers/buffer-compare-instance-method.js n=1000000 args=1 size=512 -2.81 % ±4.32% ±5.76% ±7.50%
buffers/buffer-compare-instance-method.js n=1000000 args=2 size=16 -0.56 % ±1.56% ±2.08% ±2.71%
buffers/buffer-compare-instance-method.js n=1000000 args=2 size=16386 -0.08 % ±2.44% ±3.24% ±4.22%
buffers/buffer-compare-instance-method.js n=1000000 args=2 size=4096 -1.54 % ±3.45% ±4.59% ±5.97%
buffers/buffer-compare-instance-method.js n=1000000 args=2 size=512 0.03 % ±1.04% ±1.38% ±1.80%
buffers/buffer-compare-instance-method.js n=1000000 args=5 size=16 0.84 % ±1.36% ±1.81% ±2.36%
buffers/buffer-compare-instance-method.js n=1000000 args=5 size=16386 -0.04 % ±3.67% ±4.88% ±6.35%
buffers/buffer-compare-instance-method.js n=1000000 args=5 size=4096 1.04 % ±2.85% ±3.79% ±4.93%
buffers/buffer-compare-instance-method.js n=1000000 args=5 size=512 0.26 % ±0.97% ±1.29% ±1.69%
buffers/buffer-compare-offset.js n=1000000 size=16 method='offset' 0.89 % ±1.54% ±2.05% ±2.67%
buffers/buffer-compare-offset.js n=1000000 size=16 method='slice' 0.63 % ±1.09% ±1.45% ±1.89%
buffers/buffer-compare-offset.js n=1000000 size=16386 method='offset' 0.23 % ±1.57% ±2.08% ±2.71%
buffers/buffer-compare-offset.js n=1000000 size=16386 method='slice' 0.40 % ±0.97% ±1.29% ±1.68%
buffers/buffer-compare-offset.js n=1000000 size=4096 method='offset' -0.00 % ±1.03% ±1.37% ±1.78%
buffers/buffer-compare-offset.js n=1000000 size=4096 method='slice' -0.71 % ±1.10% ±1.47% ±1.93%
buffers/buffer-compare-offset.js n=1000000 size=512 method='offset' -0.02 % ±1.22% ±1.63% ±2.13%
buffers/buffer-compare-offset.js n=1000000 size=512 method='slice' -0.56 % ±1.21% ±1.61% ±2.09%
buffers/buffer-compare.js n=1000000 size=16 -0.55 % ±2.72% ±3.62% ±4.72%
buffers/buffer-compare.js n=1000000 size=16386 0.21 % ±1.20% ±1.61% ±2.11%
buffers/buffer-compare.js n=1000000 size=4096 -0.61 % ±1.21% ±1.61% ±2.10%
buffers/buffer-compare.js n=1000000 size=512 0.58 % ±2.69% ±3.57% ±4.65%
buffers/buffer-concat-fill.js n=800000 extraSize=1 -0.04 % ±0.37% ±0.49% ±0.63%
buffers/buffer-concat-fill.js n=800000 extraSize=1024 0.47 % ±0.68% ±0.90% ±1.17%
buffers/buffer-concat-fill.js n=800000 extraSize=256 -0.27 % ±0.54% ±0.72% ±0.93%
buffers/buffer-concat.js n=800000 withTotalLength=0 pieceSize=1 pieces=16 0.09 % ±0.28% ±0.38% ±0.49%
buffers/buffer-concat.js n=800000 withTotalLength=0 pieceSize=1 pieces=4 0.03 % ±0.65% ±0.87% ±1.13%
buffers/buffer-concat.js n=800000 withTotalLength=0 pieceSize=16 pieces=16 -0.07 % ±0.59% ±0.79% ±1.03%
buffers/buffer-concat.js n=800000 withTotalLength=0 pieceSize=16 pieces=4 0.48 % ±1.22% ±1.62% ±2.13%
buffers/buffer-concat.js n=800000 withTotalLength=0 pieceSize=256 pieces=16 -0.40 % ±0.74% ±0.99% ±1.29%
buffers/buffer-concat.js n=800000 withTotalLength=0 pieceSize=256 pieces=4 0.18 % ±0.73% ±0.97% ±1.26%
buffers/buffer-concat.js n=800000 withTotalLength=1 pieceSize=1 pieces=16 0.13 % ±0.36% ±0.48% ±0.62%
buffers/buffer-concat.js n=800000 withTotalLength=1 pieceSize=1 pieces=4 0.25 % ±0.75% ±1.00% ±1.31%
buffers/buffer-concat.js n=800000 withTotalLength=1 pieceSize=16 pieces=16 -0.07 % ±0.71% ±0.95% ±1.23%
buffers/buffer-concat.js n=800000 withTotalLength=1 pieceSize=16 pieces=4 1.47 % ±2.06% ±2.76% ±3.63%
buffers/buffer-concat.js n=800000 withTotalLength=1 pieceSize=256 pieces=16 -0.20 % ±0.72% ±0.96% ±1.25%
buffers/buffer-concat.js n=800000 withTotalLength=1 pieceSize=256 pieces=4 * 0.59 % ±0.56% ±0.75% ±0.98%
buffers/buffer-copy.js n=6000000 partial='false' bytes=0 -1.88 % ±2.60% ±3.46% ±4.52%
buffers/buffer-copy.js n=6000000 partial='false' bytes=128 -0.15 % ±0.51% ±0.68% ±0.88%
buffers/buffer-copy.js n=6000000 partial='false' bytes=32768 1.31 % ±2.04% ±2.74% ±3.63%
buffers/buffer-copy.js n=6000000 partial='false' bytes=8 -0.19 % ±0.88% ±1.17% ±1.53%
buffers/buffer-copy.js n=6000000 partial='true' bytes=0 0.18 % ±1.65% ±2.20% ±2.86%
buffers/buffer-copy.js n=6000000 partial='true' bytes=128 -0.39 % ±0.72% ±0.96% ±1.26%
buffers/buffer-copy.js n=6000000 partial='true' bytes=32768 -2.26 % ±4.79% ±6.46% ±8.58%
buffers/buffer-copy.js n=6000000 partial='true' bytes=8 -0.11 % ±0.89% ±1.19% ±1.54%
buffers/buffer-creation.js n=600000 len=10 type='fast-alloc-fill' -0.05 % ±1.22% ±1.63% ±2.12%
buffers/buffer-creation.js n=600000 len=10 type='fast-alloc' -0.07 % ±1.39% ±1.86% ±2.42%
buffers/buffer-creation.js n=600000 len=10 type='fast-allocUnsafe' -0.37 % ±0.90% ±1.20% ±1.56%
buffers/buffer-creation.js n=600000 len=10 type='slow-allocUnsafe' -0.77 % ±0.85% ±1.13% ±1.47%
buffers/buffer-creation.js n=600000 len=1024 type='fast-alloc-fill' 0.11 % ±0.83% ±1.11% ±1.44%
buffers/buffer-creation.js n=600000 len=1024 type='fast-alloc' 0.35 % ±0.83% ±1.10% ±1.43%
buffers/buffer-creation.js n=600000 len=1024 type='fast-allocUnsafe' 0.18 % ±0.89% ±1.19% ±1.55%
buffers/buffer-creation.js n=600000 len=1024 type='slow-allocUnsafe' -0.11 % ±0.92% ±1.23% ±1.60%
buffers/buffer-creation.js n=600000 len=4096 type='fast-alloc-fill' -0.02 % ±0.70% ±0.92% ±1.20%
buffers/buffer-creation.js n=600000 len=4096 type='fast-alloc' -0.48 % ±0.80% ±1.07% ±1.39%
buffers/buffer-creation.js n=600000 len=4096 type='fast-allocUnsafe' -0.28 % ±0.67% ±0.89% ±1.16%
buffers/buffer-creation.js n=600000 len=4096 type='slow-allocUnsafe' 0.69 % ±0.73% ±0.98% ±1.27%
buffers/buffer-creation.js n=600000 len=8192 type='fast-alloc-fill' 0.04 % ±0.65% ±0.87% ±1.13%
buffers/buffer-creation.js n=600000 len=8192 type='fast-alloc' -0.14 % ±0.64% ±0.85% ±1.11%
buffers/buffer-creation.js n=600000 len=8192 type='fast-allocUnsafe' -0.45 % ±1.03% ±1.37% ±1.79%
buffers/buffer-creation.js n=600000 len=8192 type='slow-allocUnsafe' -0.81 % ±0.97% ±1.29% ±1.68%
buffers/buffer-equals.js n=1000000 difflen='false' size=0 -0.52 % ±3.56% ±4.74% ±6.16%
buffers/buffer-equals.js n=1000000 difflen='false' size=16386 -0.09 % ±0.32% ±0.43% ±0.57%
buffers/buffer-equals.js n=1000000 difflen='false' size=512 -0.11 % ±3.30% ±4.40% ±5.72%
buffers/buffer-equals.js n=1000000 difflen='true' size=0 -2.29 % ±3.58% ±4.77% ±6.24%
buffers/buffer-equals.js n=1000000 difflen='true' size=16386 -2.26 % ±2.36% ±3.16% ±4.18%
buffers/buffer-equals.js n=1000000 difflen='true' size=512 -0.22 % ±1.72% ±2.28% ±2.97%
buffers/buffer-fill.js n=20000 size=65536 type='fill("")' 0.05 % ±1.95% ±2.60% ±3.38%
buffers/buffer-fill.js n=20000 size=65536 type='fill("t", "utf8")' 0.71 % ±1.85% ±2.46% ±3.20%
buffers/buffer-fill.js n=20000 size=65536 type='fill("t", 0, "utf8")' -0.66 % ±1.61% ±2.15% ±2.80%
buffers/buffer-fill.js n=20000 size=65536 type='fill("t", 0)' 1.18 % ±1.71% ±2.27% ±2.97%
buffers/buffer-fill.js n=20000 size=65536 type='fill("t")' 0.36 % ±1.37% ±1.82% ±2.38%
buffers/buffer-fill.js n=20000 size=65536 type='fill("test")' -0.02 % ±1.90% ±2.53% ±3.30%
buffers/buffer-fill.js n=20000 size=65536 type='fill(0)' -0.53 % ±1.97% ±2.63% ±3.42%
buffers/buffer-fill.js n=20000 size=65536 type='fill(100)' 0.29 % ±1.66% ±2.21% ±2.88%
buffers/buffer-fill.js n=20000 size=65536 type='fill(400)' 0.02 % ±1.79% ±2.38% ±3.10%
buffers/buffer-fill.js n=20000 size=65536 type='fill(Buffer.alloc(1), 0)' -0.97 % ±1.41% ±1.89% ±2.47%
buffers/buffer-fill.js n=20000 size=8192 type='fill("")' * 2.21 % ±2.08% ±2.77% ±3.60%
buffers/buffer-fill.js n=20000 size=8192 type='fill("t", "utf8")' 0.18 % ±1.52% ±2.02% ±2.64%
buffers/buffer-fill.js n=20000 size=8192 type='fill("t", 0, "utf8")' -0.80 % ±1.91% ±2.55% ±3.33%
buffers/buffer-fill.js n=20000 size=8192 type='fill("t", 0)' -0.48 % ±1.83% ±2.44% ±3.17%
buffers/buffer-fill.js n=20000 size=8192 type='fill("t")' 0.65 % ±1.91% ±2.55% ±3.31%
buffers/buffer-fill.js n=20000 size=8192 type='fill("test")' -2.49 % ±2.59% ±3.44% ±4.48%
buffers/buffer-fill.js n=20000 size=8192 type='fill(0)' -1.14 % ±3.15% ±4.19% ±5.45%
buffers/buffer-fill.js n=20000 size=8192 type='fill(100)' -0.45 % ±1.98% ±2.64% ±3.44%
buffers/buffer-fill.js n=20000 size=8192 type='fill(400)' 0.90 % ±3.45% ±4.60% ±6.01%
buffers/buffer-fill.js n=20000 size=8192 type='fill(Buffer.alloc(1), 0)' 2.50 % ±3.54% ±4.72% ±6.15%
buffers/buffer-from.js n=800000 len=100 source='array' -0.06 % ±0.74% ±0.98% ±1.28%
buffers/buffer-from.js n=800000 len=100 source='arraybuffer-middle' 0.48 % ±2.02% ±2.69% ±3.51%
buffers/buffer-from.js n=800000 len=100 source='arraybuffer' -0.56 % ±2.08% ±2.76% ±3.59%
buffers/buffer-from.js n=800000 len=100 source='buffer' 0.61 % ±1.24% ±1.65% ±2.15%
buffers/buffer-from.js n=800000 len=100 source='object' * 1.42 % ±1.40% ±1.87% ±2.45%
buffers/buffer-from.js n=800000 len=100 source='string-base64' 0.15 % ±0.73% ±0.97% ±1.26%
buffers/buffer-from.js n=800000 len=100 source='string-utf8' 0.45 % ±0.89% ±1.18% ±1.54%
buffers/buffer-from.js n=800000 len=100 source='string' -0.24 % ±0.72% ±0.96% ±1.25%
buffers/buffer-from.js n=800000 len=100 source='uint16array' -0.34 % ±0.85% ±1.13% ±1.47%
buffers/buffer-from.js n=800000 len=100 source='uint8array' -0.20 % ±1.48% ±1.97% ±2.56%
buffers/buffer-from.js n=800000 len=2048 source='array' -0.02 % ±0.09% ±0.12% ±0.16%
buffers/buffer-from.js n=800000 len=2048 source='arraybuffer-middle' -1.62 % ±2.45% ±3.28% ±4.30%
buffers/buffer-from.js n=800000 len=2048 source='arraybuffer' 0.55 % ±1.73% ±2.30% ±3.00%
buffers/buffer-from.js n=800000 len=2048 source='buffer' 0.08 % ±1.01% ±1.34% ±1.75%
buffers/buffer-from.js n=800000 len=2048 source='object' -0.23 % ±2.03% ±2.70% ±3.52%
buffers/buffer-from.js n=800000 len=2048 source='string-base64' -0.05 % ±0.68% ±0.90% ±1.18%
buffers/buffer-from.js n=800000 len=2048 source='string-utf8' 0.30 % ±0.67% ±0.89% ±1.16%
buffers/buffer-from.js n=800000 len=2048 source='string' 0.60 % ±0.76% ±1.01% ±1.32%
buffers/buffer-from.js n=800000 len=2048 source='uint16array' -0.15 % ±0.65% ±0.87% ±1.13%
buffers/buffer-from.js n=800000 len=2048 source='uint8array' 0.45 % ±0.76% ±1.02% ±1.33%
buffers/buffer-hex-decode.js n=1000000 len=1024 0.03 % ±0.25% ±0.34% ±0.44%
buffers/buffer-hex-decode.js n=1000000 len=64 *** 2.32 % ±0.55% ±0.73% ±0.95%
buffers/buffer-hex-encode.js n=1000000 len=1024 -0.11 % ±0.24% ±0.32% ±0.42%
buffers/buffer-hex-encode.js n=1000000 len=64 -0.25 % ±0.33% ±0.45% ±0.59%
buffers/buffer-indexof-number.js n=1000000 value=64 -2.58 % ±3.43% ±4.57% ±5.95%
buffers/buffer-indexof.js n=50000 type='buffer' encoding='undefined' search='--l' -0.02 % ±0.51% ±0.68% ±0.88%
buffers/buffer-indexof.js n=50000 type='buffer' encoding='undefined' search='@' -1.40 % ±3.97% ±5.29% ±6.88%
buffers/buffer-indexof.js n=50000 type='buffer' encoding='undefined' search='</i> to the Caterpillar' -0.02 % ±0.04% ±0.06% ±0.08%
buffers/buffer-indexof.js n=50000 type='buffer' encoding='undefined' search='aaaaaaaaaaaaaaaaa' -0.02 % ±0.08% ±0.11% ±0.14%
buffers/buffer-indexof.js n=50000 type='buffer' encoding='undefined' search='Alice' -1.16 % ±4.60% ±6.13% ±7.98%
buffers/buffer-indexof.js n=50000 type='buffer' encoding='undefined' search='found it very' -0.01 % ±0.06% ±0.08% ±0.10%
buffers/buffer-indexof.js n=50000 type='buffer' encoding='undefined' search='Gryphon' -0.80 % ±0.97% ±1.30% ±1.70%
buffers/buffer-indexof.js n=50000 type='buffer' encoding='undefined' search='neighbouring pool' 0.02 % ±0.05% ±0.07% ±0.09%
buffers/buffer-indexof.js n=50000 type='buffer' encoding='undefined' search='Ou est ma chatte?' -0.06 % ±0.16% ±0.22% ±0.28%
buffers/buffer-indexof.js n=50000 type='buffer' encoding='undefined' search='SQ' 0.68 % ±1.22% ±1.63% ±2.12%
buffers/buffer-indexof.js n=50000 type='buffer' encoding='undefined' search='venture to go near the house till she had brought herself down to' 1.06 % ±1.86% ±2.50% ±3.31%
buffers/buffer-indexof.js n=50000 type='string' encoding='ucs2' search='--l' -0.22 % ±0.57% ±0.77% ±1.02%
buffers/buffer-indexof.js n=50000 type='string' encoding='ucs2' search='@' -2.21 % ±3.48% ±4.66% ±6.11%
buffers/buffer-indexof.js n=50000 type='string' encoding='ucs2' search='</i> to the Caterpillar' -0.02 % ±0.06% ±0.08% ±0.11%
buffers/buffer-indexof.js n=50000 type='string' encoding='ucs2' search='aaaaaaaaaaaaaaaaa' 0.03 % ±0.13% ±0.17% ±0.23%
buffers/buffer-indexof.js n=50000 type='string' encoding='ucs2' search='Alice' -1.72 % ±1.90% ±2.53% ±3.29%
buffers/buffer-indexof.js n=50000 type='string' encoding='ucs2' search='found it very' 0.02 % ±0.05% ±0.06% ±0.08%
buffers/buffer-indexof.js n=50000 type='string' encoding='ucs2' search='Gryphon' -0.33 % ±0.34% ±0.46% ±0.60%
buffers/buffer-indexof.js n=50000 type='string' encoding='ucs2' search='neighbouring pool' -0.01 % ±0.08% ±0.11% ±0.14%
buffers/buffer-indexof.js n=50000 type='string' encoding='ucs2' search='Ou est ma chatte?' 0.02 % ±0.09% ±0.12% ±0.16%
buffers/buffer-indexof.js n=50000 type='string' encoding='ucs2' search='SQ' 0.43 % ±1.43% ±1.90% ±2.47%
buffers/buffer-indexof.js n=50000 type='string' encoding='ucs2' search='venture to go near the house till she had brought herself down to' -0.01 % ±0.08% ±0.11% ±0.14%
buffers/buffer-indexof.js n=50000 type='string' encoding='utf8' search='--l' 0.09 % ±0.24% ±0.32% ±0.42%
buffers/buffer-indexof.js n=50000 type='string' encoding='utf8' search='@' -1.46 % ±2.86% ±3.83% ±5.03%
buffers/buffer-indexof.js n=50000 type='string' encoding='utf8' search='</i> to the Caterpillar' 0.02 % ±0.04% ±0.05% ±0.06%
buffers/buffer-indexof.js n=50000 type='string' encoding='utf8' search='aaaaaaaaaaaaaaaaa' -0.08 % ±0.09% ±0.12% ±0.16%
buffers/buffer-indexof.js n=50000 type='string' encoding='utf8' search='Alice' -0.27 % ±2.41% ±3.22% ±4.21%
buffers/buffer-indexof.js n=50000 type='string' encoding='utf8' search='found it very' 0.15 % ±0.23% ±0.31% ±0.40%
buffers/buffer-indexof.js n=50000 type='string' encoding='utf8' search='Gryphon' 0.05 % ±0.89% ±1.19% ±1.54%
buffers/buffer-indexof.js n=50000 type='string' encoding='utf8' search='neighbouring pool' 0.03 % ±0.04% ±0.05% ±0.07%
buffers/buffer-indexof.js n=50000 type='string' encoding='utf8' search='Ou est ma chatte?' *** -0.68 % ±0.15% ±0.20% ±0.26%
buffers/buffer-indexof.js n=50000 type='string' encoding='utf8' search='SQ' *** -2.59 % ±1.21% ±1.63% ±2.15%
buffers/buffer-indexof.js n=50000 type='string' encoding='utf8' search='venture to go near the house till she had brought herself down to' 0.00 % ±0.09% ±0.12% ±0.15%
buffers/buffer-iterate.js n=1000 method='for' type='fast' size=16386 1.12 % ±1.94% ±2.59% ±3.39%
buffers/buffer-iterate.js n=1000 method='for' type='fast' size=4096 2.79 % ±2.79% ±3.73% ±4.88%
buffers/buffer-iterate.js n=1000 method='for' type='fast' size=512 3.50 % ±4.84% ±6.44% ±8.38%
buffers/buffer-iterate.js n=1000 method='forOf' type='fast' size=16386 -0.06 % ±0.29% ±0.39% ±0.51%
buffers/buffer-iterate.js n=1000 method='forOf' type='fast' size=4096 -0.59 % ±1.49% ±1.98% ±2.57%
buffers/buffer-iterate.js n=1000 method='forOf' type='fast' size=512 -0.97 % ±3.22% ±4.29% ±5.58%
buffers/buffer-iterate.js n=1000 method='iterator' type='fast' size=16386 -0.33 % ±0.42% ±0.56% ±0.73%
buffers/buffer-iterate.js n=1000 method='iterator' type='fast' size=4096 0.65 % ±1.67% ±2.22% ±2.89%
buffers/buffer-iterate.js n=1000 method='iterator' type='fast' size=512 0.44 % ±3.19% ±4.24% ±5.53%
buffers/buffer-normalize-encoding.js n=1000000 encoding='ascii' 0.69 % ±2.61% ±3.47% ±4.51%
buffers/buffer-normalize-encoding.js n=1000000 encoding='base64' 1.19 % ±2.29% ±3.07% ±4.04%
buffers/buffer-normalize-encoding.js n=1000000 encoding='BASE64' -0.26 % ±3.32% ±4.42% ±5.75%
buffers/buffer-normalize-encoding.js n=1000000 encoding='binary' 1.24 % ±3.51% ±4.68% ±6.11%
buffers/buffer-normalize-encoding.js n=1000000 encoding='hex' -0.97 % ±1.66% ±2.21% ±2.88%
buffers/buffer-normalize-encoding.js n=1000000 encoding='HEX' 1.35 % ±4.72% ±6.28% ±8.18%
buffers/buffer-normalize-encoding.js n=1000000 encoding='latin1' * 7.27 % ±5.79% ±7.70% ±10.02%
buffers/buffer-normalize-encoding.js n=1000000 encoding='LATIN1' -1.19 % ±2.96% ±3.94% ±5.14%
buffers/buffer-normalize-encoding.js n=1000000 encoding='UCS-2' 0.39 % ±2.07% ±2.76% ±3.59%
buffers/buffer-normalize-encoding.js n=1000000 encoding='UCS2' -0.04 % ±3.83% ±5.10% ±6.64%
buffers/buffer-normalize-encoding.js n=1000000 encoding='utf-16le' 1.48 % ±2.05% ±2.74% ±3.58%
buffers/buffer-normalize-encoding.js n=1000000 encoding='UTF-16LE' 3.01 % ±5.97% ±7.96% ±10.38%
buffers/buffer-normalize-encoding.js n=1000000 encoding='utf-8' -0.65 % ±2.43% ±3.23% ±4.20%
buffers/buffer-normalize-encoding.js n=1000000 encoding='utf16le' -0.41 % ±1.49% ±1.98% ±2.58%
buffers/buffer-normalize-encoding.js n=1000000 encoding='UTF16LE' -0.72 % ±5.53% ±7.36% ±9.58%
buffers/buffer-normalize-encoding.js n=1000000 encoding='utf8' 0.76 % ±2.76% ±3.70% ±4.86%
buffers/buffer-normalize-encoding.js n=1000000 encoding='UTF8' 0.51 % ±1.79% ±2.38% ±3.10%
buffers/buffer-read-float.js n=1000000 value='big' endian='LE' type='Double' * 1.00 % ±0.78% ±1.04% ±1.37%
buffers/buffer-read-float.js n=1000000 value='big' endian='LE' type='Float' 0.42 % ±0.79% ±1.05% ±1.37%
buffers/buffer-read-float.js n=1000000 value='inf' endian='LE' type='Double' -0.00 % ±0.69% ±0.91% ±1.19%
buffers/buffer-read-float.js n=1000000 value='inf' endian='LE' type='Float' 0.60 % ±0.87% ±1.16% ±1.52%
buffers/buffer-read-float.js n=1000000 value='nan' endian='LE' type='Double' 0.34 % ±1.50% ±2.01% ±2.62%
buffers/buffer-read-float.js n=1000000 value='nan' endian='LE' type='Float' -0.04 % ±0.91% ±1.21% ±1.58%
buffers/buffer-read-float.js n=1000000 value='small' endian='LE' type='Double' 0.23 % ±0.97% ±1.29% ±1.68%
buffers/buffer-read-float.js n=1000000 value='small' endian='LE' type='Float' 0.61 % ±1.22% ±1.62% ±2.11%
buffers/buffer-read-float.js n=1000000 value='zero' endian='LE' type='Double' * 1.61 % ±1.42% ±1.89% ±2.47%
buffers/buffer-read-float.js n=1000000 value='zero' endian='LE' type='Float' 0.03 % ±0.96% ±1.27% ±1.66%
buffers/buffer-read-with-byteLength.js byteLength=1 n=1000000 type='IntBE' buffer='fast' -0.30 % ±1.44% ±1.93% ±2.53%
buffers/buffer-read-with-byteLength.js byteLength=1 n=1000000 type='IntLE' buffer='fast' -0.13 % ±0.62% ±0.82% ±1.07%
buffers/buffer-read-with-byteLength.js byteLength=1 n=1000000 type='UIntBE' buffer='fast' -0.05 % ±0.62% ±0.83% ±1.09%
buffers/buffer-read-with-byteLength.js byteLength=1 n=1000000 type='UIntLE' buffer='fast' 0.47 % ±0.50% ±0.67% ±0.87%
buffers/buffer-read-with-byteLength.js byteLength=2 n=1000000 type='IntBE' buffer='fast' -0.41 % ±1.29% ±1.72% ±2.25%
buffers/buffer-read-with-byteLength.js byteLength=2 n=1000000 type='IntLE' buffer='fast' 0.13 % ±0.82% ±1.10% ±1.45%
buffers/buffer-read-with-byteLength.js byteLength=2 n=1000000 type='UIntBE' buffer='fast' -0.10 % ±0.66% ±0.88% ±1.14%
buffers/buffer-read-with-byteLength.js byteLength=2 n=1000000 type='UIntLE' buffer='fast' 0.34 % ±0.49% ±0.65% ±0.86%
buffers/buffer-read-with-byteLength.js byteLength=3 n=1000000 type='IntBE' buffer='fast' -0.47 % ±0.73% ±0.97% ±1.26%
buffers/buffer-read-with-byteLength.js byteLength=3 n=1000000 type='IntLE' buffer='fast' 0.25 % ±0.52% ±0.69% ±0.90%
buffers/buffer-read-with-byteLength.js byteLength=3 n=1000000 type='UIntBE' buffer='fast' -0.11 % ±0.67% ±0.89% ±1.16%
buffers/buffer-read-with-byteLength.js byteLength=3 n=1000000 type='UIntLE' buffer='fast' -0.02 % ±0.81% ±1.08% ±1.40%
buffers/buffer-read-with-byteLength.js byteLength=4 n=1000000 type='IntBE' buffer='fast' -0.04 % ±0.71% ±0.94% ±1.22%
buffers/buffer-read-with-byteLength.js byteLength=4 n=1000000 type='IntLE' buffer='fast' -0.28 % ±0.56% ±0.74% ±0.97%
buffers/buffer-read-with-byteLength.js byteLength=4 n=1000000 type='UIntBE' buffer='fast' -0.57 % ±0.70% ±0.94% ±1.22%
buffers/buffer-read-with-byteLength.js byteLength=4 n=1000000 type='UIntLE' buffer='fast' *** -1.39 % ±0.74% ±0.98% ±1.28%
buffers/buffer-read-with-byteLength.js byteLength=5 n=1000000 type='IntBE' buffer='fast' 0.06 % ±0.67% ±0.89% ±1.16%
buffers/buffer-read-with-byteLength.js byteLength=5 n=1000000 type='IntLE' buffer='fast' * -0.57 % ±0.49% ±0.66% ±0.86%
buffers/buffer-read-with-byteLength.js byteLength=5 n=1000000 type='UIntBE' buffer='fast' -0.49 % ±0.53% ±0.70% ±0.91%
buffers/buffer-read-with-byteLength.js byteLength=5 n=1000000 type='UIntLE' buffer='fast' -0.79 % ±1.04% ±1.40% ±1.84%
buffers/buffer-read-with-byteLength.js byteLength=6 n=1000000 type='IntBE' buffer='fast' -0.29 % ±0.73% ±0.97% ±1.26%
buffers/buffer-read-with-byteLength.js byteLength=6 n=1000000 type='IntLE' buffer='fast' * -0.59 % ±0.58% ±0.77% ±1.01%
buffers/buffer-read-with-byteLength.js byteLength=6 n=1000000 type='UIntBE' buffer='fast' -0.17 % ±0.81% ±1.08% ±1.41%
buffers/buffer-read-with-byteLength.js byteLength=6 n=1000000 type='UIntLE' buffer='fast' -0.14 % ±0.63% ±0.84% ±1.09%
buffers/buffer-read.js n=1000000 type='BigInt64BE' buffer='fast' 0.70 % ±1.69% ±2.27% ±2.99%
buffers/buffer-read.js n=1000000 type='BigInt64LE' buffer='fast' 0.50 % ±2.57% ±3.41% ±4.44%
buffers/buffer-read.js n=1000000 type='BigUInt64BE' buffer='fast' -0.13 % ±0.97% ±1.29% ±1.68%
buffers/buffer-read.js n=1000000 type='BigUInt64LE' buffer='fast' -0.57 % ±0.98% ±1.30% ±1.69%
buffers/buffer-read.js n=1000000 type='Int16BE' buffer='fast' -0.28 % ±1.02% ±1.35% ±1.76%
buffers/buffer-read.js n=1000000 type='Int16LE' buffer='fast' 0.13 % ±1.69% ±2.26% ±2.94%
buffers/buffer-read.js n=1000000 type='Int32BE' buffer='fast' -0.84 % ±0.84% ±1.12% ±1.46%
buffers/buffer-read.js n=1000000 type='Int32LE' buffer='fast' -0.38 % ±1.05% ±1.40% ±1.82%
buffers/buffer-read.js n=1000000 type='Int8' buffer='fast' 0.22 % ±1.84% ±2.45% ±3.19%
buffers/buffer-read.js n=1000000 type='UInt16BE' buffer='fast' -1.26 % ±1.82% ±2.42% ±3.15%
buffers/buffer-read.js n=1000000 type='UInt16LE' buffer='fast' 0.03 % ±2.56% ±3.41% ±4.44%
buffers/buffer-read.js n=1000000 type='UInt32BE' buffer='fast' -0.16 % ±1.14% ±1.52% ±1.98%
buffers/buffer-read.js n=1000000 type='UInt32LE' buffer='fast' -0.27 % ±1.27% ±1.70% ±2.22%
buffers/buffer-read.js n=1000000 type='UInt8' buffer='fast' 0.59 % ±2.52% ±3.36% ±4.38%
buffers/buffer-slice.js n=1000000 type='fast' 1.73 % ±2.23% ±2.96% ±3.87%
buffers/buffer-slice.js n=1000000 type='slow' -0.87 % ±2.29% ±3.04% ±3.96%
buffers/buffer-slice.js n=1000000 type='subarray' -0.18 % ±1.58% ±2.10% ±2.74%
buffers/buffer-swap.js n=1000000 len=1024 method='swap16' aligned='false' * -1.59 % ±1.26% ±1.68% ±2.18%
buffers/buffer-swap.js n=1000000 len=1024 method='swap16' aligned='true' -0.46 % ±1.19% ±1.59% ±2.07%
buffers/buffer-swap.js n=1000000 len=1024 method='swap32' aligned='false' -0.23 % ±0.50% ±0.67% ±0.87%
buffers/buffer-swap.js n=1000000 len=1024 method='swap32' aligned='true' 0.23 % ±0.54% ±0.72% ±0.93%
buffers/buffer-swap.js n=1000000 len=1024 method='swap64' aligned='false' -0.10 % ±0.77% ±1.02% ±1.33%
buffers/buffer-swap.js n=1000000 len=1024 method='swap64' aligned='true' 0.25 % ±0.76% ±1.02% ±1.32%
buffers/buffer-swap.js n=1000000 len=2056 method='swap16' aligned='false' 0.28 % ±0.42% ±0.56% ±0.73%
buffers/buffer-swap.js n=1000000 len=2056 method='swap16' aligned='true' 0.36 % ±0.38% ±0.51% ±0.66%
buffers/buffer-swap.js n=1000000 len=2056 method='swap32' aligned='false' -0.11 % ±0.29% ±0.38% ±0.50%
buffers/buffer-swap.js n=1000000 len=2056 method='swap32' aligned='true' -0.24 % ±0.29% ±0.39% ±0.50%
buffers/buffer-swap.js n=1000000 len=2056 method='swap64' aligned='false' 0.06 % ±0.57% ±0.76% ±0.99%
buffers/buffer-swap.js n=1000000 len=2056 method='swap64' aligned='true' 0.31 % ±0.61% ±0.81% ±1.05%
buffers/buffer-swap.js n=1000000 len=256 method='swap16' aligned='false' -0.06 % ±0.79% ±1.05% ±1.37%
buffers/buffer-swap.js n=1000000 len=256 method='swap16' aligned='true' -0.27 % ±0.90% ±1.19% ±1.56%
buffers/buffer-swap.js n=1000000 len=256 method='swap32' aligned='false' -0.09 % ±2.75% ±3.66% ±4.77%
buffers/buffer-swap.js n=1000000 len=256 method='swap32' aligned='true' 0.68 % ±2.55% ±3.39% ±4.42%
buffers/buffer-swap.js n=1000000 len=256 method='swap64' aligned='false' -1.13 % ±1.69% ±2.25% ±2.93%
buffers/buffer-swap.js n=1000000 len=256 method='swap64' aligned='true' -1.45 % ±1.83% ±2.44% ±3.18%
buffers/buffer-swap.js n=1000000 len=64 method='swap16' aligned='false' 0.31 % ±0.97% ±1.30% ±1.69%
buffers/buffer-swap.js n=1000000 len=64 method='swap16' aligned='true' 2.16 % ±2.51% ±3.34% ±4.35%
buffers/buffer-swap.js n=1000000 len=64 method='swap32' aligned='false' 0.46 % ±1.01% ±1.34% ±1.74%
buffers/buffer-swap.js n=1000000 len=64 method='swap32' aligned='true' 0.57 % ±1.24% ±1.65% ±2.16%
buffers/buffer-swap.js n=1000000 len=64 method='swap64' aligned='false' -0.21 % ±0.61% ±0.81% ±1.05%
buffers/buffer-swap.js n=1000000 len=64 method='swap64' aligned='true' -0.50 % ±1.14% ±1.52% ±1.98%
buffers/buffer-swap.js n=1000000 len=768 method='swap16' aligned='false' -0.17 % ±0.71% ±0.94% ±1.22%
buffers/buffer-swap.js n=1000000 len=768 method='swap16' aligned='true' * -0.72 % ±0.70% ±0.94% ±1.22%
buffers/buffer-swap.js n=1000000 len=768 method='swap32' aligned='false' -0.27 % ±0.78% ±1.03% ±1.35%
buffers/buffer-swap.js n=1000000 len=768 method='swap32' aligned='true' 0.65 % ±0.75% ±1.00% ±1.30%
buffers/buffer-swap.js n=1000000 len=768 method='swap64' aligned='false' -0.94 % ±1.31% ±1.74% ±2.27%
buffers/buffer-swap.js n=1000000 len=768 method='swap64' aligned='true' 1.18 % ±1.51% ±2.01% ±2.62%
buffers/buffer-swap.js n=1000000 len=8192 method='swap16' aligned='false' 0.36 % ±0.40% ±0.53% ±0.69%
buffers/buffer-swap.js n=1000000 len=8192 method='swap16' aligned='true' 0.27 % ±0.42% ±0.57% ±0.74%
buffers/buffer-swap.js n=1000000 len=8192 method='swap32' aligned='false' -0.03 % ±0.06% ±0.08% ±0.10%
buffers/buffer-swap.js n=1000000 len=8192 method='swap32' aligned='true' 0.01 % ±0.07% ±0.10% ±0.13%
buffers/buffer-swap.js n=1000000 len=8192 method='swap64' aligned='false' 0.03 % ±0.16% ±0.21% ±0.27%
buffers/buffer-swap.js n=1000000 len=8192 method='swap64' aligned='true' -0.09 % ±0.17% ±0.22% ±0.29%
buffers/buffer-tojson.js len=0 n=10000 -6.34 % ±13.53% ±18.00% ±23.43%
buffers/buffer-tojson.js len=256 n=10000 -1.09 % ±2.07% ±2.75% ±3.58%
buffers/buffer-tojson.js len=4096 n=10000 0.56 % ±1.97% ±2.63% ±3.42%
buffers/buffer-tostring.js n=1000000 len=1 args=0 encoding='' -1.08 % ±1.59% ±2.11% ±2.75%
buffers/buffer-tostring.js n=1000000 len=1 args=1 encoding='ascii' * 2.67 % ±2.29% ±3.05% ±3.97%
buffers/buffer-tostring.js n=1000000 len=1 args=1 encoding='hex' *** 4.86 % ±1.44% ±1.91% ±2.49%
buffers/buffer-tostring.js n=1000000 len=1 args=1 encoding='latin1' ** 3.24 % ±2.36% ±3.14% ±4.09%
buffers/buffer-tostring.js n=1000000 len=1 args=1 encoding='UCS-2' *** 5.86 % ±1.13% ±1.50% ±1.95%
buffers/buffer-tostring.js n=1000000 len=1 args=1 encoding='utf8' 2.25 % ±2.62% ±3.49% ±4.54%
buffers/buffer-tostring.js n=1000000 len=1 args=3 encoding='ascii' 0.98 % ±2.11% ±2.81% ±3.67%
buffers/buffer-tostring.js n=1000000 len=1 args=3 encoding='hex' ** -3.29 % ±2.40% ±3.21% ±4.22%
buffers/buffer-tostring.js n=1000000 len=1 args=3 encoding='latin1' 0.61 % ±2.10% ±2.81% ±3.67%
buffers/buffer-tostring.js n=1000000 len=1 args=3 encoding='UCS-2' -1.30 % ±1.30% ±1.73% ±2.25%
buffers/buffer-tostring.js n=1000000 len=1 args=3 encoding='utf8' 2.62 % ±3.28% ±4.37% ±5.69%
buffers/buffer-tostring.js n=1000000 len=1024 args=0 encoding='' 0.20 % ±0.58% ±0.77% ±1.00%
buffers/buffer-tostring.js n=1000000 len=1024 args=1 encoding='ascii' -1.02 % ±1.04% ±1.39% ±1.81%
buffers/buffer-tostring.js n=1000000 len=1024 args=1 encoding='hex' *** -1.02 % ±0.20% ±0.27% ±0.35%
buffers/buffer-tostring.js n=1000000 len=1024 args=1 encoding='latin1' * 1.06 % ±0.84% ±1.12% ±1.46%
buffers/buffer-tostring.js n=1000000 len=1024 args=1 encoding='UCS-2' *** 1.02 % ±0.54% ±0.71% ±0.93%
buffers/buffer-tostring.js n=1000000 len=1024 args=1 encoding='utf8' *** 1.83 % ±0.62% ±0.83% ±1.08%
buffers/buffer-tostring.js n=1000000 len=1024 args=3 encoding='ascii' *** -3.65 % ±1.17% ±1.56% ±2.04%
buffers/buffer-tostring.js n=1000000 len=1024 args=3 encoding='hex' 0.31 % ±0.36% ±0.48% ±0.62%
buffers/buffer-tostring.js n=1000000 len=1024 args=3 encoding='latin1' -0.12 % ±0.95% ±1.27% ±1.65%
buffers/buffer-tostring.js n=1000000 len=1024 args=3 encoding='UCS-2' -0.35 % ±0.89% ±1.18% ±1.54%
buffers/buffer-tostring.js n=1000000 len=1024 args=3 encoding='utf8' -0.14 % ±0.74% ±0.98% ±1.27%
buffers/buffer-tostring.js n=1000000 len=64 args=0 encoding='' 0.67 % ±1.51% ±2.02% ±2.63%
buffers/buffer-tostring.js n=1000000 len=64 args=1 encoding='ascii' *** 2.35 % ±1.14% ±1.51% ±1.97%
buffers/buffer-tostring.js n=1000000 len=64 args=1 encoding='hex' ** 1.28 % ±0.75% ±1.01% ±1.31%
buffers/buffer-tostring.js n=1000000 len=64 args=1 encoding='latin1' 1.36 % ±1.41% ±1.88% ±2.45%
buffers/buffer-tostring.js n=1000000 len=64 args=1 encoding='UCS-2' -0.34 % ±1.21% ±1.61% ±2.11%
buffers/buffer-tostring.js n=1000000 len=64 args=1 encoding='utf8' 1.50 % ±1.53% ±2.03% ±2.65%
buffers/buffer-tostring.js n=1000000 len=64 args=3 encoding='ascii' *** 2.63 % ±1.03% ±1.38% ±1.79%
buffers/buffer-tostring.js n=1000000 len=64 args=3 encoding='hex' 0.01 % ±0.68% ±0.91% ±1.18%
buffers/buffer-tostring.js n=1000000 len=64 args=3 encoding='latin1' 0.37 % ±1.23% ±1.64% ±2.14%
buffers/buffer-tostring.js n=1000000 len=64 args=3 encoding='UCS-2' ** -1.99 % ±1.28% ±1.71% ±2.24%
buffers/buffer-tostring.js n=1000000 len=64 args=3 encoding='utf8' 0.15 % ±0.72% ±0.96% ±1.25%
buffers/buffer-transcode.js n=100000 length=1 toEncoding='ascii' fromEncoding='ascii' -0.47 % ±1.00% ±1.32% ±1.72%
buffers/buffer-transcode.js n=100000 length=1 toEncoding='ascii' fromEncoding='latin1' -0.21 % ±0.77% ±1.02% ±1.34%
buffers/buffer-transcode.js n=100000 length=1 toEncoding='ascii' fromEncoding='ucs2' * 1.11 % ±1.11% ±1.47% ±1.92%
buffers/buffer-transcode.js n=100000 length=1 toEncoding='ascii' fromEncoding='utf8' -0.42 % ±0.94% ±1.25% ±1.62%
buffers/buffer-transcode.js n=100000 length=1 toEncoding='latin1' fromEncoding='ascii' -0.67 % ±0.99% ±1.32% ±1.72%
buffers/buffer-transcode.js n=100000 length=1 toEncoding='latin1' fromEncoding='latin1' -0.01 % ±0.79% ±1.05% ±1.37%
buffers/buffer-transcode.js n=100000 length=1 toEncoding='latin1' fromEncoding='ucs2' -0.58 % ±1.11% ±1.48% ±1.93%
buffers/buffer-transcode.js n=100000 length=1 toEncoding='latin1' fromEncoding='utf8' 0.45 % ±0.88% ±1.17% ±1.52%
buffers/buffer-transcode.js n=100000 length=1 toEncoding='ucs2' fromEncoding='ascii' 0.49 % ±1.26% ±1.68% ±2.19%
buffers/buffer-transcode.js n=100000 length=1 toEncoding='ucs2' fromEncoding='latin1' 0.04 % ±1.19% ±1.58% ±2.06%
buffers/buffer-transcode.js n=100000 length=1 toEncoding='ucs2' fromEncoding='ucs2' 0.31 % ±1.05% ±1.39% ±1.81%
buffers/buffer-transcode.js n=100000 length=1 toEncoding='ucs2' fromEncoding='utf8' 0.29 % ±1.26% ±1.68% ±2.19%
buffers/buffer-transcode.js n=100000 length=1 toEncoding='utf8' fromEncoding='ascii' -0.22 % ±0.63% ±0.83% ±1.09%
buffers/buffer-transcode.js n=100000 length=1 toEncoding='utf8' fromEncoding='latin1' 0.47 % ±0.75% ±1.00% ±1.30%
buffers/buffer-transcode.js n=100000 length=1 toEncoding='utf8' fromEncoding='utf8' -0.32 % ±0.96% ±1.27% ±1.66%
buffers/buffer-transcode.js n=100000 length=10 toEncoding='ascii' fromEncoding='ascii' -0.72 % ±1.09% ±1.44% ±1.88%
buffers/buffer-transcode.js n=100000 length=10 toEncoding='ascii' fromEncoding='latin1' 0.14 % ±0.95% ±1.27% ±1.65%
buffers/buffer-transcode.js n=100000 length=10 toEncoding='ascii' fromEncoding='ucs2' 0.52 % ±0.82% ±1.09% ±1.41%
buffers/buffer-transcode.js n=100000 length=10 toEncoding='ascii' fromEncoding='utf8' -0.04 % ±1.15% ±1.53% ±1.99%
buffers/buffer-transcode.js n=100000 length=10 toEncoding='latin1' fromEncoding='ascii' -0.76 % ±0.91% ±1.21% ±1.58%
buffers/buffer-transcode.js n=100000 length=10 toEncoding='latin1' fromEncoding='latin1' 0.25 % ±0.91% ±1.21% ±1.57%
buffers/buffer-transcode.js n=100000 length=10 toEncoding='latin1' fromEncoding='ucs2' 0.12 % ±1.10% ±1.46% ±1.90%
buffers/buffer-transcode.js n=100000 length=10 toEncoding='latin1' fromEncoding='utf8' 0.57 % ±0.69% ±0.92% ±1.20%
buffers/buffer-transcode.js n=100000 length=10 toEncoding='ucs2' fromEncoding='ascii' -0.14 % ±1.38% ±1.84% ±2.40%
buffers/buffer-transcode.js n=100000 length=10 toEncoding='ucs2' fromEncoding='latin1' 0.04 % ±1.56% ±2.07% ±2.70%
buffers/buffer-transcode.js n=100000 length=10 toEncoding='ucs2' fromEncoding='ucs2' -0.33 % ±0.90% ±1.20% ±1.57%
buffers/buffer-transcode.js n=100000 length=10 toEncoding='ucs2' fromEncoding='utf8' -0.34 % ±1.37% ±1.82% ±2.37%
buffers/buffer-transcode.js n=100000 length=10 toEncoding='utf8' fromEncoding='ascii' 0.17 % ±1.05% ±1.40% ±1.83%
buffers/buffer-transcode.js n=100000 length=10 toEncoding='utf8' fromEncoding='latin1' 0.51 % ±0.93% ±1.24% ±1.62%
buffers/buffer-transcode.js n=100000 length=10 toEncoding='utf8' fromEncoding='utf8' 0.91 % ±1.41% ±1.88% ±2.45%
buffers/buffer-transcode.js n=100000 length=1000 toEncoding='ascii' fromEncoding='ascii' -0.22 % ±0.69% ±0.91% ±1.19%
buffers/buffer-transcode.js n=100000 length=1000 toEncoding='ascii' fromEncoding='latin1' -0.49 % ±0.54% ±0.72% ±0.94%
buffers/buffer-transcode.js n=100000 length=1000 toEncoding='ascii' fromEncoding='ucs2' -1.16 % ±2.30% ±3.09% ±4.11%
buffers/buffer-transcode.js n=100000 length=1000 toEncoding='ascii' fromEncoding='utf8' 0.14 % ±0.82% ±1.09% ±1.42%
buffers/buffer-transcode.js n=100000 length=1000 toEncoding='latin1' fromEncoding='ascii' 0.43 % ±0.77% ±1.03% ±1.34%
buffers/buffer-transcode.js n=100000 length=1000 toEncoding='latin1' fromEncoding='latin1' 0.38 % ±0.85% ±1.14% ±1.49%
buffers/buffer-transcode.js n=100000 length=1000 toEncoding='latin1' fromEncoding='ucs2' 0.05 % ±0.10% ±0.14% ±0.18%
buffers/buffer-transcode.js n=100000 length=1000 toEncoding='latin1' fromEncoding='utf8' 0.18 % ±0.51% ±0.69% ±0.89%
buffers/buffer-transcode.js n=100000 length=1000 toEncoding='ucs2' fromEncoding='ascii' -0.27 % ±0.71% ±0.94% ±1.22%
buffers/buffer-transcode.js n=100000 length=1000 toEncoding='ucs2' fromEncoding='latin1' -0.11 % ±0.81% ±1.08% ±1.41%
buffers/buffer-transcode.js n=100000 length=1000 toEncoding='ucs2' fromEncoding='ucs2' -0.15 % ±0.61% ±0.82% ±1.07%
buffers/buffer-transcode.js n=100000 length=1000 toEncoding='ucs2' fromEncoding='utf8' 0.25 % ±0.54% ±0.71% ±0.93%
buffers/buffer-transcode.js n=100000 length=1000 toEncoding='utf8' fromEncoding='ascii' 0.06 % ±0.38% ±0.51% ±0.66%
buffers/buffer-transcode.js n=100000 length=1000 toEncoding='utf8' fromEncoding='latin1' 0.37 % ±0.86% ±1.15% ±1.49%
buffers/buffer-transcode.js n=100000 length=1000 toEncoding='utf8' fromEncoding='utf8' 0.19 % ±0.55% ±0.74% ±0.96%
buffers/buffer-write-string-short.js n=1000000 len=1 encoding='ascii' 0.73 % ±2.37% ±3.15% ±4.11%
buffers/buffer-write-string-short.js n=1000000 len=1 encoding='latin1' -1.80 % ±2.50% ±3.33% ±4.33%
buffers/buffer-write-string-short.js n=1000000 len=1 encoding='utf8' -1.87 % ±2.70% ±3.60% ±4.69%
buffers/buffer-write-string-short.js n=1000000 len=16 encoding='ascii' -1.77 % ±2.25% ±2.99% ±3.89%
buffers/buffer-write-string-short.js n=1000000 len=16 encoding='latin1' 1.27 % ±3.01% ±4.01% ±5.22%
buffers/buffer-write-string-short.js n=1000000 len=16 encoding='utf8' -0.53 % ±2.01% ±2.68% ±3.49%
buffers/buffer-write-string-short.js n=1000000 len=32 encoding='ascii' -0.69 % ±2.55% ±3.40% ±4.43%
buffers/buffer-write-string-short.js n=1000000 len=32 encoding='latin1' -0.33 % ±2.48% ±3.30% ±4.30%
buffers/buffer-write-string-short.js n=1000000 len=32 encoding='utf8' 0.07 % ±1.43% ±1.90% ±2.47%
buffers/buffer-write-string-short.js n=1000000 len=8 encoding='ascii' -0.82 % ±2.07% ±2.75% ±3.58%
buffers/buffer-write-string-short.js n=1000000 len=8 encoding='latin1' 0.96 % ±3.33% ±4.43% ±5.76%
buffers/buffer-write-string-short.js n=1000000 len=8 encoding='utf8' 0.47 % ±2.01% ±2.67% ±3.48%
buffers/buffer-write-string.js n=1000000 len=2048 args='' encoding='' -0.06 % ±0.49% ±0.66% ±0.85%
buffers/buffer-write-string.js n=1000000 len=2048 args='' encoding='ascii' -0.21 % ±2.04% ±2.72% ±3.56%
buffers/buffer-write-string.js n=1000000 len=2048 args='' encoding='hex' *** 0.48 % ±0.12% ±0.16% ±0.21%
buffers/buffer-write-string.js n=1000000 len=2048 args='' encoding='latin1' -0.77 % ±1.32% ±1.76% ±2.29%
buffers/buffer-write-string.js n=1000000 len=2048 args='' encoding='utf16le' -0.05 % ±1.23% ±1.63% ±2.13%
buffers/buffer-write-string.js n=1000000 len=2048 args='' encoding='utf8' -0.44 % ±0.68% ±0.91% ±1.18%
buffers/buffer-write-string.js n=1000000 len=2048 args='offset' encoding='' -0.02 % ±0.62% ±0.83% ±1.08%
buffers/buffer-write-string.js n=1000000 len=2048 args='offset' encoding='ascii' -0.52 % ±1.24% ±1.65% ±2.15%
buffers/buffer-write-string.js n=1000000 len=2048 args='offset' encoding='hex' * 0.20 % ±0.19% ±0.25% ±0.32%
buffers/buffer-write-string.js n=1000000 len=2048 args='offset' encoding='latin1' 0.61 % ±1.75% ±2.33% ±3.03%
buffers/buffer-write-string.js n=1000000 len=2048 args='offset' encoding='utf16le' 0.74 % ±0.85% ±1.14% ±1.48%
buffers/buffer-write-string.js n=1000000 len=2048 args='offset' encoding='utf8' 0.79 % ±1.06% ±1.42% ±1.85%
buffers/buffer-write-string.js n=1000000 len=2048 args='offset+length' encoding='' -0.67 % ±0.70% ±0.93% ±1.22%
buffers/buffer-write-string.js n=1000000 len=2048 args='offset+length' encoding='ascii' -0.23 % ±0.84% ±1.11% ±1.45%
buffers/buffer-write-string.js n=1000000 len=2048 args='offset+length' encoding='hex' *** 0.75 % ±0.41% ±0.54% ±0.71%
buffers/buffer-write-string.js n=1000000 len=2048 args='offset+length' encoding='latin1' 0.65 % ±1.59% ±2.12% ±2.76%
buffers/buffer-write-string.js n=1000000 len=2048 args='offset+length' encoding='utf16le' 0.72 % ±1.04% ±1.39% ±1.81%
buffers/buffer-write-string.js n=1000000 len=2048 args='offset+length' encoding='utf8' 0.55 % ±0.91% ±1.21% ±1.57%
buffers/buffer-write.js n=1000000 type='BigInt64BE' buffer='fast' 0.06 % ±0.81% ±1.07% ±1.40%
buffers/buffer-write.js n=1000000 type='BigInt64LE' buffer='fast' * -1.26 % ±1.12% ±1.50% ±1.96%
buffers/buffer-write.js n=1000000 type='BigUInt64BE' buffer='fast' 0.03 % ±0.88% ±1.17% ±1.53%
buffers/buffer-write.js n=1000000 type='BigUInt64LE' buffer='fast' * 0.96 % ±0.84% ±1.12% ±1.47%
buffers/buffer-write.js n=1000000 type='DoubleBE' buffer='fast' 0.09 % ±0.73% ±0.97% ±1.27%
buffers/buffer-write.js n=1000000 type='DoubleLE' buffer='fast' -0.23 % ±0.76% ±1.01% ±1.31%
buffers/buffer-write.js n=1000000 type='FloatBE' buffer='fast' 0.01 % ±2.26% ±3.01% ±3.91%
buffers/buffer-write.js n=1000000 type='FloatLE' buffer='fast' -0.32 % ±1.49% ±1.98% ±2.57%
buffers/buffer-write.js n=1000000 type='Int16BE' buffer='fast' -0.23 % ±0.94% ±1.26% ±1.64%
buffers/buffer-write.js n=1000000 type='Int16LE' buffer='fast' -0.31 % ±1.05% ±1.40% ±1.84%
buffers/buffer-write.js n=1000000 type='Int32BE' buffer='fast' 0.48 % ±1.14% ±1.52% ±1.99%
buffers/buffer-write.js n=1000000 type='Int32LE' buffer='fast' 0.24 % ±0.93% ±1.24% ±1.62%
buffers/buffer-write.js n=1000000 type='Int8' buffer='fast' 0.34 % ±0.89% ±1.18% ±1.54%
buffers/buffer-write.js n=1000000 type='IntBE' buffer='fast' 0.34 % ±1.86% ±2.48% ±3.23%
buffers/buffer-write.js n=1000000 type='IntLE' buffer='fast' -0.55 % ±1.12% ±1.48% ±1.93%
buffers/buffer-write.js n=1000000 type='UInt16BE' buffer='fast' * -0.75 % ±0.75% ±0.99% ±1.29%
buffers/buffer-write.js n=1000000 type='UInt16LE' buffer='fast' 0.26 % ±1.29% ±1.72% ±2.24%
buffers/buffer-write.js n=1000000 type='UInt32BE' buffer='fast' -0.36 % ±0.64% ±0.85% ±1.11%
buffers/buffer-write.js n=1000000 type='UInt32LE' buffer='fast' -0.54 % ±0.93% ±1.23% ±1.61%
buffers/buffer-write.js n=1000000 type='UInt8' buffer='fast' -2.06 % ±2.83% ±3.77% ±4.92%
buffers/buffer-write.js n=1000000 type='UIntBE' buffer='fast' -0.76 % ±0.88% ±1.17% ±1.52%
buffers/buffer-write.js n=1000000 type='UIntLE' buffer='fast' ** -1.16 % ±0.76% ±1.01% ±1.31%
buffers/buffer-zero.js type='buffer' n=1000000 0.09 % ±1.12% ±1.49% ±1.94%
buffers/buffer-zero.js type='string' n=1000000 0.19 % ±2.19% ±2.91% ±3.79%
buffers/dataview-set.js n=1000000 type='Float32BE' * -4.15 % ±3.24% ±4.35% ±5.75%
buffers/dataview-set.js n=1000000 type='Float32LE' 0.78 % ±4.16% ±5.54% ±7.21%
buffers/dataview-set.js n=1000000 type='Float64BE' -0.63 % ±3.37% ±4.49% ±5.86%
buffers/dataview-set.js n=1000000 type='Float64LE' 2.53 % ±3.50% ±4.67% ±6.11%
buffers/dataview-set.js n=1000000 type='Int16BE' -1.11 % ±4.19% ±5.57% ±7.25%
buffers/dataview-set.js n=1000000 type='Int16LE' -3.68 % ±4.97% ±6.62% ±8.62%
buffers/dataview-set.js n=1000000 type='Int32BE' 1.73 % ±3.60% ±4.79% ±6.25%
buffers/dataview-set.js n=1000000 type='Int32LE' -1.22 % ±3.36% ±4.47% ±5.82%
buffers/dataview-set.js n=1000000 type='Int8' 1.29 % ±4.24% ±5.67% ±7.42%
buffers/dataview-set.js n=1000000 type='Uint16BE' -0.82 % ±3.93% ±5.24% ±6.82%
buffers/dataview-set.js n=1000000 type='Uint16LE' -0.81 % ±5.63% ±7.51% ±9.80%
buffers/dataview-set.js n=1000000 type='Uint32BE' 0.10 % ±1.45% ±1.93% ±2.52%
buffers/dataview-set.js n=1000000 type='Uint32LE' 2.04 % ±2.66% ±3.55% ±4.64%
buffers/dataview-set.js n=1000000 type='Uint8' -0.07 % ±4.23% ±5.63% ±7.33%
Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 467 comparisons, you can thus
expect the following amount of false-positive results:
23.35 false positives, when considering a 5% risk acceptance (*, **, ***),
4.67 false positives, when considering a 1% risk acceptance (**, ***),
0.47 false positives, when considering a 0.1% risk acceptance (***)
|
Sorry, something went wrong.
Merged
Copy link
Copy Markdown
Member
|
The test doesn't pass on v20.x-staging, so it will need a manual backport: $ ./node test/parallel/test-buffer-tostring-range.js
node:internal/errors:541
throw error;
^
RangeError [ERR_OUT_OF_RANGE]: The value of "size" is out of range. It must be >= 0 && <= 4294967296. Received 4_294_967_315
at Function.alloc (node:buffer:390:3)
at Object.<anonymous> (/Users/mzasso/git/nodejs/v20.x/test/parallel/test-buffer-tostring-range.js:107:28)
at Module._compile (node:internal/modules/cjs/loader:1469:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
at Module.load (node:internal/modules/cjs/loader:1288:32)
at Module._load (node:internal/modules/cjs/loader:1104:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:174:12)
at node:internal/main/run_main_module:28:49 {
code: 'ERR_OUT_OF_RANGE'
}
Node.js v20.17.1-pre
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I'll raise a backport PR for this tomorrow. |
Sorry, something went wrong.
jazelly
added a commit
to jazelly/node
that referenced
this pull request
Oct 3, 2024
Co-authored-by: Michaël Zasso <targos@protonmail.com> PR-URL: nodejs#54553 Fixes: nodejs#52298 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 22, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 28, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 29, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 31, 2024
jkleinsc
pushed a commit
to electron/electron
that referenced
this pull request
Nov 4, 2024
* chore: bump Node.js to v22.9.0 * build: drop base64 dep in GN build nodejs/node#52856 * build,tools: make addons tests work with GN nodejs/node#50737 * fs: add fast api for InternalModuleStat nodejs/node#51344 * src: move package_json_reader cache to c++ nodejs/node#50322 * crypto: disable PKCS#1 padding for privateDecrypt nodejs-private/node-private#525 * src: move more crypto code to ncrypto nodejs/node#54320 * crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey nodejs/node#50234 * src: shift more crypto impl details to ncrypto nodejs/node#54028 * src: switch crypto APIs to use Maybe<void> nodejs/node#54775 * crypto: remove DEFAULT_ENCODING nodejs/node#47182 * deps: update libuv to 1.47.0 nodejs/node#50650 * build: fix conflict gyp configs nodejs/node#53605 * lib,src: drop --experimental-network-imports nodejs/node#53822 * esm: align sync and async load implementations nodejs/node#49152 * esm: remove unnecessary toNamespacedPath calls nodejs/node#53656 * module: detect ESM syntax by trying to recompile as SourceTextModule nodejs/node#52413 * test: adapt debugger tests to V8 11.4 nodejs/node#49639 * lib: update usage of always on Atomics API nodejs/node#49639 * test: adapt test-fs-write to V8 internal changes nodejs/node#49639 * test: adapt to new V8 trusted memory spaces nodejs/node#50115 * deps: update libuv to 1.47.0 nodejs/node#50650 * src: use non-deprecated v8::Uint8Array::kMaxLength nodejs/node#50115 * src: update default V8 platform to override functions with location nodejs/node#51362 * src: add missing TryCatch nodejs/node#51362 * lib,test: handle new Iterator global nodejs/node#51362 * src: use non-deprecated version of CreateSyntheticModule nodejs/node#50115 * src: remove calls to recently deprecated V8 APIs nodejs/node#52996 * src: use new V8 API to define stream accessor nodejs/node#53084 * src: do not use deprecated V8 API nodejs/node#53084 * src: do not use soon-to-be-deprecated V8 API nodejs/node#53174 * src: migrate to new V8 interceptors API nodejs/node#52745 * src: use supported API to get stalled TLA messages nodejs/node#51362 * module: print location of unsettled top-level await in entry points nodejs/node#51999 * test: make snapshot comparison more flexible nodejs/node#54375 * test: do not set concurrency on parallelized runs nodejs/node#52177 * src: move FromNamespacedPath to path.cc nodejs/node#53540 * test: adapt to new V8 trusted memory spaces nodejs/node#50115 * build: add option to enable clang-cl on Windows nodejs/node#52870 * chore: fixup patch indices * chore: add/remove changed files * esm: drop support for import assertions nodejs/node#54890 * build: compile with C++20 support nodejs/node#52838 * deps: update nghttp2 to 1.62.1 nodejs/node#52966 * src: parse inspector profiles with simdjson nodejs/node#51783 * build: add GN build files nodejs/node#47637 * deps,lib,src: add experimental web storage nodejs/node#52435 * build: add missing BoringSSL dep * src: rewrite task runner in c++ nodejs/node#52609 * fixup! build: add GN build files * src: stop using deprecated fields of v8::FastApiCallbackOptions nodejs/node#54077 * fix: shadow variable * build: add back incorrectly removed SetAccessor patch * fixup! fixup! build: add GN build files * crypto: fix integer comparison in crypto for BoringSSL * src,lib: reducing C++ calls of esm legacy main resolve nodejs/node#48325 * src: move more crypto_dh.cc code to ncrypto nodejs/node#54459 * chore: fixup GN files for previous commit * src: move more crypto code to ncrypto nodejs/node#54320 * Fixup Perfetto ifdef guards * fix: missing electron_natives dep * fix: node_use_node_platform = false * fix: include src/node_snapshot_stub.cc in libnode * 5507047: [import-attributes] Remove support for import assertions https://chromium-review.googlesource.com/c/v8/v8/+/5507047 * fix: restore v8-sandbox.h in filenames.json * fix: re-add original-fs generation logic * fix: ngtcp2 openssl dep * test: try removing NAPI_VERSION undef * chore(deps): bump @types/node * src: move more crypto_dh.cc code to ncrypto nodejs/node#54459 * esm: remove unnecessary toNamespacedPath calls nodejs/node#53656 * buffer: fix out of range for toString nodejs/node#54553 * lib: rewrite AsyncLocalStorage without async_hooks nodejs/node#48528 * module: print amount of load time of a cjs module nodejs/node#52213 * test: skip reproducible snapshot test on 32-bit nodejs/node#53592 * fixup! src: move more crypto_dh.cc code to ncrypto * test: adjust emittedUntil return type * chore: remove redundant wpt streams patch * fixup! chore(deps): bump @types/node * fix: gn executable name on Windows * fix: build on Windows * fix: rename conflicting win32 symbols in //third_party/sqlite On Windows otherwise we get: lld-link: error: duplicate symbol: sqlite3_win32_write_debug >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:47987 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_sleep >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48042 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_is_nt >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48113 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_unicode >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48470 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_unicode_to_utf8 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48486 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48502 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8_v2 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48518 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48534 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs_v2 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48550 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj * docs: remove unnecessary ts-expect-error after types bump * src: move package resolver to c++ nodejs/node#50322 * build: set ASAN detect_container_overflow=0 nodejs/node#55584 * chore: fixup rebase * test: disable failing ASAN test * win: almost fix race detecting ESRCH in uv_kill libuv/libuv#4341
marco-ippolito
pushed a commit
that referenced
this pull request
Nov 16, 2024
Merged
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Nov 21, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | patch | `20.18.0` -> `20.18.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>nodejs/node (node)</summary> ### [`v20.18.1`](https://github.com/nodejs/node/releases/tag/v20.18.1): 2024-11-20, Version 20.18.1 'Iron' (LTS), @​marco-ippolito [Compare Source](nodejs/node@v20.18.0...v20.18.1) ##### Notable Changes - \[[`7a8992b2d6`](nodejs/node@7a8992b2d6)] - **doc**: add abmusse to collaborators (Abdirahim Musse) [#​55086](nodejs/node#55086) ##### Commits - \[[`085c3441fe`](nodejs/node@085c3441fe)] - **assert**: show the diff when deep comparing data with a custom message (Giovanni) [#​54759](nodejs/node#54759) - \[[`01f0b0e7b4`](nodejs/node@01f0b0e7b4)] - **benchmark**: adjust config for deepEqual object (Rafael Gonzaga) [#​55254](nodejs/node#55254) - \[[`a45537269b`](nodejs/node@a45537269b)] - **benchmark**: rewrite detect-esm-syntax benchmark (Joyee Cheung) [#​55238](nodejs/node#55238) - \[[`1a0d8ef64f`](nodejs/node@1a0d8ef64f)] - **benchmark**: add no-warnings to process.has bench (Rafael Gonzaga) [#​55159](nodejs/node#55159) - \[[`2be5d611ce`](nodejs/node@2be5d611ce)] - **benchmark**: create benchmark for typescript (Marco Ippolito) [#​54904](nodejs/node#54904) - \[[`a2aa4fa477`](nodejs/node@a2aa4fa477)] - **benchmark**: include ascii to fs/readfile (Rafael Gonzaga) [#​54988](nodejs/node#54988) - \[[`09849105fe`](nodejs/node@09849105fe)] - **benchmark**: add dotenv benchmark (Aviv Keller) [#​54278](nodejs/node#54278) - \[[`6b3c24dbad`](nodejs/node@6b3c24dbad)] - **buffer**: fix out of range for toString (Jason Zhang) [#​54553](nodejs/node#54553) - \[[`f25a5b6dc4`](nodejs/node@f25a5b6dc4)] - **build**: use rclone instead of aws CLI (Michaël Zasso) [#​55617](nodejs/node#55617) - \[[`0bbeb605de`](nodejs/node@0bbeb605de)] - **build**: fix notify-on-review-wanted action (Rafael Gonzaga) [#​55304](nodejs/node#55304) - \[[`5b35836732`](nodejs/node@5b35836732)] - **build**: include `.nycrc` in coverage workflows (Wuli Zuo) [#​55210](nodejs/node#55210) - \[[`f38d1e90e0`](nodejs/node@f38d1e90e0)] - **build**: notify via slack when review-wanted (Rafael Gonzaga) [#​55102](nodejs/node#55102) - \[[`0b985ec4bb`](nodejs/node@0b985ec4bb)] - **build**: remove -v flag to reduce noise (iwuliz) [#​55025](nodejs/node#55025) - \[[`09f75b27a1`](nodejs/node@09f75b27a1)] - **build**: display free disk space after build in the test-macOS workflow (iwuliz) [#​55025](nodejs/node#55025) - \[[`f25760c4a2`](nodejs/node@f25760c4a2)] - **build**: add the option to generate compile_commands.json in vcbuild.bat (Segev Finer) [#​52279](nodejs/node#52279) - \[[`746e78c4f3`](nodejs/node@746e78c4f3)] - ***Revert*** "**build**: upgrade clang-format to v18" (Chengzhong Wu) [#​54994](nodejs/node#54994) - \[[`67834ee646`](nodejs/node@67834ee646)] - **build**: print `Running XYZ linter...` for py and yml (Aviv Keller) [#​54386](nodejs/node#54386) - \[[`ae34e276a2`](nodejs/node@ae34e276a2)] - **build**: pin doc workflow to Node.js 20 (Richard Lau) [#​55755](nodejs/node#55755) - \[[`d0e871a706`](nodejs/node@d0e871a706)] - **build,win**: add winget config to set up env (Hüseyin Açacak) [#​54729](nodejs/node#54729) - \[[`93ac799b6b`](nodejs/node@93ac799b6b)] - **cli**: fix spacing for port range error (Aviv Keller) [#​54495](nodejs/node#54495) - \[[`3ba2e7bf97`](nodejs/node@3ba2e7bf97)] - ***Revert*** "**console**: colorize console error and warn" (Aviv Keller) [#​54677](nodejs/node#54677) - \[[`2f678ea53b`](nodejs/node@2f678ea53b)] - **crypto**: ensure invalid SubtleCrypto JWK data import results in DataError (Filip Skokan) [#​55041](nodejs/node#55041) - \[[`5d28d98542`](nodejs/node@5d28d98542)] - **deps**: update undici to 6.20.0 (Node.js GitHub Bot) [#​55329](nodejs/node#55329) - \[[`0c7f2fc421`](nodejs/node@0c7f2fc421)] - **deps**: update archs files for openssl-3.0.15+quic1 (Node.js GitHub Bot) [#​55184](nodejs/node#55184) - \[[`da15e7edf5`](nodejs/node@da15e7edf5)] - **deps**: upgrade openssl sources to quictls/openssl-3.0.15+quic1 (Node.js GitHub Bot) [#​55184](nodejs/node#55184) - \[[`381f1f9d08`](nodejs/node@381f1f9d08)] - **deps**: update archs files for openssl-3.0.14+quic1 (Node.js GitHub Bot) [#​54336](nodejs/node#54336) - \[[`48d643f78a`](nodejs/node@48d643f78a)] - **deps**: upgrade openssl sources to quictls/openssl-3.0.14+quic1 (Node.js GitHub Bot) [#​54336](nodejs/node#54336) - \[[`7b1796803b`](nodejs/node@7b1796803b)] - **deps**: update timezone to 2024b (Node.js GitHub Bot) [#​55056](nodejs/node#55056) - \[[`8f1956c588`](nodejs/node@8f1956c588)] - **deps**: update acorn-walk to 8.3.4 (Node.js GitHub Bot) [#​54950](nodejs/node#54950) - \[[`20501a7350`](nodejs/node@20501a7350)] - **deps**: update corepack to 0.29.4 (Node.js GitHub Bot) [#​54845](nodejs/node#54845) - \[[`0f81eafecc`](nodejs/node@0f81eafecc)] - **doc**: fix Markdown linter (Antoine du Hamel) [#​55344](nodejs/node#55344) - \[[`df713f0a98`](nodejs/node@df713f0a98)] - ***Revert*** "**doc**: update test context.assert" (Antoine du Hamel) [#​55344](nodejs/node#55344) - \[[`fd6fc61d2c`](nodejs/node@fd6fc61d2c)] - **doc**: add pmarchini to collaborators (Pietro Marchini) [#​55331](nodejs/node#55331) - \[[`b963db9ee2`](nodejs/node@b963db9ee2)] - **doc**: fix `events.once()` example using `AbortSignal` (Ivo Janssen) [#​55144](nodejs/node#55144) - \[[`50b13bfb12`](nodejs/node@50b13bfb12)] - **doc**: add onboarding details for ambassador program (Marco Ippolito) [#​55284](nodejs/node#55284) - \[[`27564b7811`](nodejs/node@27564b7811)] - **doc**: fix initial default value of autoSelectFamily (Ihor Rohovets) [#​55245](nodejs/node#55245) - \[[`9e7be23aa5`](nodejs/node@9e7be23aa5)] - **doc**: tweak onboarding instructions (Michael Dawson) [#​55212](nodejs/node#55212) - \[[`f412a029c3`](nodejs/node@f412a029c3)] - **doc**: update test context.assert (Pietro Marchini) [#​55186](nodejs/node#55186) - \[[`2f7828debb`](nodejs/node@2f7828debb)] - **doc**: fix unordered error anchors (Antoine du Hamel) [#​55242](nodejs/node#55242) - \[[`d08e4c235b`](nodejs/node@d08e4c235b)] - **doc**: mention addons to experimental permission (Rafael Gonzaga) [#​55166](nodejs/node#55166) - \[[`d65c2458dc`](nodejs/node@d65c2458dc)] - **doc**: use correct dash in stability status (Antoine du Hamel) [#​55200](nodejs/node#55200) - \[[`d9839c16cf`](nodejs/node@d9839c16cf)] - **doc**: fix link in `test/README.md` (Livia Medeiros) [#​55165](nodejs/node#55165) - \[[`1ad659afa4`](nodejs/node@1ad659afa4)] - **doc**: add esm examples to node:net (Alfredo González) [#​55134](nodejs/node#55134) - \[[`81ad69d50f`](nodejs/node@81ad69d50f)] - **doc**: move the YAML changes element (sendoru) [#​55112](nodejs/node#55112) - \[[`7a51a161be`](nodejs/node@7a51a161be)] - **doc**: fix the require resolve algorithm in `modules.md` (chirsz) [#​55117](nodejs/node#55117) - \[[`80edcdf899`](nodejs/node@80edcdf899)] - **doc**: update style guide (Aviv Keller) [#​53223](nodejs/node#53223) - \[[`388c754dd2`](nodejs/node@388c754dd2)] - **doc**: add missing `:` to `run()`'s `globPatterns` (Aviv Keller) [#​55135](nodejs/node#55135) - \[[`94302b6a76`](nodejs/node@94302b6a76)] - **doc**: add abmusse to collaborators (Abdirahim Musse) [#​55086](nodejs/node#55086) - \[[`27ff2da964`](nodejs/node@27ff2da964)] - **doc**: add note about `--expose-internals` (Aviv Keller) [#​52861](nodejs/node#52861) - \[[`df6dc753b7`](nodejs/node@df6dc753b7)] - **doc**: remove `parseREPLKeyword` from REPL documentation (Aviv Keller) [#​54749](nodejs/node#54749) - \[[`4baa5c4d10`](nodejs/node@4baa5c4d10)] - **doc**: change backporting guide with updated info (Aviv Keller) [#​53746](nodejs/node#53746) - \[[`9947fc112f`](nodejs/node@9947fc112f)] - **doc**: add missing definitions to `internal-api.md` (Aviv Keller) [#​53303](nodejs/node#53303) - \[[`a4586f0e94`](nodejs/node@a4586f0e94)] - **doc**: update documentation for externalizing deps (Michael Dawson) [#​54792](nodejs/node#54792) - \[[`70504f8522`](nodejs/node@70504f8522)] - **doc**: update `require(ESM)` history and stability status (Antoine du Hamel) [#​55199](nodejs/node#55199) - \[[`9d0041ac40`](nodejs/node@9d0041ac40)] - **doc**: add release key for aduh95 (Antoine du Hamel) [#​55349](nodejs/node#55349) - \[[`0c1666a52a`](nodejs/node@0c1666a52a)] - **events**: allow null/undefined eventInitDict (Matthew Aitken) [#​54643](nodejs/node#54643) - \[[`453df77f99`](nodejs/node@453df77f99)] - **events**: return `currentTarget` when dispatching (Matthew Aitken) [#​54642](nodejs/node#54642) - \[[`0decaab9db`](nodejs/node@0decaab9db)] - **fs**: acknowledge `signal` option in `filehandle.createReadStream()` (Livia Medeiros) [#​55148](nodejs/node#55148) - \[[`00a2fc7166`](nodejs/node@00a2fc7166)] - **lib**: move `Symbol[Async]Dispose` polyfills to `internal/util` (Antoine du Hamel) [#​54853](nodejs/node#54853) - \[[`8e6b606ac4`](nodejs/node@8e6b606ac4)] - **lib**: remove lib/internal/idna.js (Yagiz Nizipli) [#​55050](nodejs/node#55050) - \[[`c96e5cb664`](nodejs/node@c96e5cb664)] - **lib**: the REPL should survive deletion of Array.prototype methods (Jordan Harband) [#​31457](nodejs/node#31457) - \[[`748ed2e559`](nodejs/node@748ed2e559)] - **meta**: move one or more collaborators to emeritus (Node.js GitHub Bot) [#​55300](nodejs/node#55300) - \[[`8b8d35f015`](nodejs/node@8b8d35f015)] - **meta**: bump mozilla-actions/sccache-action from 0.0.5 to 0.0.6 (dependabot\[bot]) [#​55225](nodejs/node#55225) - \[[`d3441ff0c8`](nodejs/node@d3441ff0c8)] - **meta**: bump actions/checkout from 4.1.7 to 4.2.0 (dependabot\[bot]) [#​55224](nodejs/node#55224) - \[[`1c20908558`](nodejs/node@1c20908558)] - **meta**: bump actions/setup-node from 4.0.3 to 4.0.4 (dependabot\[bot]) [#​55223](nodejs/node#55223) - \[[`8a529abd69`](nodejs/node@8a529abd69)] - **meta**: bump peter-evans/create-pull-request from 7.0.1 to 7.0.5 (dependabot\[bot]) [#​55219](nodejs/node#55219) - \[[`9053d210ab`](nodejs/node@9053d210ab)] - **meta**: add mailmap entry for abmusse (Abdirahim Musse) [#​55182](nodejs/node#55182) - \[[`db2496c125`](nodejs/node@db2496c125)] - **meta**: add more information about nightly releases (Aviv Keller) [#​55084](nodejs/node#55084) - \[[`d2ce003b2f`](nodejs/node@d2ce003b2f)] - **meta**: add `linux` to OS labels in collaborator guide (Aviv Keller) [#​54986](nodejs/node#54986) - \[[`37b0bea247`](nodejs/node@37b0bea247)] - **meta**: remove never-used workflow trigger (Aviv Keller) [#​54983](nodejs/node#54983) - \[[`ae27e2dcd7`](nodejs/node@ae27e2dcd7)] - **meta**: add links to alternative issue trackers (Aviv Keller) [#​54401](nodejs/node#54401) - \[[`6e5d524b0f`](nodejs/node@6e5d524b0f)] - **module**: remove duplicated import (Aviv Keller) [#​54942](nodejs/node#54942) - \[[`3a682cca03`](nodejs/node@3a682cca03)] - **path**: remove repetitive conditional operator in `posix.resolve` (Wiyeong Seo) [#​54835](nodejs/node#54835) - \[[`ac1cb8dfdb`](nodejs/node@ac1cb8dfdb)] - **perf_hooks**: add missing type argument to getEntriesByName (Luke Taher) [#​54767](nodejs/node#54767) - \[[`85b3edc83b`](nodejs/node@85b3edc83b)] - **repl**: catch `\v` and `\r` in new-line detection (Aviv Keller) [#​54512](nodejs/node#54512) - \[[`df1f04999e`](nodejs/node@df1f04999e)] - **src**: decode native error messages as UTF-8 (Joyee Cheung) [#​55024](nodejs/node#55024) - \[[`86d718177a`](nodejs/node@86d718177a)] - **src**: update clang-tidy and focus on modernization (Yagiz Nizipli) [#​53757](nodejs/node#53757) - \[[`7d01b6a9c5`](nodejs/node@7d01b6a9c5)] - **src**: cleanup per env handles directly without a list (Chengzhong Wu) [#​54993](nodejs/node#54993) - \[[`a730cdb622`](nodejs/node@a730cdb622)] - **src**: remove duplicate code setting AF_INET (He Yang) [#​54939](nodejs/node#54939) - \[[`f10d9ad283`](nodejs/node@f10d9ad283)] - **stream**: treat null asyncIterator as undefined (Jason Zhang) [#​55119](nodejs/node#55119) - \[[`6027084245`](nodejs/node@6027084245)] - **test**: make `test-loaders-workers-spawned` less flaky (Antoine du Hamel) [#​55172](nodejs/node#55172) - \[[`66a87d19bd`](nodejs/node@66a87d19bd)] - **test**: update multiple assert tests to use node:test (James M Snell) [#​54585](nodejs/node#54585) - \[[`5105188c47`](nodejs/node@5105188c47)] - **test**: update wpt test for encoding (devstone) [#​55151](nodejs/node#55151) - \[[`81bcec0b82`](nodejs/node@81bcec0b82)] - **test**: deflake test/pummel/test-timers.js (jakecastelli) [#​55098](nodejs/node#55098) - \[[`82c402265a`](nodejs/node@82c402265a)] - **test**: deflake test-http-remove-header-stays-removed (Luigi Pinca) [#​55004](nodejs/node#55004) - \[[`78021701ed`](nodejs/node@78021701ed)] - **test**: fix test-tls-junk-closes-server (Michael Dawson) [#​55089](nodejs/node#55089) - \[[`c908b8a2d8`](nodejs/node@c908b8a2d8)] - **test**: fix more tests that fail when path contains a space (Antoine du Hamel) [#​55088](nodejs/node#55088) - \[[`afc1628e73`](nodejs/node@afc1628e73)] - **test**: fix `assertSnapshot` when path contains a quote (Antoine du Hamel) [#​55087](nodejs/node#55087) - \[[`7c88739b83`](nodejs/node@7c88739b83)] - **test**: fix some tests when path contains `%` (Antoine du Hamel) [#​55082](nodejs/node#55082) - \[[`eb4d468671`](nodejs/node@eb4d468671)] - ***Revert*** "**test**: mark test-fs-watch-non-recursive flaky on Windows" (Luigi Pinca) [#​55079](nodejs/node#55079) - \[[`bc7b5249d4`](nodejs/node@bc7b5249d4)] - **test**: make `test-runner-assert` more robust (Aviv Keller) [#​55036](nodejs/node#55036) - \[[`6c2a1386f7`](nodejs/node@6c2a1386f7)] - **test**: update tls test to support OpenSSL32 (Michael Dawson) [#​55030](nodejs/node#55030) - \[[`96406610fa`](nodejs/node@96406610fa)] - **test**: fix `test-vm-context-dont-contextify` when path contains a space (Antoine du Hamel) [#​55026](nodejs/node#55026) - \[[`39a80eed4f`](nodejs/node@39a80eed4f)] - **test**: adjust tls-set-ciphers for OpenSSL32 (Michael Dawson) [#​55016](nodejs/node#55016) - \[[`bd8fd4fceb`](nodejs/node@bd8fd4fceb)] - **test**: add `util.stripVTControlCharacters` test (RedYetiDev) [#​54865](nodejs/node#54865) - \[[`333b5a02d0`](nodejs/node@333b5a02d0)] - **test**: improve coverage for timer promises schedular (Aviv Keller) [#​53370](nodejs/node#53370) - \[[`f48992f433`](nodejs/node@f48992f433)] - **test**: remove unused common utilities (RedYetiDev) [#​54825](nodejs/node#54825) - \[[`93a098c56d`](nodejs/node@93a098c56d)] - **test**: deflake test-http-header-overflow (Luigi Pinca) [#​54978](nodejs/node#54978) - \[[`f849cf677d`](nodejs/node@f849cf677d)] - **test**: fix `soucre` to `source` (Aviv Keller) [#​55038](nodejs/node#55038) - \[[`1a007ea814`](nodejs/node@1a007ea814)] - **test**: add asserts to validate test assumptions (Michael Dawson) [#​54997](nodejs/node#54997) - \[[`6f53c096f8`](nodejs/node@6f53c096f8)] - **test**: move test-http-max-sockets to parallel (Luigi Pinca) [#​54977](nodejs/node#54977) - \[[`aba9dc775e`](nodejs/node@aba9dc775e)] - **test**: remove test-http-max-sockets flaky designation (Luigi Pinca) [#​54976](nodejs/node#54976) - \[[`ee5624bffe`](nodejs/node@ee5624bffe)] - **test**: adjust key sizes to support OpenSSL32 (Michael Dawson) [#​54972](nodejs/node#54972) - \[[`5c11a61140`](nodejs/node@5c11a61140)] - **test**: update test to support OpenSSL32 (Michael Dawson) [#​54968](nodejs/node#54968) - \[[`62f21470e4`](nodejs/node@62f21470e4)] - **test**: update DOM events web platform tests (Matthew Aitken) [#​54642](nodejs/node#54642) - \[[`426851705c`](nodejs/node@426851705c)] - **test_runner**: assert entry is a valid object (Edigleysson Silva (Edy)) [#​55231](nodejs/node#55231) - \[[`b1cad519d7`](nodejs/node@b1cad519d7)] - **test_runner**: use `test:` symbol on second print of parent test (RedYetiDev) [#​54956](nodejs/node#54956) - \[[`63c8f3d436`](nodejs/node@63c8f3d436)] - **test_runner**: replace ansi clear with ansi reset (Pietro Marchini) [#​55013](nodejs/node#55013) - \[[`0b3fb344f7`](nodejs/node@0b3fb344f7)] - **tools**: add `polyfilled` option to `prefer-primordials` rule (Antoine du Hamel) [#​55318](nodejs/node#55318) - \[[`8981309bd9`](nodejs/node@8981309bd9)] - **tools**: make `choco install` script more readable (Aviv Keller) [#​54002](nodejs/node#54002) - \[[`7310abeae1`](nodejs/node@7310abeae1)] - **tools**: bump Rollup from 4.18.1 to 4.22.4 for `lint-md` (dependabot\[bot]) [#​55093](nodejs/node#55093) - \[[`083311e8af`](nodejs/node@083311e8af)] - **tools**: remove redudant code from eslint require rule (Aviv Keller) [#​54892](nodejs/node#54892) - \[[`ae4b2aece1`](nodejs/node@ae4b2aece1)] - **tools**: update error message for ICU in license-builder (Aviv Keller) [#​54742](nodejs/node#54742) - \[[`3ebd31684d`](nodejs/node@3ebd31684d)] - **tools**: update github_reporter to 1.7.1 (Node.js GitHub Bot) [#​54951](nodejs/node#54951) - \[[`397be8a10e`](nodejs/node@397be8a10e)] - **tty**: fix links for terminal colors (Aviv Keller) [#​54596](nodejs/node#54596) - \[[`a3c2ef9e98`](nodejs/node@a3c2ef9e98)] - **util**: update ansi regex (Aviv Keller) [#​54865](nodejs/node#54865) - \[[`efdccc88a2`](nodejs/node@efdccc88a2)] - **watch**: preserve output when gracefully restarted (Théo LUDWIG) [#​54323](nodejs/node#54323) - \[[`226836c5ac`](nodejs/node@226836c5ac)] - **worker**: throw InvalidStateError in postMessage after close (devstone) [#​55206](nodejs/node#55206) - \[[`f39ff4d14b`](nodejs/node@f39ff4d14b)] - **worker**: handle `--input-type` more consistently (Antoine du Hamel) [#​54979](nodejs/node#54979) - \[[`30383ffb9a`](nodejs/node@30383ffb9a)] - **zlib**: throw brotli initialization error from c++ (Yagiz Nizipli) [#​54698](nodejs/node#54698) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
jkleinsc
added a commit
to electron/electron
that referenced
this pull request
Nov 21, 2024
jkleinsc
added a commit
to electron/electron
that referenced
this pull request
Nov 22, 2024
jkleinsc
added a commit
to electron/electron
that referenced
this pull request
Nov 22, 2024
jkleinsc
added a commit
to electron/electron
that referenced
this pull request
Nov 22, 2024
codebytere
pushed a commit
to electron/electron
that referenced
this pull request
Nov 22, 2024
* chore: bump node in DEPS to v20.18.1 * chore: update patches * lib: remove lib/internal/idna.js nodejs/node#55050 * buffer: fix out of range for toString nodejs/node#54553 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
codebytere
pushed a commit
to electron/electron
that referenced
this pull request
Nov 22, 2024
* chore: bump node in DEPS to v20.18.1 * chore: update patches * lib: remove lib/internal/idna.js nodejs/node#55050 * buffer: fix out of range for toString nodejs/node#54553 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
jkleinsc
added a commit
to electron/electron
that referenced
this pull request
Nov 22, 2024
* chore: bump node in DEPS to v20.18.1 * chore: update patches * lib: remove lib/internal/idna.js nodejs/node#55050 * buffer: fix out of range for toString nodejs/node#54553 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #52298