v20.18.1 proposal - #55879
Merged
marco-ippolito merged 121 commits intoNov 20, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
PR-URL: #55349 Refs: nodejs/Release#999 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
To save time, the `.github/workflows/doc.yml` workflow runs with a pre-built Node.js. The switch of `lts/*` to Node.js 22 has broken this workflow for Node.js 20 and 18 due to a mismatch in globals. Pin the version of Node.js back to 20. PR-URL: #55755 Fixes: #55754 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
marco-ippolito
marked this pull request as ready for review
November 16, 2024 13:34
This was referenced Nov 16, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I think #55170 (comment) is still going to be an issue. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Should I just drop the npm update? |
Sorry, something went wrong.
Refs: #54646 - Add instructions to update how process.versions is reported as I missed that in a recent addition. Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #54792 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
PR-URL: #54951 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #54845 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Specifically, `delete Array.prototype.lastIndexOf` immediately crashes the REPL, as does deletion of a few other Array prototype methods. PR-URL: #31457 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #54278 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #54401 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #53303 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #53746 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #54495 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #54386 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
`AF_INET` has been repeatedly set three times in the code. this should be redundant. removed the last two times. PR-URL: #54939 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #54835 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito
force-pushed
the
v20.18.1-proposal
branch
from
4216e6d to
7017811
Compare
November 18, 2024 09:28
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@nodejs/undici is failing in CITGM looks like OpenSSL Detailstest at test/http2.js:310:1
[v20] Request should fail if allowH2 is false and server advertises h1 only (12.626939ms)
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected
+ '40B8497C4F7F0000:error:0A000460:SSL routines:ssl3_read_bytes:tlsv1 alert no application protocol:../deps/openssl/openssl/ssl/record/rec_layer_s3.c:1605:SSL alert number 120\n'
- 'Client network socket disconnected before secure TLS connection was established'
at res.<computed> [as strictEqual] (/home/iojs/tmp/citgm_tmp/e04be0af-bf03-4881-b2fe-dcedb2cb4a60/undici/node_modules/@matteo.collina/tspl/tspl.js:52:35)
at TestContext.<anonymous> (/home/iojs/tmp/citgm_tmp/e04be0af-bf03-4881-b2fe-dcedb2cb4a60/undici/test/http2.js:348:9)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Test.run (node:internal/test_runner/test:797:9)
at async Test.processPendingSubtests (node:internal/test_runner/test:527:7) {
generatedMessage: true,
code: 'ERR_ASSERTION',
actual: '40B8497C4F7F0000:error:0A000460:SSL routines:ssl3_read_bytes:tlsv1 alert no application protocol:../deps/openssl/openssl/ssl/record/rec_layer_s3.c:1605:SSL alert number 120\n',
expected: 'Client network socket disconnected before secure TLS connection was established',
operator: 'strictEqual'
}
@mcollina Pino is also breaking Details FAIL test/transport/uses-pino-config.test.js
should be equivalent
test/transport/uses-pino-config.test.js
48 | const result = parseLogs(await readFile(destination))
49 |
> 50 | same(result, [{
| --^
51 | severityText: 'custom',
52 | body: 'foo',
53 | attributes: {
--- expected
+++ actual
@@ -7,29 +7,4 @@
"hostname": "test-digitalocean-debian11-x64-1",
},
},
- Object {
- "severityText": "error",
- "body": "bar",
- "attributes": Object {
- "pid": 852784,
- "hostname": "test-digitalocean-debian11-x64-1",
- },
- "error": Object {
- "type": "Error",
- "message": "bar",
- "stack": String(
- Error: bar
- at Test.<anonymous> (/home/iojs/tmp/citgm_tmp/8bb15848-eb8d-4355-
af21-30d5803c943f/pino/test/transport/uses-pino-config.test.js:44:17)
- at TapWrap.runInAsyncScope (node:async_hooks:206:9)
- at Test.cb (/home/iojs/tmp/citgm_tmp/8bb15848-eb8d-4355-af21-30d5
803c943f/pino/node_modules/libtap/lib/test.js:127:40)
- at /home/iojs/tmp/citgm_tmp/8bb15848-eb8d-4355-af21-30d5803c943f/
pino/node_modules/libtap/lib/test.js:369:21
- at Test.main (/home/iojs/tmp/citgm_tmp/8bb15848-eb8d-4355-af21-30
d5803c943f/pino/node_modules/libtap/lib/test.js:376:7)
- at TapWrap.runInAsyncScope (node:async_hooks:206:9)
- at Test.runMain (/home/iojs/tmp/citgm_tmp/8bb15848-eb8d-4355-af21
-30d5803c943f/pino/node_modules/libtap/lib/base.js:178:15)
- at /home/iojs/tmp/citgm_tmp/8bb15848-eb8d-4355-af21-30d5803c943f/
pino/node_modules/libtap/lib/test.js:490:13
- at TAP.writeSubComment (/home/iojs/tmp/citgm_tmp/8bb15848-eb8d-43
55-af21-30d5803c943f/pino/node_modules/libtap/lib/test.js:561:5)
- at Test.<anonymous> (/home/iojs/tmp/citgm_tmp/8bb15848-eb8d-4355-
af21-30d5803c943f/pino/node_modules/libtap/lib/test.js:489:14)
- ),
- },
- },
]
@nodejs/releasers wdyt? CITGM says +81 but I cannot access the previous run |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
We have this issue in the past and decided to ignore it; the thing is that OpenSSL changes the handling of the non-supported protocol. If we can ensure that will be the message from now on or add a wrapper around, we are good to go. Otherwise, ignoring the test for now should be ok. |
Sorry, something went wrong.
aduh95
approved these changes
Nov 20, 2024
aduh95
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
+1 to proceed unless maintainers of those projects ask us not to
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
As soon as release CI is ready I will proceed. |
Sorry, something went wrong.
richardlau
approved these changes
Nov 20, 2024
mertcanaltin
approved these changes
Nov 20, 2024
marco-ippolito
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Nov 20, 2024
marco-ippolito
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Nov 20, 2024
marco-ippolito
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Nov 20, 2024
github-merge-queue Bot
pushed a commit
to nodejs/nodejs.org
that referenced
this pull request
Nov 20, 2024
26 tasks
bmuenzenmeyer
pushed a commit
to nodejs/nodejs.org
that referenced
this pull request
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2024-11-20, Version 20.18.1 'Iron' (LTS), @marco-ippolito
Notable Changes
Commits