readline: add stricter validation for functions called after closed by dario-piotrowicz · Pull Request #57680 · nodejs/node · GitHub

Fixes #57678

This PR makes it so that calling pause(), resume() or write() on a closed readline interface results in ERR_USE_AFTER_CLOSE errors being thrown (following the same behavior as question())

Note

I'm slightly concerned regarding the tests I needed to update, as those might indicate that the stricted
readline checks might have some potential unwanted implications, if the changes here were to land it might be
safer to add them as a semver major I think 🤔

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (86f86a2) to head (cd44076).
Report is 74 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57680      +/-   ##
==========================================
+ Coverage   90.22%   90.24%   +0.01%     
==========================================
  Files         630      630              
  Lines      185481   185670     +189     
  Branches    36364    36401      +37     
==========================================
+ Hits       167357   167558     +201     
+ Misses      11004    10990      -14     
- Partials     7120     7122       +2

Files with missing lines	Coverage Δ
lib/internal/readline/interface.js	96.78% <100.00%> (-0.17%)	⬇️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Maybe we can have the rli.write call here too? Seems like the behavior is the same for the three calls when the interface is closed.

Are you asking if we could move rli.write from line 1212 to here? and fully remove that test block?

Sure, we can 🙂, although I personally am a fan of small focused tests, so that if one thing breaks ideally only a single test fails, so my preference would be to keep them as they are, I am however happy to combine the two, especially if some other folks share your same preference 🙂

(PS: you could argue that I am already combining together pause and resume here, that's be a valid argument, but those feel to me like they go together that's why I put them in the same test 😅)

Yeah, this is not a block. That's just all the functions end up with the same behavior when the interface is closed, hence the test is testing the same behavior and it would be good to have them together.

I had another look and I remembered that there are already two separate testing blocks for question and question promisified, so I'm indeed (loosely) following this pattern with my additions, so if I were to combine things I feel like at that point it would make sense to combine all these blocks right?
but at that point we have a single big test/block which tests all the various functions being called after close 🤔 feels a untidy to me 🤔

I am not extremely against the idea but yeah it wouldn't be my personal preference 🤔

As I said, not a blocker at all.

LGTM. Unfortunately I think the additional throw here will make this semver-major

Unfortunately I think the additional throw here will make this semver-major

yeah I understand and agree 🙂, I also did think the same and mentioned this in my PR description 👍

lgtm

this test - test-repl-import-referrer seems constantly failing between CI runs, would you mind taking a look? I will rerun the CI after your investigation 👍 cheers

Hi @jakecastelli 👋

I just had a look, the setTimeout is needed there because:

the REPL, which is implements a readline interface,
under the hood calls finishExecution at the end of the command evaluation
this in turn calls finish
which in turn calls displayPrompt
which calls the readline prompt
which tries to call resume on the interface

This, without the setTimeout causes the stricter readline validation to error, since child.stdin.end(); causes the readline interface to be closed

My guess now is that in CI the REPL can take more than 100ms to call finishExecution causing the error (note: the command being executed is await import('./message.mjs') so I do imagine that the time for the dynamic import to resolve can vary depending on the underlying platform 🤔), so I increased the timeout time to 300 hoping that that will solve the issue

Alternatively I could update the code in test/parallel/test-repl-import-referrer.js not to use a setTimeout at all but, depending on the output decide when to end the child.stdin stream, I started looking into that but I think that that solution would likely be more brittle / less clean than just having a setTimeout call 🤔

WDYT? could you try re-running the CI and see if the new timeout value helps? 🙏

Hi @dario-piotrowicz 👋 thanks for the detailed explanation, I didn't remember I've mentioned setTimeout is not needed, maybe I confused you with this comment? #57680 (comment), if so, my intention was that setTimeout used to strictly require a duration as second argument in our linting rules, I think this may have changed at sometime.

Thanks a lot for re-running the CI @jasnell 🙏

Unfortunately my changes there were not enough to fix the CI failure, however now I am quite confident that cd44076 properly solves the issue, could you maybe re-run the CI tests? 🙏

ok never mind James, thanks a lot @anonrig 🫶

Yes, my last commit seems to have solved the CI issue! 🥳

As far as I can tell everything should hopefully be good now, I assume (/hope 😅) that the current CI failures are unrelated flakes?

CI: https://ci.nodejs.org/job/node-test-pull-request/66246/

CI: https://ci.nodejs.org/job/node-test-pull-request/66368/ 🟡

CITGM queued here https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3583/

PR-URL: #57680 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Landed in 8e7f32f

#57680 (comment) shows a failure for test-repl-import-referrer, which is modified in this PR. The test is now flaky on main, see #58009

#57680 (comment) shows a failure for test-repl-import-referrer, which is modified in this PR. The test is now flaky on main, see #58009

Thanks @aduh95 🙏

I'm really sorry if my changes here have introduced the flakiness, but is it possible that something else did introduce the flakiness by any chance? this seems pretty surprising to me since I don't think I saw anytest-repl-import-referrer failures in this PR after 78e0c38

Actually, sorry I'm not really super used to reading Jenkins logs could you clarify where you see the failure in #57680 (comment)? 🙏

PR-URL: #57680 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Semver-Major Commits: assert,util: * (SEMVER-MAJOR) Revert "assert,util: revert recursive breaking change (Ruben Bridgewater) #57622 buffer: * (SEMVER-MAJOR) move SlowBuffer to EOL (James M Snell) #58008 * (SEMVER-MAJOR) make `buflen` in integer range (zhenweijin) #51821 build: * (SEMVER-MAJOR) downgrade armv7 support to experimental (Michaël Zasso) #58071 * (SEMVER-MAJOR) bump supported macOS version to 13.5 (Michaël Zasso) #57115 * (SEMVER-MAJOR) increase minimum Xcode version to 16.1 (Michaël Zasso) #56824 * (SEMVER-MAJOR) link V8 with atomic library (Michaël Zasso) #55014 * (SEMVER-MAJOR) remove support for ppc 32-bit (Michaël Zasso) #55014 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #55014 child_process: * (SEMVER-MAJOR) deprecate passing `args` to `spawn` and `execFile` (Daniel Venable) #57199 deps: * (SEMVER-MAJOR) V8: cherry-pick f915fa4c9f41 (Olivier Flückiger) #55014 * (SEMVER-MAJOR) V8: cherry-pick 0d5d6e71bbb0 (Yagiz Nizipli) #55014 * (SEMVER-MAJOR) V8: cherry-pick 0c11feeeca4a (Michaël Zasso) #55014 * (SEMVER-MAJOR) define V8_PRESERVE_MOST as no-op on Windows (Stefan Stojanovic) #55014 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #55014 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #55014 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #55014 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #55014 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #55014 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #55014 * (SEMVER-MAJOR) update V8 to 13.0.245.25 (Michaël Zasso) #55014 * (SEMVER-MAJOR) upgrade npm to 11.0.0 (npm team) #56274 * (SEMVER-MAJOR) update undici to 7.0.0 (Node.js GitHub Bot) #56070 fs: * (SEMVER-MAJOR) remove ability to call truncate with fd (Yagiz Nizipli) #57567 * (SEMVER-MAJOR) deprecate passing invalid types in `fs.existsSync` (Carlos Espa) #55753 * (SEMVER-MAJOR) runtime deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #49686 * (SEMVER-MAJOR) remove `dirent.path` (Antoine du Hamel) #55548 http: * (SEMVER-MAJOR) remove outgoingmessage _headers and _headersList (Yagiz Nizipli) #57551 http2: * (SEMVER-MAJOR) session tracking and graceful server close (Kushagra Pandey) #57586 lib: * (SEMVER-MAJOR) remove obsolete Cipher export (James M Snell) #57266 * (SEMVER-MAJOR) unexpose six process bindings (Michaël Zasso) #57149 * (SEMVER-MAJOR) make ALS default to AsyncContextFrame (Stephen Belanger) #55552 * (SEMVER-MAJOR) runtime deprecate SlowBuffer (Rafael Gonzaga) #55175 net: * (SEMVER-MAJOR) make _setSimultaneousAccepts() end-of-life deprecated (Yagiz Nizipli) #57550 readline: * (SEMVER-MAJOR) add stricter validation for functions called after closed (Dario Piotrowicz) #57680 * (SEMVER-MAJOR) fix unicode line separators being ignored (Dario Piotrowicz) #57591 repl: * (SEMVER-MAJOR) runtime deprecate instantiating without new (Aviv Keller) #54869 src: * (SEMVER-MAJOR) update GetForegroundTaskRunner override (Etienne Pierre-doray) #55014 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 134 (Michaël Zasso) #55014 * (SEMVER-MAJOR) drop --experimental-permission in favour of --permission (Rafael Gonzaga) #56240 * (SEMVER-MAJOR) add async context frame to AsyncResource (Gerhard Stöbich) #56082 * (SEMVER-MAJOR) nuke deprecated and un-used enum members in `OptionEnvvarSettings` (Juan José) #53079 stream: * (SEMVER-MAJOR) catch and forward error from dest.write (jakecastelli) #55270 test: * (SEMVER-MAJOR) disable fast API call count checks (Michaël Zasso) #55014 test_runner: * (SEMVER-MAJOR) remove promises returned by t.test() (Colin Ihrig) #56664 * (SEMVER-MAJOR) remove promises returned by test() (Colin Ihrig) #56664 * (SEMVER-MAJOR) automatically wait for subtests to finish (Colin Ihrig) #56664 timers: * (SEMVER-MAJOR) check for immediate instance in clearImmediate (Gürgün Dayıoğlu) #57069 * (SEMVER-MAJOR) set several methods EOL (Yagiz Nizipli) #56966 tls: * (SEMVER-MAJOR) remove deprecated tls.createSecurePair (Jonas) #57361 * (SEMVER-MAJOR) make server.prototype.setOptions end-of-life (Yagiz Nizipli) #57339 tools: * (SEMVER-MAJOR) update V8 gypfiles for 13.0 (Michaël Zasso) #55014 url: * (SEMVER-MAJOR) expose urlpattern as global (Jonas) #56950 * (SEMVER-MAJOR) runtime deprecate url.parse (Yagiz Nizipli) #55017 zlib: * (SEMVER-MAJOR) deprecate classes usage without `new` (Yagiz Nizipli) #55718 PR-URL: #57609 Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

PR-URL: #57680 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Semver-Major Commits: assert,util: * (SEMVER-MAJOR) Revert "assert,util: revert recursive breaking change (Ruben Bridgewater) #57622 buffer: * (SEMVER-MAJOR) move SlowBuffer to EOL (James M Snell) #58008 * (SEMVER-MAJOR) make `buflen` in integer range (zhenweijin) #51821 build: * (SEMVER-MAJOR) update list of installed cppgc headers (Michaël Zasso) #58070 * (SEMVER-MAJOR) fix V8 TLS config for shared lib builds (Michaël Zasso) #58070 * (SEMVER-MAJOR) pass `-fPIC` to linker as well for shared builds (Michaël Zasso) #58070 * (SEMVER-MAJOR) add `/bigobj` to compile V8 on Windows (Michaël Zasso) #58070 * (SEMVER-MAJOR) enable shared RO heap with ptr compression (Michaël Zasso) #58070 * (SEMVER-MAJOR) remove support for s390 32-bit (Richard Lau) #58070 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #58070 * (SEMVER-MAJOR) downgrade armv7 support to experimental (Michaël Zasso) #58071 * (SEMVER-MAJOR) bump supported macOS version to 13.5 (Michaël Zasso) #57115 * (SEMVER-MAJOR) increase minimum Xcode version to 16.1 (Michaël Zasso) #56824 * (SEMVER-MAJOR) link V8 with atomic library (Michaël Zasso) #55014 * (SEMVER-MAJOR) remove support for ppc 32-bit (Michaël Zasso) #55014 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #55014 build,src,tools: * (SEMVER-MAJOR) adapt build config for V8 13.3 (Michaël Zasso) #58070 child_process: * (SEMVER-MAJOR) deprecate passing `args` to `spawn` and `execFile` (Daniel Venable) #57199 deps: * (SEMVER-MAJOR) remove deps/simdutf (Michaël Zasso) #58070 * (SEMVER-MAJOR) V8: backport 954187bb1b87 (Joyee Cheung) #58070 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #58070 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #58070 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #58070 * (SEMVER-MAJOR) use std::map in MSVC STL for EphemeronRememberedSet (Joyee Cheung) #58070 * (SEMVER-MAJOR) patch V8 for illumos (Dan McDonald) #58070 * (SEMVER-MAJOR) remove problematic comment from v8-internal (Michaël Zasso) #58070 * (SEMVER-MAJOR) define V8_PRESERVE_MOST as no-op on Windows (Stefan Stojanovic) #58070 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #58070 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #58070 * (SEMVER-MAJOR) update V8 to 13.6.233.8 (Michaël Zasso) #58070 * (SEMVER-MAJOR) V8: cherry-pick f915fa4c9f41 (Olivier Flückiger) #55014 * (SEMVER-MAJOR) V8: cherry-pick 0d5d6e71bbb0 (Yagiz Nizipli) #55014 * (SEMVER-MAJOR) V8: cherry-pick 0c11feeeca4a (Michaël Zasso) #55014 * (SEMVER-MAJOR) define V8_PRESERVE_MOST as no-op on Windows (Stefan Stojanovic) #55014 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #55014 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #55014 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #55014 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #55014 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #55014 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #55014 * (SEMVER-MAJOR) update V8 to 13.0.245.25 (Michaël Zasso) #55014 * (SEMVER-MAJOR) upgrade npm to 11.0.0 (npm team) #56274 * (SEMVER-MAJOR) update undici to 7.0.0 (Node.js GitHub Bot) #56070 fs: * (SEMVER-MAJOR) remove ability to call truncate with fd (Yagiz Nizipli) #57567 * (SEMVER-MAJOR) deprecate passing invalid types in `fs.existsSync` (Carlos Espa) #55753 * (SEMVER-MAJOR) runtime deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #49686 * (SEMVER-MAJOR) remove `dirent.path` (Antoine du Hamel) #55548 http: * (SEMVER-MAJOR) remove outgoingmessage _headers and _headersList (Yagiz Nizipli) #57551 http2: * (SEMVER-MAJOR) session tracking and graceful server close (Kushagra Pandey) #57586 lib: * (SEMVER-MAJOR) remove obsolete Cipher export (James M Snell) #57266 * (SEMVER-MAJOR) unexpose six process bindings (Michaël Zasso) #57149 * (SEMVER-MAJOR) make ALS default to AsyncContextFrame (Stephen Belanger) #55552 * (SEMVER-MAJOR) runtime deprecate SlowBuffer (Rafael Gonzaga) #55175 net: * (SEMVER-MAJOR) make _setSimultaneousAccepts() end-of-life deprecated (Yagiz Nizipli) #57550 readline: * (SEMVER-MAJOR) add stricter validation for functions called after closed (Dario Piotrowicz) #57680 * (SEMVER-MAJOR) fix unicode line separators being ignored (Dario Piotrowicz) #57591 repl: * (SEMVER-MAJOR) runtime deprecate instantiating without new (Aviv Keller) #54869 src: * (SEMVER-MAJOR) use non-deprecated WriteUtf8V2() method (Yagiz Nizipli) #58070 * (SEMVER-MAJOR) use non-deprecated Utf8LengthV2() method (Yagiz Nizipli) #58070 * (SEMVER-MAJOR) use V8-owned CppHeap (Joyee Cheung) #58070 * (SEMVER-MAJOR) use `v8::ExternalMemoryAccounter` (Michaël Zasso) #58070 * (SEMVER-MAJOR) replace uses of FastApiTypedArray (Michaël Zasso) #58070 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 137 (Michaël Zasso) #58070 * (SEMVER-MAJOR) update GetForegroundTaskRunner override (Etienne Pierre-doray) #55014 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 134 (Michaël Zasso) #55014 * (SEMVER-MAJOR) drop --experimental-permission in favour of --permission (Rafael Gonzaga) #56240 * (SEMVER-MAJOR) add async context frame to AsyncResource (Gerhard Stöbich) #56082 * (SEMVER-MAJOR) nuke deprecated and un-used enum members in `OptionEnvvarSettings` (Juan José) #53079 src,test: * (SEMVER-MAJOR) unregister the isolate after disposal and before freeing (Joyee Cheung) #58070 * (SEMVER-MAJOR) add V8 API to test the hash seed (Michaël Zasso) #58070 stream: * (SEMVER-MAJOR) catch and forward error from dest.write (jakecastelli) #55270 test: * (SEMVER-MAJOR) fix test-fs-write for V8 13.6 (Michaël Zasso) #58070 * (SEMVER-MAJOR) handle explicit resource management globals (Michaël Zasso) #58070 * (SEMVER-MAJOR) adapt assert tests to stack trace changes (Michaël Zasso) #58070 * (SEMVER-MAJOR) update test-linux-perf-logger (Michaël Zasso) #58070 * (SEMVER-MAJOR) Revert "test: disable fast API call count checks (Michaël Zasso) #58070 * (SEMVER-MAJOR) disable fast API call count checks (Michaël Zasso) #55014 test_runner: * (SEMVER-MAJOR) remove promises returned by t.test() (Colin Ihrig) #56664 * (SEMVER-MAJOR) remove promises returned by test() (Colin Ihrig) #56664 * (SEMVER-MAJOR) automatically wait for subtests to finish (Colin Ihrig) #56664 timers: * (SEMVER-MAJOR) check for immediate instance in clearImmediate (Gürgün Dayıoğlu) #57069 * (SEMVER-MAJOR) set several methods EOL (Yagiz Nizipli) #56966 tls: * (SEMVER-MAJOR) remove deprecated tls.createSecurePair (Jonas) #57361 * (SEMVER-MAJOR) make server.prototype.setOptions end-of-life (Yagiz Nizipli) #57339 tools: * (SEMVER-MAJOR) update V8 gypfiles for 13.6 (Michaël Zasso) #58070 * (SEMVER-MAJOR) update V8 gypfiles for 13.5 (Michaël Zasso) #58070 * (SEMVER-MAJOR) update license-builder and LICENSE for V8 deps (Michaël Zasso) #58070 * (SEMVER-MAJOR) update V8 gypfiles for 13.4 (Michaël Zasso) #58070 * (SEMVER-MAJOR) update V8 gypfiles for 13.2 (Michaël Zasso) #58070 * (SEMVER-MAJOR) update V8 gypfiles for 13.1 (Michaël Zasso) #58070 * (SEMVER-MAJOR) update V8 gypfiles for 13.0 (Michaël Zasso) #55014 url: * (SEMVER-MAJOR) expose urlpattern as global (Jonas) #56950 * (SEMVER-MAJOR) runtime deprecate url.parse (Yagiz Nizipli) #55017 zlib: * (SEMVER-MAJOR) deprecate classes usage without `new` (Yagiz Nizipli) #55718 PR-URL: #57609 Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

Semver-Major Commits: assert,util: * (SEMVER-MAJOR) Revert "assert,util: revert recursive breaking change (Ruben Bridgewater) #57622 buffer: * (SEMVER-MAJOR) move SlowBuffer to EOL (James M Snell) #58008 * (SEMVER-MAJOR) make `buflen` in integer range (zhenweijin) #51821 build: * (SEMVER-MAJOR) update list of installed cppgc headers (Michaël Zasso) #58070 * (SEMVER-MAJOR) fix V8 TLS config for shared lib builds (Michaël Zasso) #58070 * (SEMVER-MAJOR) pass `-fPIC` to linker as well for shared builds (Michaël Zasso) #58070 * (SEMVER-MAJOR) add `/bigobj` to compile V8 on Windows (Michaël Zasso) #58070 * (SEMVER-MAJOR) enable shared RO heap with ptr compression (Michaël Zasso) #58070 * (SEMVER-MAJOR) remove support for s390 32-bit (Richard Lau) #58070 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #58070 * (SEMVER-MAJOR) downgrade armv7 support to experimental (Michaël Zasso) #58071 * (SEMVER-MAJOR) bump supported macOS version to 13.5 (Michaël Zasso) #57115 * (SEMVER-MAJOR) increase minimum Xcode version to 16.1 (Michaël Zasso) #56824 * (SEMVER-MAJOR) link V8 with atomic library (Michaël Zasso) #55014 * (SEMVER-MAJOR) remove support for ppc 32-bit (Michaël Zasso) #55014 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #55014 build,src,tools: * (SEMVER-MAJOR) adapt build config for V8 13.3 (Michaël Zasso) #58070 child_process: * (SEMVER-MAJOR) deprecate passing `args` to `spawn` and `execFile` (Daniel Venable) #57199 deps: * (SEMVER-MAJOR) remove deps/simdutf (Michaël Zasso) #58070 * (SEMVER-MAJOR) V8: backport 954187bb1b87 (Joyee Cheung) #58070 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #58070 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #58070 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #58070 * (SEMVER-MAJOR) use std::map in MSVC STL for EphemeronRememberedSet (Joyee Cheung) #58070 * (SEMVER-MAJOR) patch V8 for illumos (Dan McDonald) #58070 * (SEMVER-MAJOR) remove problematic comment from v8-internal (Michaël Zasso) #58070 * (SEMVER-MAJOR) define V8_PRESERVE_MOST as no-op on Windows (Stefan Stojanovic) #58070 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #58070 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #58070 * (SEMVER-MAJOR) update V8 to 13.6.233.8 (Michaël Zasso) #58070 * (SEMVER-MAJOR) V8: cherry-pick f915fa4c9f41 (Olivier Flückiger) #55014 * (SEMVER-MAJOR) V8: cherry-pick 0d5d6e71bbb0 (Yagiz Nizipli) #55014 * (SEMVER-MAJOR) V8: cherry-pick 0c11feeeca4a (Michaël Zasso) #55014 * (SEMVER-MAJOR) define V8_PRESERVE_MOST as no-op on Windows (Stefan Stojanovic) #55014 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #55014 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #55014 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #55014 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #55014 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #55014 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #55014 * (SEMVER-MAJOR) update V8 to 13.0.245.25 (Michaël Zasso) #55014 * (SEMVER-MAJOR) upgrade npm to 11.0.0 (npm team) #56274 * (SEMVER-MAJOR) update undici to 7.0.0 (Node.js GitHub Bot) #56070 fs: * (SEMVER-MAJOR) remove ability to call truncate with fd (Yagiz Nizipli) #57567 * (SEMVER-MAJOR) deprecate passing invalid types in `fs.existsSync` (Carlos Espa) #55753 * (SEMVER-MAJOR) runtime deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #49686 * (SEMVER-MAJOR) remove `dirent.path` (Antoine du Hamel) #55548 http: * (SEMVER-MAJOR) remove outgoingmessage _headers and _headersList (Yagiz Nizipli) #57551 http2: * (SEMVER-MAJOR) session tracking and graceful server close (Kushagra Pandey) #57586 lib: * (SEMVER-MAJOR) remove obsolete Cipher export (James M Snell) #57266 * (SEMVER-MAJOR) unexpose six process bindings (Michaël Zasso) #57149 * (SEMVER-MAJOR) make ALS default to AsyncContextFrame (Stephen Belanger) #55552 * (SEMVER-MAJOR) runtime deprecate SlowBuffer (Rafael Gonzaga) #55175 net: * (SEMVER-MAJOR) make _setSimultaneousAccepts() end-of-life deprecated (Yagiz Nizipli) #57550 readline: * (SEMVER-MAJOR) add stricter validation for functions called after closed (Dario Piotrowicz) #57680 * (SEMVER-MAJOR) fix unicode line separators being ignored (Dario Piotrowicz) #57591 repl: * (SEMVER-MAJOR) runtime deprecate instantiating without new (Aviv Keller) #54869 src: * (SEMVER-MAJOR) enable `Float16Array` on global object (Michaël Zasso) #58154 * (SEMVER-MAJOR) enable explicit resource management (Michaël Zasso) #58154 * (SEMVER-MAJOR) use non-deprecated WriteUtf8V2() method (Yagiz Nizipli) #58070 * (SEMVER-MAJOR) use non-deprecated Utf8LengthV2() method (Yagiz Nizipli) #58070 * (SEMVER-MAJOR) use V8-owned CppHeap (Joyee Cheung) #58070 * (SEMVER-MAJOR) use `v8::ExternalMemoryAccounter` (Michaël Zasso) #58070 * (SEMVER-MAJOR) replace uses of FastApiTypedArray (Michaël Zasso) #58070 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 137 (Michaël Zasso) #58070 * (SEMVER-MAJOR) update GetForegroundTaskRunner override (Etienne Pierre-doray) #55014 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 134 (Michaël Zasso) #55014 * (SEMVER-MAJOR) drop --experimental-permission in favour of --permission (Rafael Gonzaga) #56240 * (SEMVER-MAJOR) add async context frame to AsyncResource (Gerhard Stöbich) #56082 * (SEMVER-MAJOR) nuke deprecated and un-used enum members in `OptionEnvvarSettings` (Juan José) #53079 src,test: * (SEMVER-MAJOR) unregister the isolate after disposal and before freeing (Joyee Cheung) #58070 * (SEMVER-MAJOR) add V8 API to test the hash seed (Michaël Zasso) #58070 stream: * (SEMVER-MAJOR) catch and forward error from dest.write (jakecastelli) #55270 test: * (SEMVER-MAJOR) fix test-fs-write for V8 13.6 (Michaël Zasso) #58070 * (SEMVER-MAJOR) handle explicit resource management globals (Michaël Zasso) #58070 * (SEMVER-MAJOR) adapt assert tests to stack trace changes (Michaël Zasso) #58070 * (SEMVER-MAJOR) update test-linux-perf-logger (Michaël Zasso) #58070 * (SEMVER-MAJOR) Revert "test: disable fast API call count checks (Michaël Zasso) #58070 * (SEMVER-MAJOR) disable fast API call count checks (Michaël Zasso) #55014 test_runner: * (SEMVER-MAJOR) remove promises returned by t.test() (Colin Ihrig) #56664 * (SEMVER-MAJOR) remove promises returned by test() (Colin Ihrig) #56664 * (SEMVER-MAJOR) automatically wait for subtests to finish (Colin Ihrig) #56664 timers: * (SEMVER-MAJOR) check for immediate instance in clearImmediate (Gürgün Dayıoğlu) #57069 * (SEMVER-MAJOR) set several methods EOL (Yagiz Nizipli) #56966 tls: * (SEMVER-MAJOR) remove deprecated tls.createSecurePair (Jonas) #57361 * (SEMVER-MAJOR) make server.prototype.setOptions end-of-life (Yagiz Nizipli) #57339 tools: * (SEMVER-MAJOR) update V8 gypfiles for 13.6 (Michaël Zasso) #58070 * (SEMVER-MAJOR) update V8 gypfiles for 13.5 (Michaël Zasso) #58070 * (SEMVER-MAJOR) update license-builder and LICENSE for V8 deps (Michaël Zasso) #58070 * (SEMVER-MAJOR) update V8 gypfiles for 13.4 (Michaël Zasso) #58070 * (SEMVER-MAJOR) update V8 gypfiles for 13.2 (Michaël Zasso) #58070 * (SEMVER-MAJOR) update V8 gypfiles for 13.1 (Michaël Zasso) #58070 * (SEMVER-MAJOR) update V8 gypfiles for 13.0 (Michaël Zasso) #55014 url: * (SEMVER-MAJOR) expose urlpattern as global (Jonas) #56950 * (SEMVER-MAJOR) runtime deprecate url.parse (Yagiz Nizipli) #55017 zlib: * (SEMVER-MAJOR) deprecate classes usage without `new` (Yagiz Nizipli) #55718 PR-URL: #57609 Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. labels Mar 29, 2025

dario-piotrowicz force-pushed the dario/readline-after-close-checks branch from c575cee to 7f5b064 Compare March 29, 2025 23:12

dario-piotrowicz changed the title readline: add stricter validation called after closed readline: add stricter validation for functions called after closed Mar 30, 2025

dario-piotrowicz force-pushed the dario/readline-after-close-checks branch from 7f5b064 to 360e127 Compare March 30, 2025 09:24

geeksilva97 reviewed Mar 31, 2025

View reviewed changes

jasnell approved these changes Apr 1, 2025

View reviewed changes

jasnell added semver-major PRs that contain breaking changes and should be released in the next major version. needs-citgm PRs that need a CITGM CI run. labels Apr 1, 2025

jasnell requested review from anonrig and mcollina April 1, 2025 10:34

geeksilva97 approved these changes Apr 1, 2025

View reviewed changes

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 3, 2025

This comment was marked as outdated.

Sign in to view

BridgeAR approved these changes Apr 3, 2025

View reviewed changes

jakecastelli reviewed Apr 4, 2025

View reviewed changes

Comment thread test/parallel/test-readline-promises-tab-complete.js Outdated

Comment thread test/parallel/test-repl-import-referrer.js Outdated

mcollina approved these changes Apr 4, 2025

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2025

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2025

This comment was marked as outdated.

Sign in to view

anonrig approved these changes Apr 4, 2025

View reviewed changes

dario-piotrowicz requested a review from jakecastelli April 5, 2025 16:12

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2025

anonrig approved these changes Apr 13, 2025

View reviewed changes

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2025

This comment was marked as outdated.

Sign in to view

jasnell closed this Apr 23, 2025

dario-piotrowicz deleted the dario/readline-after-close-checks branch April 23, 2025 07:26

richardlau mentioned this pull request Apr 24, 2025

parallel/test-repl-import-referrer is flaky #58009

Closed

This was referenced Apr 25, 2025

test: fix test-repl-import-referrer flakiness #58014

Closed

Revert "readline: add stricter validation for functions called after close #58024

Merged

RafaelGSS mentioned this pull request May 1, 2025

2025-05-06, Version 24.0.0 (Current) #57609

Merged

dario-piotrowicz mentioned this pull request May 11, 2025

readline: add stricter validation for functions called after closed (second attempt) #58283

Merged

readline: add stricter validation for functions called after closed by dario-piotrowicz · Pull Request #57680 · nodejs/node · GitHub

Uh oh!

Uh oh!

readline: add stricter validation for functions called after closed - #57680

readline: add stricter validation for functions called after closed#57680dario-piotrowicz wants to merge 12 commits intonodejs:mainnodejs/node:mainfrom dario-piotrowicz:dario/readline-after-close-checksdario-piotrowicz/node:dario/readline-after-close-checksCopy head branch name to clipboard

Conversation

dario-piotrowicz commented Mar 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Mar 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

geeksilva97 Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

geeksilva97 Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

geeksilva97 Apr 3, 2025

Choose a reason for hiding this comment

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz commented Apr 1, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

jakecastelli commented Apr 5, 2025

Uh oh!

dario-piotrowicz commented Apr 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakecastelli commented Apr 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dario-piotrowicz commented Apr 13, 2025

Uh oh!

This comment was marked as outdated.

dario-piotrowicz commented Apr 13, 2025

Uh oh!

dario-piotrowicz commented Apr 13, 2025

Uh oh!

nodejs-github-bot commented Apr 14, 2025

Uh oh!

nodejs-github-bot commented Apr 19, 2025 • edited by jakecastelli Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakecastelli commented Apr 21, 2025

Uh oh!

jasnell commented Apr 23, 2025

Uh oh!

aduh95 commented Apr 24, 2025

Uh oh!

dario-piotrowicz commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

readline: add stricter validation for functions called after closed#57680
dario-piotrowicz wants to merge 12 commits into
nodejs:mainfrom
dario-piotrowicz:dario/readline-after-close-checks

dario-piotrowicz commented Mar 29, 2025 •
edited
Loading

codecov Bot commented Mar 30, 2025 •
edited
Loading

dario-piotrowicz Mar 31, 2025 •
edited
Loading

dario-piotrowicz commented Apr 5, 2025 •
edited
Loading

jakecastelli commented Apr 6, 2025 •
edited
Loading

nodejs-github-bot commented Apr 19, 2025 •
edited by jakecastelli
Loading

dario-piotrowicz commented Apr 24, 2025 •
edited
Loading