| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
…closed" This reverts commit 8e7f32f.
|
Should we not try to address the shown issue instead? [Edit] I see that the validations should be reintroduced later again. I guess that's also fine if it takes too long to fix the issues. |
Sorry, something went wrong.
Sorry, something went wrong.
Yes, the added benefit is the immediate "fix" of the flaky test (#58009). |
Sorry, something went wrong.
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #58024 +/- ##
=======================================
Coverage 90.27% 90.27%
=======================================
Files 630 630
Lines 186158 186149 -9
Branches 36475 36477 +2
=======================================
+ Hits 168047 168054 +7
+ Misses 10980 10978 -2
+ Partials 7131 7117 -14
... and 26 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
Sorry, something went wrong.
I'm very happy to look into the underlying issue (and I will) however unfortunately I'm visiting family for easter (I'm back home early next week) so I currently don't have as much time as I'd otherwise have to look into this promptly 🥲 So instead of keeping the bug around and cause issues maybe it'd be safer/quicker to just revert the change
Not really, the issue here is that this is breaking valid usage of the REPL 😓 (see #58014 (comment))
Again I feel like this might be the most convenient solution but I am happy to proceed in any way people feel it's more appropriate here 🙂 (and again I'm very sorry for the inconvenience 🙇😢) |
Sorry, something went wrong.
|
It seems this change is required or the v24 proposal fails @richardlau |
Sorry, something went wrong.
@RafaelGSS If this is about the dont-land-on-v24.x label, then I added that when #57680 was not going to be included in 24.0.0 (as it was semver major and past the cut-off date for 24.0.0). |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This reverts commit 8e7f32f (PR #57680) since the PR is introducing an unexpected issue in the REPL, see: #58014 (comment)
Fixes #58009
Thanks a lot @lpinca for spotting the problem 🙏
Once again I'm super sorry for the inconvenience here, I'm really surprised that such an issue didn't cause any test failures 😓
I'm try to reintroduce the changes in #57680 later making sure not to break the REPL 🙇