FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Typo in synchronous randomBytes example by WebReflection · Pull Request #5781 · nodejs/node · GitHub

/ node Public

Typo in synchronous randomBytes example - #5781

Closed
WebReflection wants to merge 1 commit into
nodejs:masterfrom
WebReflection:patch-1
ConversationCommits (1)ChecksFiles changed
Closed

Typo in synchronous randomBytes example#5781
WebReflection wants to merge 1 commit into
nodejs:masterfrom
WebReflection:patch-1

Conversation

WebReflection commented Mar 18, 2016

Copy link
Copy Markdown
Contributor

The string template was closed after ${buf.length} causing a syntax error within the example.

Typo in synchronous randomBytes example
0674ed7 
The string template was closed after `${buf.length}` causing a syntax error within the example.
r-52 added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Mar 18, 2016

targos commented Mar 18, 2016

Copy link
Copy Markdown
Member

LGTM

benjamingr commented Mar 18, 2016

Copy link
Copy Markdown
Member

LGTM. Thanks Andrea.

cjihrig commented Mar 18, 2016

Copy link
Copy Markdown
Contributor

LGTM

WebReflection commented Mar 18, 2016

Copy link
Copy Markdown
Contributor Author

@benjamingr this is probably the smallest/easiest PR I've ever made so no problems at all ;-)

bsegault mentioned this pull request Mar 18, 2016
Closed

jasnell commented Mar 18, 2016

Copy link
Copy Markdown
Member

LGTM

jasnell pushed a commit that referenced this pull request Mar 18, 2016
doc: fix typo in synchronous randomBytes example
ac6af73 
The string template was closed after `${buf.length}`
causing a syntax error within the example.

PR-URL: #5781
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Mar 18, 2016

Copy link
Copy Markdown
Member

Landed in ac6af73.
I fixed up the commit log message so that it conforms to our style guidelines.
Thank you!

jasnell closed this Mar 18, 2016

WebReflection commented Mar 18, 2016

Copy link
Copy Markdown
Contributor Author

apologies I haven't fully followed the commit style guide. thanks for merging it

jasnell commented Mar 18, 2016

Copy link
Copy Markdown
Member

No worries :-) It's simple to fix. Really appreciate the contribution!

MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
doc: fix typo in synchronous randomBytes example
825db16 
The string template was closed after `${buf.length}`
causing a syntax error within the example.

PR-URL: #5781
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
doc: fix typo in synchronous randomBytes example
1e05f37 
The string template was closed after `${buf.length}`
causing a syntax error within the example.

PR-URL: #5781
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 mentioned this pull request Mar 22, 2016
Merged
Fishrock123 pushed a commit that referenced this pull request Mar 22, 2016
doc: fix typo in synchronous randomBytes example
d9b4e15 
The string template was closed after `${buf.length}`
causing a syntax error within the example.

PR-URL: #5781
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL