http2: add diagnostics channel 'http2.client.stream.created' - #58246
Merged
nodejs-github-bot merged 2 commits intoMay 11, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: Darshan Sen <raisinten@gmail.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
This comment was marked as outdated.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #58246 +/- ##
==========================================
+ Coverage 90.12% 90.18% +0.06%
==========================================
Files 629 629
Lines 186638 186657 +19
Branches 36618 36657 +39
==========================================
+ Hits 168202 168336 +134
+ Misses 11222 11125 -97
+ Partials 7214 7196 -18
... and 37 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Qard
approved these changes
May 9, 2025
ShogunPanda
approved these changes
May 9, 2025
ShogunPanda
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
santigimeno
approved these changes
May 9, 2025
This comment was marked as outdated.
Signed-off-by: Darshan Sen <raisinten@gmail.com>
Copy link
Copy Markdown
Member
Author
|
I pushed a tiny commit to assert that the stream is indeed a ClientHttp2Stream instance by checking the constructor name. Can you review it? |
Sorry, something went wrong.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Qard
approved these changes
May 11, 2025
RaisinTen
deleted the
http2-add-diagnostics-channel-http2.client.stream.created
branch
May 11, 2025 11:16
targos
pushed a commit
that referenced
this pull request
May 16, 2025
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #58246 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jun 10, 2025
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #58246 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.