| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Review requested:
|
Sorry, something went wrong.
Codecov Report❌ Patch coverage is 35.48387% with 20 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #57955 +/- ##
==========================================
- Coverage 92.26% 90.26% -2.00%
==========================================
Files 325 630 +305
Lines 126673 186155 +59482
Branches 20783 36478 +15695
==========================================
+ Hits 116869 168035 +51166
- Misses 9576 11000 +1424
- Partials 228 7120 +6892
... and 412 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
|
I think the new diagnostics channels should be mentioned in doc somewhere including stability level and version when they were added. e.g. see https://nodejs.org/docs/latest/api/diagnostics_channel.html#built-in-channels |
Sorry, something went wrong.
There was a problem hiding this comment.
As already stated, needs docs.
Also, might be better to put the created channel publishes in the ClientHttp2Stream and ClientHttp2Session constructors. Looks like some other logic is not being included in that window.
Sorry, something went wrong.
|
In researching this further, I discovered significant prior art by the nodesource team: nodesource/nsolid@6350b95 They are amenable to having this work upstreamed, so I am going to revamp my PR to pull in those commits and flesh it out with docs and tests. |
Sorry, something went wrong.
|
As discussed privately with Aman, I'll send separate PRs for this with tests and docs. Starting with #58246. |
Sorry, something went wrong.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Adds diagnostics similar to http/undici, to enable integration into network inspector protocol
cc #53946 (comment) @cola119