FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http2: add diagnostics channel 'http2.client.stream.start' by RaisinTen · Pull Request #58292 · nodejs/node · GitHub

/ node Public

http2: add diagnostics channel 'http2.client.stream.start' - #58292

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RaisinTen:http2-add-diagnostics-channel-http2.client.stream.start
May 14, 2025
Merged

http2: add diagnostics channel 'http2.client.stream.start'#58292
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RaisinTen:http2-add-diagnostics-channel-http2.client.stream.start

Conversation

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels May 12, 2025

Copy link
Copy Markdown
Collaborator

codecov Bot commented May 12, 2025
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (6184730) to head (79695a2).
Report is 32 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #58292   +/-   ##
=======================================
  Coverage   90.18%   90.19%           
=======================================
  Files         631      631           
  Lines      186690   186703   +13     
  Branches    36666    36663    -3     
=======================================
+ Hits       168360   168388   +28     
+ Misses      11126    11125    -1     
+ Partials     7204     7190   -14     
Files with missing lines Coverage Δ
lib/internal/http2/core.js 95.46% <100.00%> (+0.01%) ⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

RaisinTen added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 13, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 14, 2025
nodejs-github-bot merged commit b197355 into nodejs:main May 14, 2025

Copy link
Copy Markdown
Collaborator

Landed in b197355

RaisinTen deleted the http2-add-diagnostics-channel-http2.client.stream.start branch May 14, 2025 07:46
RaisinTen added the diagnostics_channel Issues and PRs related to diagnostics channel label May 15, 2025
targos pushed a commit that referenced this pull request May 16, 2025
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #58292
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #58292
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. diagnostics_channel Issues and PRs related to diagnostics channel http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL