http2: fix DEP0194 message - #58669
Merged
nodejs-github-bot merged 1 commit intoJun 11, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #58669 +/- ##
==========================================
- Coverage 90.16% 90.14% -0.03%
==========================================
Files 636 636
Lines 188060 188060
Branches 36899 36896 -3
==========================================
- Hits 169568 169526 -42
- Misses 11235 11282 +47
+ Partials 7257 7252 -5
... and 40 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
aduh95
approved these changes
Jun 11, 2025
aduh95
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Good catch!
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
Sorry, something went wrong.
This comment was marked as outdated.
pimterry
approved these changes
Jun 11, 2025
RaisinTen
approved these changes
Jun 11, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Jun 16, 2025
PR-URL: #58669 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This was referenced Jun 23, 2025
aduh95
pushed a commit
to mcollina/node
that referenced
this pull request
May 26, 2026
PR-URL: nodejs#58669 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #58293
Noticed the mentioned RFC in deprecation warning is typed as 1993, and the correct one should be 9113.