FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v22.x backport] deps: update nghttp2 to 1.69.0 by mcollina · Pull Request #63195 · nodejs/node · GitHub

/ node Public

[v22.x backport] deps: update nghttp2 to 1.69.0 - #63195

Closed
mcollina wants to merge 8 commits into
nodejs:v22.x-stagingfrom
mcollina:nghttp2-main-updates-v22.x-staging
ConversationCommits (8)ChecksFiles changed
Closed

[v22.x backport] deps: update nghttp2 to 1.69.0#63195
mcollina wants to merge 8 commits into
nodejs:v22.x-stagingfrom
mcollina:nghttp2-main-updates-v22.x-staging

Conversation

mcollina commented May 8, 2026 •
edited by aduh95
Loading

Copy link
Copy Markdown
Member

nodejs-github-bot commented May 8, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net
  • @nodejs/security-wg

nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels May 8, 2026
aduh95 changed the title Nghttp2 main updates v22.x staging [v22.x backport] deps: update nghttp2 to 1.69.0 May 8, 2026

aduh95 commented May 8, 2026

Copy link
Copy Markdown
Contributor

You would need #58293, but that's labelled semver-major

mcollina commented May 8, 2026

Copy link
Copy Markdown
Member Author

We need to backport this update due to GHSA-6933-cjhr-5qg6. I assume we don't want to float a patch on top of nghttp2, which also would not please security scanners.

marco-ippolito commented May 11, 2026

Copy link
Copy Markdown
Member

The failing tests are not flakes

mcollina force-pushed the nghttp2-main-updates-v22.x-staging branch from f1cb842 to 3e417f5 Compare May 11, 2026 15:33

mcollina commented May 11, 2026

Copy link
Copy Markdown
Member Author

I pushed up the wrong commit

aduh95 force-pushed the nghttp2-main-updates-v22.x-staging branch from 3e417f5 to cf3a0a2 Compare May 26, 2026 09:56

nodejs-github-bot commented May 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73735/

mcollina and others added 8 commits May 26, 2026 12:28
http2: remove support for priority signaling
2e23650 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: https://datatracker.ietf.org/doc/html/rfc9113#section-5.3.1
PR-URL: nodejs#58293
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
http2: fix DEP0194 message
2e3aa8c 
PR-URL: nodejs#58669
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
deps: update nghttp2 to 1.65.0
df72e15 
PR-URL: nodejs#57269
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
deps: update nghttp2 to 1.66.0
c12628d 
PR-URL: nodejs#58786
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
deps: update nghttp2 to 1.67.1
5f45d61 
PR-URL: nodejs#59790
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
deps: update nghttp2 to 1.68.0
608bf7c 
PR-URL: nodejs#61136
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
deps: update nghttp2 to 1.69.0
4b5b919 
PR-URL: nodejs#62891
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
deps: fix integration issues with the latest nghttp2
d13afce 
This is a set of src & tests fixes for nghttp2 due to changes in
v1.67.0+ which require a selection of changes to how we handle
low-level protocol errors when using the latest versions of nghttp2,
changing both some src error handling and updating some tests to match.

Signed-off-by: Tim Perry <pimterry@gmail.com>
PR-URL: nodejs#62891
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 force-pushed the nghttp2-main-updates-v22.x-staging branch 2 times, most recently from 5cd9919 to d13afce Compare May 26, 2026 10:33
aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label May 26, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 26, 2026

nodejs-github-bot commented May 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73741/

nodejs-github-bot commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73904/

aduh95 added the dependencies Pull requests that update a dependency file. label Jun 4, 2026
aduh95 added a commit that referenced this pull request Jun 16, 2026
http2: remove support for priority signaling
ea5dc6b 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: https://datatracker.ietf.org/doc/html/rfc9113#section-5.3.1
PR-URL: #58293
Backport-PR-URL: #63195
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jun 16, 2026
http2: fix DEP0194 message
0c37bff 
PR-URL: #58669
Backport-PR-URL: #63195
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jun 16, 2026
deps: update nghttp2 to 1.65.0
60890be 
PR-URL: #57269
Backport-PR-URL: #63195
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jun 16, 2026
deps: update nghttp2 to 1.66.0
c9f3da7 
PR-URL: #58786
Backport-PR-URL: #63195
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jun 16, 2026
deps: update nghttp2 to 1.67.1
290667c 
PR-URL: #59790
Backport-PR-URL: #63195
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jun 16, 2026
deps: update nghttp2 to 1.68.0
38c869f 
PR-URL: #61136
Backport-PR-URL: #63195
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jun 16, 2026
deps: update nghttp2 to 1.69.0
0f48583 
PR-URL: #62891
Backport-PR-URL: #63195
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jun 16, 2026
deps: fix integration issues with the latest nghttp2
9a5d2c9 
This is a set of src & tests fixes for nghttp2 due to changes in
v1.67.0+ which require a selection of changes to how we handle
low-level protocol errors when using the latest versions of nghttp2,
changing both some src error handling and updating some tests to match.

Signed-off-by: Tim Perry <pimterry@gmail.com>
PR-URL: #62891
Backport-PR-URL: #63195
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Landed in 5024c7d...a1a5bb9

aduh95 closed this Jun 18, 2026
R31K4G3 pushed a commit to R31K4G3/node that referenced this pull request Jun 28, 2026
deps: fix integration issues with the latest nghttp2
a1a5bb9 
This is a set of src & tests fixes for nghttp2 due to changes in
v1.67.0+ which require a selection of changes to how we handle
low-level protocol errors when using the latest versions of nghttp2,
changing both some src error handling and updating some tests to match.

Signed-off-by: Tim Perry <pimterry@gmail.com>
PR-URL: nodejs#62891
Backport-PR-URL: nodejs#63195
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: https://hackerone.com/reports/3658225
CVE-ID: CVE-2026-48937
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pimterry pimterry approved these changes
aduh95 aduh95 approved these changes
RafaelGSS RafaelGSS approved these changes
marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL