test: skip the test if the buffer allocation fails by lpinca · Pull Request #58738 · nodejs/node · GitHub

Use the error message as another condition to skip the test when the buffer allocation fails.

Refs: 795dd8eb7988ae38553e
Refs: e9c6004a2d580008082b

This should fix

https://ci.nodejs.org/job/node-test-binary-windows-js-suites/34803/RUN_SUBSET=3,nodes=win11-COMPILED_BY-vs2022_clang/testReport/junit/(root)/pummel/test_buffer_large_size_buffer_write/

---
duration_ms: 128.011
exitcode: 1
severity: fail
stack: |-
  c:\workspace\node-test-binary-windows-js-suites\node\test\pummel\test-buffer-large-size-buffer-write.js:19
      throw e;
      ^

  RangeError: Array buffer allocation failed
      at new ArrayBuffer (<anonymous>)
      at new Uint8Array (<anonymous>)
      at new FastBuffer (node:internal/buffer:968:5)
      at Buffer.alloc (node:buffer:399:10)
      at Object.<anonymous> (c:\workspace\node-test-binary-windows-js-suites\node\test\pummel\test-buffer-large-size-buffer-write.js:14:22)
      at Module._compile (node:internal/modules/cjs/loader:1691:14)
      at Object..js (node:internal/modules/cjs/loader:1823:10)
      at Module.load (node:internal/modules/cjs/loader:1426:32)
      at Module._load (node:internal/modules/cjs/loader:1249:12)
      at TracingChannel.traceSync (node:diagnostics_channel:322:14)

  Node.js v25.0.0-pre
...

https://ci.nodejs.org/job/node-test-binary-windows-js-suites/34840/RUN_SUBSET=2,nodes=win11-COMPILED_BY-vs2022_clang/testReport/junit/(root)/pummel/test_buffer_large_size_buffer_alloc_unsafe_slow/

---
duration_ms: 161.012
exitcode: 1
severity: fail
stack: |-
  c:\workspace\node-test-binary-windows-js-suites\node\test\pummel\test-buffer-large-size-buffer-alloc-unsafe-slow.js:15
      throw e;
      ^

  AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
  + actual - expected

  + Comparison {}
  - Comparison {
  -   code: 'ERR_STRING_TOO_LONG'
  - }

      at Object.<anonymous> (c:\workspace\node-test-binary-windows-js-suites\node\test\pummel\test-buffer-large-size-buffer-alloc-unsafe-slow.js:12:10)
      at Module._compile (node:internal/modules/cjs/loader:1691:14)
      at Object..js (node:internal/modules/cjs/loader:1823:10)
      at Module.load (node:internal/modules/cjs/loader:1426:32)
      at Module._load (node:internal/modules/cjs/loader:1249:12)
      at TracingChannel.traceSync (node:diagnostics_channel:322:14)
      at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
      at Module.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:152:5)
      at node:internal/main/run_main_module:33:47 {
    generatedMessage: true,
    code: 'ERR_ASSERTION',
    actual: RangeError: Array buffer allocation failed
        at new ArrayBuffer (<anonymous>)
        at new Uint8Array (<anonymous>)
        at new FastBuffer (node:internal/buffer:968:5)
        at createUnsafeBuffer (node:internal/buffer:1114:12)
        at Buffer.allocUnsafeSlow (node:buffer:418:10)
        at assert.throws.code (c:\workspace\node-test-binary-windows-js-suites\node\test\pummel\test-buffer-large-size-buffer-alloc-unsafe-slow.js:12:30)
        at getActual (node:assert:505:5)
        at ok.throws (node:assert:651:24)
        at Object.<anonymous> (c:\workspace\node-test-binary-windows-js-suites\node\test\pummel\test-buffer-large-size-buffer-alloc-unsafe-slow.js:12:10)
        at Module._compile (node:internal/modules/cjs/loader:1691:14),
    expected: { code: 'ERR_STRING_TOO_LONG' },
    operator: 'throws'
  }

  Node.js v25.0.0-pre
...

https://ci.nodejs.org/job/node-test-binary-windows-js-suites/34840/RUN_SUBSET=2,nodes=win11-COMPILED_BY-vs2022_clang/testReport/junit/(root)/pummel/test_buffer_large_size_slowbuffer/

---
duration_ms: 168.372
exitcode: 1
severity: fail
stack: |-
  c:\workspace\node-test-binary-windows-js-suites\node\test\pummel\test-buffer-large-size-slowbuffer.js:19
      throw e;
      ^

  AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
  + actual - expected

  + Comparison {}
  - Comparison {
  -   code: 'ERR_STRING_TOO_LONG'
  - }

      at Object.<anonymous> (c:\workspace\node-test-binary-windows-js-suites\node\test\pummel\test-buffer-large-size-slowbuffer.js:14:10)
      at Module._compile (node:internal/modules/cjs/loader:1691:14)
      at Object..js (node:internal/modules/cjs/loader:1823:10)
      at Module.load (node:internal/modules/cjs/loader:1426:32)
      at Module._load (node:internal/modules/cjs/loader:1249:12)
      at TracingChannel.traceSync (node:diagnostics_channel:322:14)
      at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
      at Module.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:152:5)
      at node:internal/main/run_main_module:33:47 {
    generatedMessage: true,
    code: 'ERR_ASSERTION',
    actual: RangeError: Array buffer allocation failed
        at new ArrayBuffer (<anonymous>)
        at new Uint8Array (<anonymous>)
        at new FastBuffer (node:internal/buffer:968:5)
        at createUnsafeBuffer (node:internal/buffer:1114:12)
        at Buffer.allocUnsafeSlow (node:buffer:418:10)
        at assert.throws.code (c:\workspace\node-test-binary-windows-js-suites\node\test\pummel\test-buffer-large-size-slowbuffer.js:14:30)
        at getActual (node:assert:505:5)
        at ok.throws (node:assert:651:24)
        at Object.<anonymous> (c:\workspace\node-test-binary-windows-js-suites\node\test\pummel\test-buffer-large-size-slowbuffer.js:14:10)
        at Module._compile (node:internal/modules/cjs/loader:1691:14),
    expected: { code: 'ERR_STRING_TOO_LONG' },
    operator: 'throws'
  }

  Node.js v25.0.0-pre
...

https://ci.nodejs.org/job/node-test-binary-windows-js-suites/34840/RUN_SUBSET=2,nodes=win11-COMPILED_BY-vs2022_clang/testReport/junit/(root)/pummel/test_string_decoder_large_buffer/

---
duration_ms: 174.014
exitcode: 1
severity: fail
stack: |-
  c:\workspace\node-test-binary-windows-js-suites\node\test\pummel\test-string-decoder-large-buffer.js:26
      throw e;
      ^

  RangeError: Array buffer allocation failed
      at new ArrayBuffer (<anonymous>)
      at new Uint8Array (<anonymous>)
      at new FastBuffer (node:internal/buffer:968:5)
      at createUnsafeBuffer (node:internal/buffer:1114:12)
      at allocate (node:buffer:433:10)
      at Buffer.allocUnsafe (node:buffer:408:10)
      at Object.<anonymous> (c:\workspace\node-test-binary-windows-js-suites\node\test\pummel\test-string-decoder-large-buffer.js:21:22)
      at Module._compile (node:internal/modules/cjs/loader:1691:14)
      at Object..js (node:internal/modules/cjs/loader:1823:10)
      at Module.load (node:internal/modules/cjs/loader:1426:32)

  Node.js v25.0.0-pre
...

Use the error message as another condition to skip the test when the buffer allocation fails. Refs: nodejs@795dd8eb7988ae38553e Refs: nodejs@e9c6004a2d580008082b

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.12%. Comparing base (0722023) to head (fdb2c4b).
Report is 183 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58738      +/-   ##
==========================================
- Coverage   90.16%   90.12%   -0.04%     
==========================================
  Files         637      639       +2     
  Lines      188126   188201      +75     
  Branches    36886    36909      +23     
==========================================
- Hits       169620   169617       -3     
- Misses      11272    11330      +58     
- Partials     7234     7254      +20

see 46 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Livia Medeiros <livia@cirno.name>

CI: https://ci.nodejs.org/job/node-test-pull-request/67497/

https://ci.nodejs.org/job/node-test-binary-windows-js-suites/34850/RUN_SUBSET=3,nodes=win11-COMPILED_BY-vs2022_clang/testReport/junit/(root)/pummel/test_string_decoder_large_buffer/

---
duration_ms: 203.164
exitcode: 134
severity: fail
stack: |2-

  <--- Last few GCs --->

  FATAL ERROR: MarkCompactCollector: young object promotion failed Allocation failed - JavaScript heap out of memory
  ----- Native stack trace -----

   1: 00007FF6857BD5B9
   2: 00007FF686409447
   3: 00007FF686208E77
   4: 00007FF6861E8E1E
   5: 00007FF6861DE4AC
   6: 00007FF6861DE15C
   7: 00007FF6861DDDA1
   8: 00007FF6861F0058
   9: 00007FF686AB6D7D
  10: 00007FF686AB7092
  11: 00007FF6861E0E14
  12: 00007FF6861C8733
  13: 00007FF6861C26D4
  14: 00007FF68620B3DA
  15: 00007FF68620A8C6
  16: 00007FF68621BE1E
  17: 00007FF68621B93B
  18: 00007FF68756CAAD
  19: 00007FF6862068E6
  20: 00007FF6862085ED
  21: 00007FF685FF37DA
  22: 00007FF685FF366B
  23: 00007FF6863DFB8A
  24: 00007FF6863DF03B
  25: 0000019737E78AFA
...

Regarding the OOM issue - maybe adding something like --max-old-space-size=8000 would help, the default size is ~4GB AFAICT, which doesn't give a lot of wiggle room since the buffer alone is ~4GB.

CI: https://ci.nodejs.org/job/node-test-pull-request/67539/

Landed in 3d608bb

Use the error message as another condition to skip the test when the buffer allocation fails. Refs: nodejs#58738

Use the error message as another condition to skip the test when the buffer allocation fails. Refs: #58738 PR-URL: #58771 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>

Use the error message as another condition to skip the test when the buffer allocation fails. Refs: 795dd8eb7988ae38553e Refs: e9c6004a2d580008082b PR-URL: #58738 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Use the error message as another condition to skip the test when the buffer allocation fails. Refs: #58738 PR-URL: #58771 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 17, 2025

test: skip the test if the buffer allocation fails

b65339b

Use the error message as another condition to skip the test when the buffer allocation fails. Refs: nodejs@795dd8eb7988ae38553e Refs: nodejs@e9c6004a2d580008082b

lpinca force-pushed the fix/flaky-tests branch from e4e25da to b65339b Compare June 17, 2025 08:34

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 17, 2025

github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 17, 2025

This comment was marked as outdated.

Sign in to view

LiviaMedeiros approved these changes Jun 17, 2025

View reviewed changes

LiviaMedeiros added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jun 17, 2025

LiviaMedeiros reviewed Jun 17, 2025

View reviewed changes

Comment thread test/pummel/test-string-decoder-large-buffer.js Outdated

Update test/pummel/test-string-decoder-large-buffer.js

fdb2c4b

Co-authored-by: Livia Medeiros <livia@cirno.name>

lpinca added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jun 17, 2025

LiviaMedeiros approved these changes Jun 17, 2025

View reviewed changes

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 17, 2025

joyeecheung approved these changes Jun 17, 2025

View reviewed changes

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2025

nodejs-github-bot merged commit 3d608bb into nodejs:main Jun 20, 2025

lpinca deleted the fix/flaky-tests branch June 20, 2025 06:18

lpinca added a commit to lpinca/node that referenced this pull request Jun 20, 2025

test: deflake test-buffer-large-size-buffer-alloc-unsafe

c378768

Use the error message as another condition to skip the test when the buffer allocation fails. Refs: nodejs#58738

lpinca mentioned this pull request Jun 20, 2025

test: deflake test-buffer-large-size-buffer-alloc-unsafe #58771

Merged

This was referenced Jun 23, 2025

2025-06-24, Version 24.3.0 (Current) #58804

Closed

2025-06-24, Version 24.3.0 (Current) #58813

Merged

aduh95 added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Jul 21, 2025

test: skip the test if the buffer allocation fails by lpinca · Pull Request #58738 · nodejs/node · GitHub

Uh oh!

Uh oh!

test: skip the test if the buffer allocation fails - #58738

test: skip the test if the buffer allocation fails#58738
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
lpinca:fix/flaky-tests

lpinca commented Jun 17, 2025

Uh oh!

lpinca commented Jun 17, 2025

Uh oh!

codecov Bot commented Jun 17, 2025 •
edited
Loading

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

nodejs-github-bot commented Jun 17, 2025

Uh oh!

LiviaMedeiros commented Jun 17, 2025

Uh oh!

joyeecheung commented Jun 17, 2025

Uh oh!

nodejs-github-bot commented Jun 19, 2025

Uh oh!

nodejs-github-bot commented Jun 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

test: skip the test if the buffer allocation fails by lpinca · Pull Request #58738 · nodejs/node · GitHub

Uh oh!

Uh oh!

test: skip the test if the buffer allocation fails - #58738

test: skip the test if the buffer allocation fails#58738nodejs-github-bot merged 2 commits intonodejs:mainnodejs/node:mainfrom lpinca:fix/flaky-testslpinca/node:fix/flaky-testsCopy head branch name to clipboard

Conversation

lpinca commented Jun 17, 2025

Uh oh!

lpinca commented Jun 17, 2025

Uh oh!

codecov Bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as outdated.

Uh oh!

nodejs-github-bot commented Jun 17, 2025

Uh oh!

LiviaMedeiros commented Jun 17, 2025

Uh oh!

joyeecheung commented Jun 17, 2025

Uh oh!

nodejs-github-bot commented Jun 19, 2025

Uh oh!

nodejs-github-bot commented Jun 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

test: skip the test if the buffer allocation fails#58738
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
lpinca:fix/flaky-tests

codecov Bot commented Jun 17, 2025 •
edited
Loading