test: deflake test-buffer-large-size-buffer-alloc-unsafe - #58771
Merged
nodejs-github-bot merged 1 commit intoJun 22, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Use the error message as another condition to skip the test when the buffer allocation fails. Refs: nodejs#58738
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #58771 +/- ##
==========================================
- Coverage 90.15% 90.14% -0.01%
==========================================
Files 639 639
Lines 188192 188192
Branches 36913 36905 -8
==========================================
- Hits 169660 169647 -13
+ Misses 11288 11281 -7
- Partials 7244 7264 +20 see 35 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
LiviaMedeiros
approved these changes
Jun 20, 2025
This comment was marked as outdated.
legendecas
approved these changes
Jun 20, 2025
RaisinTen
approved these changes
Jun 20, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Ethan-Arrowood
approved these changes
Jun 20, 2025
jasnell
approved these changes
Jun 20, 2025
dario-piotrowicz
approved these changes
Jun 20, 2025
dario-piotrowicz
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
great! looking forward to see this flake removed! 😄 🚀
Sorry, something went wrong.
RafaelGSS
pushed a commit
that referenced
this pull request
Jun 23, 2025
Use the error message as another condition to skip the test when the buffer allocation fails. Refs: #58738 PR-URL: #58771 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
This was referenced Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the error message as another condition to skip the test when the buffer allocation fails.
Refs: #58738