Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.86%. Comparing base (dfee0b1) to head (7944416).
⚠️ Report is 2753 commits behind head on main.

@@            Coverage Diff             @@
##             main   #59357      +/-   ##
==========================================
- Coverage   89.89%   89.86%   -0.03%     
==========================================
  Files         656      656              
  Lines      193141   193141              
  Branches    37886    37888       +2     
==========================================
- Hits       173623   173568      -55     
- Misses      12051    12099      +48     
- Partials     7467     7474       +7     

see 40 files with indirect coverage changes

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nektro
Could you please rebase the main branch?
I think it will fix the Windows error.

CI: https://ci.nodejs.org/job/node-test-pull-request/68508/

CI: https://ci.nodejs.org/job/node-test-pull-request/68532/

CI: https://ci.nodejs.org/job/node-test-pull-request/68534/

CI: https://ci.nodejs.org/job/node-test-pull-request/68552/

- Loading data for nodejs/node/pull/59357
✔  Done loading data for nodejs/node/pull/59357
----------------------------------- PR info ------------------------------------
Title      test: fix hidden error in test-http-server-stale-close.js (#59357)
Author     Meghan Denny <hello@nektro.net> (@nektro)
Branch     nektro:patch-9 -> nodejs:main
Labels     test, author ready, needs-ci, commit-queue-squash
Commits    2
 - test: fix hidden error in test-http-server-stale-close.js
 - Merge branch 'main' into patch-9
Committers 1
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/59357
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/59357
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 05 Aug 2025 04:19:27 GMT
   ✔  Approvals: 3
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/59357#pullrequestreview-3089680106
   ✔  - Ryuhei Shima (@islandryu): https://github.com/nodejs/node/pull/59357#pullrequestreview-3102466424
   ✔  - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/59357#pullrequestreview-3104630403
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-08-11T05:37:20Z: https://ci.nodejs.org/job/node-test-pull-request/68552/
- Querying data for job/node-test-pull-request/68552/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 59357
From https://github.com/nodejs/node
 * branch                  refs/pull/59357/merge -> FETCH_HEAD
✔  Fetched commits as fc3f19ef9324..24465b0ec1f8
--------------------------------------------------------------------------------
error: commit 24465b0ec1f8fafa4bd4b72b0335bed602e5203e is a merge but no -m option was given.
fatal: cherry-pick failed
[main 02dc17085b] test: fix hidden error in test-http-server-stale-close.js
 Author: Meghan Denny <meghan@bun.sh>
 Date: Mon Aug 4 21:17:59 2025 -0700
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✘  Failed to apply patches

@nektro
Sorry, you might have done a merge pull.
Could you remove the merge commit and pull main using rebase instead?
https://github.com/islandryu/node/blob/59112/doc/contributing/pull-requests.md#step-9-discuss-and-update

Could we update the test to make it fail if the forked child process exits with non-zero code?

  const server = http.createServer(common.mustCall((req, res) => {
    res.writeHead(200, { 'Content-Length': '42' });
    req.pipe(res);
    assert.strictEqual(req.destroyed, false);
    req.on('close', common.mustCall(() => {
      assert.strictEqual(req.destroyed, true);
      server.close();
      res.end();
    }));
  }));
  server.listen(0, common.mustCall(function () {
    const cp = fork(__filename, {
      stdio: 'inherit',
      env: { ...process.env, NODE_TEST_FORK_PORT: this.address().port }
    });
    cp.once('exit', common.mustCall((code) => {
      assert.strictEqual(code, 0);
    }))
  }));

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

Landed in 536aca7