test: enforce exit code in test-http-server-stale-close - #65198
Merged
nodejs-github-bot merged 1 commit intoAug 17, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
force-pushed
the
test-http-server-stale-close-exit-0
branch
from
415b627 to
132e894
Compare
August 10, 2026 16:01
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #65198 +/- ##
=======================================
Coverage 90.32% 90.32%
=======================================
Files 760 760
Lines 248525 248526 +1
Branches 46901 46897 -4
=======================================
+ Hits 224472 224491 +19
+ Misses 15471 15462 -9
+ Partials 8582 8573 -9 see 32 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
This comment was marked as resolved.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Aug 11, 2026
cjihrig
approved these changes
Aug 17, 2026
aduh95
added a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #65198 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95
added a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #65198 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until #59357 merged, we were failing to detect the forked process was erroring out