FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix broken fast callback signatures by Renegade334 · Pull Request #59600 · nodejs/node · GitHub

/ node Public

src: fix broken fast callback signatures - #59600

Closed
Renegade334 wants to merge 4 commits into
nodejs:mainfrom
Renegade334:fix-fast-callbacks
ConversationCommits (4)ChecksFiles changed
Closed

src: fix broken fast callback signatures#59600
Renegade334 wants to merge 4 commits into
nodejs:mainfrom
Renegade334:fix-fast-callbacks

Conversation

Renegade334 commented Aug 23, 2025

Copy link
Copy Markdown
Member

Re-submitting #59055 for visibility, as the last PR went six weeks without any reviews.

Since #54408, the various fast callbacks that were edited by that PR have broken signatures and have not been invoked. (The changed signatures would only have been valid if the receiver were prepended to the function arguments wherever those bindings were called from JS, which isn't the case.)

There was no debug tracking of these callbacks, so this went unnoticed at the time.

This change fixes the broken signatures and adds debug testing to validate the fast paths.

This effectively reverts the remaining source changes from #54408 that were not already covered by #58054.

nodejs-github-bot commented Aug 23, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/wasi

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 23, 2025
Renegade334 commented Aug 23, 2025
View reviewed changes
Comment thread src/histogram.cc
Comment on lines -190 to -194
if (value < 1) {
HandleScope scope(options.isolate);
THROW_ERR_OUT_OF_RANGE(options.isolate, "value is out of range");
return;
}

Renegade334 Aug 23, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

value is validated in the JS layer, so an assertion should be fine here.

codecov Bot commented Aug 23, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.52941% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.87%. Comparing base (589ef79) to head (70f57f5).
⚠️ Report is 215 commits behind head on main.

Files with missing lines Patch % Lines
src/histogram.cc 30.76% 8 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #59600      +/-   ##
==========================================
+ Coverage   89.83%   89.87%   +0.04%     
==========================================
  Files         667      667              
  Lines      196062   196059       -3     
  Branches    38501    38501              
==========================================
+ Hits       176133   176217      +84     
+ Misses      12397    12287     -110     
- Partials     7532     7555      +23
Files with missing lines Coverage Δ
src/histogram.h 60.00% <ø> (ø)
src/node_process.h 100.00% <100.00%> (+75.00%) ⬆️
src/node_process_methods.cc 88.69% <100.00%> (+0.88%) ⬆️
src/node_wasi.cc 65.81% <ø> (+1.56%) ⬆️
src/node_wasi.h 0.00% <ø> (ø)
src/timers.cc 96.39% <100.00%> (+8.10%) ⬆️
src/timers.h 100.00% <ø> (ø)
src/histogram.cc 79.16% <30.76%> (+3.74%) ⬆️

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

addaleax added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 4, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2025

nodejs-github-bot commented Sep 4, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69049/

nodejs-github-bot commented Sep 5, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69082/

nodejs-github-bot commented Sep 14, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69225/

Renegade334 commented Sep 20, 2025

Copy link
Copy Markdown
Member Author

This should be ready for CQ.

addaleax added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Sep 24, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2025

nodejs-github-bot commented Sep 24, 2025

Copy link
Copy Markdown
Collaborator

Landed in f5e2ecc...8ca5fec

nodejs-github-bot pushed a commit that referenced this pull request Sep 24, 2025
perf_hooks: fix histogram fast call signatures
e9a0912 
PR-URL: #59600
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
nodejs-github-bot pushed a commit that referenced this pull request Sep 24, 2025
process: fix hrtime fast call signatures
5ac6ee7 
PR-URL: #59600
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
nodejs-github-bot pushed a commit that referenced this pull request Sep 24, 2025
wasi: fix WasiFunction fast call signature
4f4d5b3 
PR-URL: #59600
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
nodejs-github-bot pushed a commit that referenced this pull request Sep 24, 2025
timers: fix binding fast call signatures
8ca5fec 
PR-URL: #59600
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Renegade334 deleted the fix-fast-callbacks branch September 24, 2025 17:22
targos pushed a commit that referenced this pull request Oct 6, 2025
perf_hooks: fix histogram fast call signatures
a722f67 
PR-URL: #59600
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Oct 6, 2025
process: fix hrtime fast call signatures
cd034e9 
PR-URL: #59600
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Oct 6, 2025
wasi: fix WasiFunction fast call signature
8c21c4b 
PR-URL: #59600
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Oct 6, 2025
timers: fix binding fast call signatures
d728545 
PR-URL: #59600
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
github-actions Bot mentioned this pull request Oct 7, 2025
Merged
aduh95 pushed a commit that referenced this pull request Oct 22, 2025
process: fix hrtime fast call signatures
fe492c7 
PR-URL: #59600
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95 pushed a commit that referenced this pull request Oct 22, 2025
wasi: fix WasiFunction fast call signature
81548ab 
PR-URL: #59600
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95 pushed a commit that referenced this pull request Oct 22, 2025
timers: fix binding fast call signatures
cee3622 
PR-URL: #59600
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
github-actions Bot mentioned this pull request Oct 23, 2025
Merged
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jul 16, 2026
perf_hooks: fix histogram fast call signatures
af00ddc 
PR-URL: nodejs#59600
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
juanarbol pushed a commit that referenced this pull request Jul 17, 2026
perf_hooks: fix histogram fast call signatures
bfab503 
PR-URL: #59600
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
marco-ippolito pushed a commit that referenced this pull request Jul 29, 2026
perf_hooks: fix histogram fast call signatures
2197425 
PR-URL: #59600
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
wspringer mentioned this pull request Aug 25, 2026
Merged
wspringer added a commit to wspringer/lilypond-mcp that referenced this pull request Aug 25, 2026
fix: sidestep the node:wasi fast-call crash instead of requiring Node…
cda4bf6 
… 24 (#9)

Bisected: 22.21.0 ok, 22.21.1 crash (all platforms, not Linux-only —
the WasiFunction fast-call signature backport, nodejs/node#59600).
--no-turbo-fast-api-calls on the worker avoids the broken fast path;
the platform guard is gone and any Node >= 20 works.
knope-bot Bot mentioned this pull request Aug 25, 2026
Merged
wspringer mentioned this pull request Aug 25, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
anonrig anonrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL