src: fix internalModuleStat v8 fast path by anonrig · Pull Request #58054 · nodejs/node · GitHub

v8 fast path was not triggering before this. I've updated the implementation and added proper test for it.

cc @nodejs/cpp-reviewers @nodejs/performance

Review requested:

@nodejs/loaders
@nodejs/security-wg

CI: https://ci.nodejs.org/job/node-test-pull-request/66486/

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.19%. Comparing base (e0cf8ae) to head (aa493c2).
⚠️ Report is 1036 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_file.cc	57.14%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #58054   +/-   ##
=======================================
  Coverage   90.18%   90.19%           
=======================================
  Files         630      630           
  Lines      186393   186392    -1     
  Branches    36595    36592    -3     
=======================================
+ Hits       168103   168119   +16     
+ Misses      11090    11089    -1     
+ Partials     7200     7184   -16

Files with missing lines	Coverage Δ
lib/fs.js	98.26% <100.00%> (ø)
lib/internal/fs/promises.js	98.24% <100.00%> (ø)
lib/internal/modules/cjs/loader.js	98.26% <100.00%> (ø)
lib/internal/modules/esm/resolve.js	96.17% <ø> (-0.01%)	⬇️
lib/internal/modules/package_json_reader.js	99.36% <ø> (-0.01%)	⬇️
src/node_external_reference.h	100.00% <ø> (ø)
src/node_file.cc	76.94% <57.14%> (+0.21%)	⬆️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Landed in 5ed1bcb

Commit Queue failed

- Loading data for nodejs/node/pull/58054
✔  Done loading data for nodejs/node/pull/58054
----------------------------------- PR info ------------------------------------
Title      src: fix internalModuleStat v8 fast path (#58054)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     anonrig:yagiz/internal-module-stat -> nodejs:main
Labels     lib / src, author ready, needs-ci
Commits    1
 - src: fix internalModuleStat v8 fast path
Committers 1
 - Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: https://github.com/nodejs/node/pull/58054
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/58054
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 27 Apr 2025 17:45:21 GMT
   ✔  Approvals: 2
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58054#pullrequestreview-2797706038
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/58054#pullrequestreview-2797709654
   ⚠  This PR was merged on Tue, 29 Apr 2025 17:53:13 GMT
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-04-27T18:10:22Z: https://ci.nodejs.org/job/node-test-pull-request/66486/
- Querying data for job/node-test-pull-request/66486/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/14777283946

PR-URL: #58054 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

PR-URL: nodejs#58054 Backport-PR-URL: nodejs#59065 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs/node#58054

* chore: bump node in DEPS to v22.18.0 * crypto: fix inclusion of OPENSSL_IS_BORINGSSL define nodejs/node#58845 * crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4 nodejs/node#58960 * permission: propagate permission model flags on spawn nodejs/node#58853 * esm: syncify default path of ModuleLoader\.load nodejs/node#57419 * src: remove fast API for InternalModuleStat nodejs/node#58489 * src: simplify adding fast APIs to ExternalReferenceRegistry nodejs/node#58896 * chore: fixup patch indices * src: fix internalModuleStat v8 fast path nodejs/node#58054 * test: add tests to ensure that node.1 is kept in sync with cli.md nodejs/node#58878 * crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4 nodejs/node#58942 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

chore: bump node to v22.18.0 (main) (#47937) * chore: bump node in DEPS to v22.18.0 * crypto: fix inclusion of OPENSSL_IS_BORINGSSL define nodejs/node#58845 * crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4 nodejs/node#58960 * permission: propagate permission model flags on spawn nodejs/node#58853 * esm: syncify default path of ModuleLoader\.load nodejs/node#57419 * src: remove fast API for InternalModuleStat nodejs/node#58489 * src: simplify adding fast APIs to ExternalReferenceRegistry nodejs/node#58896 * chore: fixup patch indices * src: fix internalModuleStat v8 fast path nodejs/node#58054 * test: add tests to ensure that node.1 is kept in sync with cli.md nodejs/node#58878 * crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4 nodejs/node#58942 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* chore: bump node in DEPS to v22.18.0 * crypto: fix inclusion of OPENSSL_IS_BORINGSSL define nodejs/node#58845 * crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4 nodejs/node#58960 * permission: propagate permission model flags on spawn nodejs/node#58853 * esm: syncify default path of ModuleLoader\.load nodejs/node#57419 * src: remove fast API for InternalModuleStat nodejs/node#58489 * src: simplify adding fast APIs to ExternalReferenceRegistry nodejs/node#58896 * chore: fixup patch indices * src: fix internalModuleStat v8 fast path nodejs/node#58054 * test: add tests to ensure that node.1 is kept in sync with cli.md nodejs/node#58878 * crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4 nodejs/node#58942 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

anonrig requested review from jasnell, ronag and targos April 27, 2025 17:45

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 27, 2025

src: fix internalModuleStat v8 fast path

aa493c2

anonrig force-pushed the yagiz/internal-module-stat branch from b563e9e to aa493c2 Compare April 27, 2025 17:56

jasnell approved these changes Apr 27, 2025

View reviewed changes

anonrig added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 27, 2025

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 27, 2025

ronag approved these changes Apr 27, 2025

View reviewed changes

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 27, 2025

RafaelGSS reviewed Apr 29, 2025

View reviewed changes

Comment thread test/parallel/test-permission-fs-internal-module-stat.js

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 29, 2025

nodejs-github-bot merged commit 5ed1bcb into nodejs:main Apr 29, 2025

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label May 1, 2025

RafaelGSS pushed a commit that referenced this pull request May 1, 2025

src: fix internalModuleStat v8 fast path

b6a02bf

PR-URL: #58054 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

RafaelGSS mentioned this pull request May 1, 2025

2025-05-06, Version 24.0.0 (Current) #57609

Merged

RafaelGSS pushed a commit that referenced this pull request May 2, 2025

src: fix internalModuleStat v8 fast path

d712aa4

PR-URL: #58054 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

Renegade334 mentioned this pull request Jul 13, 2025

src: fix broken fast callback signatures #59055

Closed

Renegade334 mentioned this pull request Jul 14, 2025

[v22.x backport] src: backport fast API changes #59065

Merged

aduh95 added the backport-open-v22.x Indicate that the PR has an open backport label Jul 21, 2025

github-actions Bot mentioned this pull request Jul 28, 2025

2025-07-29, Version 22.18.0 'Jod' (LTS) #59256

Merged

codebytere added a commit to electron/electron that referenced this pull request Aug 4, 2025

src: fix internalModuleStat v8 fast path

7400e56

nodejs/node#58054

wbolster mentioned this pull request Aug 4, 2025

Node 22.18.0, ESLint 9.32.0, eslint-plugin-compat@6.0.2, browserslist-config-baseline@0.4.0 combination httptoolkit/esm#8

Open

codebytere added a commit to electron/electron that referenced this pull request Aug 4, 2025

src: fix internalModuleStat v8 fast path

4d8ef44

nodejs/node#58054

Renegade334 mentioned this pull request Aug 23, 2025

src: fix broken fast callback signatures #59600

Closed

richardlau added backported-to-v22.x PRs backported to the v22.x-staging branch. and removed backport-open-v22.x Indicate that the PR has an open backport labels Sep 19, 2025

src: fix internalModuleStat v8 fast path by anonrig · Pull Request #58054 · nodejs/node · GitHub

Uh oh!

Uh oh!

src: fix internalModuleStat v8 fast path - #58054

src: fix internalModuleStat v8 fast path#58054
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:yagiz/internal-module-stat

anonrig commented Apr 27, 2025

Uh oh!

nodejs-github-bot commented Apr 27, 2025

Uh oh!

nodejs-github-bot commented Apr 27, 2025

Uh oh!

codecov Bot commented Apr 27, 2025 •
edited
Loading

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 29, 2025

Uh oh!

nodejs-github-bot commented May 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

src: fix internalModuleStat v8 fast path by anonrig · Pull Request #58054 · nodejs/node · GitHub

Uh oh!

Uh oh!

src: fix internalModuleStat v8 fast path - #58054

src: fix internalModuleStat v8 fast path#58054nodejs-github-bot merged 1 commit intonodejs:mainnodejs/node:mainfrom anonrig:yagiz/internal-module-statanonrig/node:yagiz/internal-module-statCopy head branch name to clipboard

Conversation

anonrig commented Apr 27, 2025

Uh oh!

nodejs-github-bot commented Apr 27, 2025

Uh oh!

nodejs-github-bot commented Apr 27, 2025

Uh oh!

codecov Bot commented Apr 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 29, 2025

Uh oh!

nodejs-github-bot commented May 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

src: fix internalModuleStat v8 fast path#58054
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:yagiz/internal-module-stat

codecov Bot commented Apr 27, 2025 •
edited
Loading