deps: add ngtcp2 test binaries - #59946
Closed
jasnell wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
jasnell
force-pushed
the
jasnell/add-ngtcp2-test-binaries
branch
3 times, most recently
from
dab25f9 to
5c6f34a
Compare
September 20, 2025 15:31
The goal here is to add the ngtcp2 client and server samples so that we can use them in CI to test our QUIC implementation.
jasnell
force-pushed
the
jasnell/add-ngtcp2-test-binaries
branch
4 times, most recently
from
e487547 to
0e4cf64
Compare
September 20, 2025 16:37
jasnell
force-pushed
the
jasnell/add-ngtcp2-test-binaries
branch
from
0e4cf64 to
d4ac0e2
Compare
September 20, 2025 17:06
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #59946 +/- ##
==========================================
+ Coverage 88.41% 88.44% +0.02%
==========================================
Files 703 703
Lines 207398 207401 +3
Branches 39987 39992 +5
==========================================
+ Hits 183374 183438 +64
+ Misses 15995 15933 -62
- Partials 8029 8030 +1 see 36 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
jasnell
force-pushed
the
jasnell/add-ngtcp2-test-binaries
branch
from
d4ac0e2 to
285bcf1
Compare
September 20, 2025 18:07
jasnell
force-pushed
the
jasnell/add-ngtcp2-test-binaries
branch
from
285bcf1 to
8d093b4
Compare
September 20, 2025 18:35
anonrig
approved these changes
Sep 27, 2025
Copy link
Copy Markdown
Member
Sorry, something went wrong.
9 tasks
targos
added a commit
to targos/node
that referenced
this pull request
Dec 23, 2025
It was fixed to 1.15.1 in nodejs#59946 without explanation.
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Jul 30, 2026
The goal here is to add the ngtcp2 client and server samples so that we can use them in CI to test our QUIC implementation. PR-URL: nodejs#59946 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Jul 30, 2026
PR-URL: nodejs#59946 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal here is to add the ngtcp2 client and server samples so that we can use them in CI to test our QUIC implementation.
The sample server/client from ngtcp2 does not currently build on AIX or Windows but that should be fine. The tests against these won't be the only tests we do, they are intended only to be able to prove that our implementation can interop with an existing other implementations.