FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: fix flags for ngtcp2 on IBM i by sravani1510 · Pull Request #60073 · nodejs/node · GitHub

/ node Public

build: fix flags for ngtcp2 on IBM i - #60073

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
sravani1510:ibmi-ngtcp2.gyp
Oct 2, 2025
ConversationCommits (2)ChecksFiles changed
Merged

build: fix flags for ngtcp2 on IBM i#60073
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
sravani1510:ibmi-ngtcp2.gyp

Conversation

sravani1510 commented Sep 30, 2025 •
edited by abmusse
Loading

Copy link
Copy Markdown
Contributor

similar to aix IBM i does not support certain network flags we are getting the following build errors:

../deps/ngtcp2/ngtcp2/examples/shared.cc:68:63: error:
 'IPTOS_ECN_MASK' was not declared in this scope
   68 |         return *reinterpret_cast<uint8_t *>(CMSG_DATA(cmsg))
    & IPTOS_ECN_MASK;
      |                                                              
       ^~~~~~~~~~~~~~
../deps/ngtcp2/ngtcp2/examples/shared.cc:80:22: error:
 'IPTOS_ECN_MASK' was not declared in this scope
   80 |         return tos & IPTOS_ECN_MASK;
      |                      ^~~~~~~~~~~~~~

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg

nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Sep 30, 2025
abmusse added the ibm i Issues and PRs related to the IBM i platform. label Sep 30, 2025

sravani1510 commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

CC

@nodejs/platform-ibmi

richardlau commented Sep 30, 2025

Copy link
Copy Markdown
Member

@sravani1510 Would you be able to change the commit message to "build: fix flags for ngtcp2 on IBM i"? (Or something similar, the important bit is that we don't use the "fix:" prefix here -- see our commit message guidelines.)

sravani1510 changed the title fix: flags for ngtcp2 on IBM i build: fix flags for ngtcp2 on IBM i Sep 30, 2025

abmusse commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

Test Build: https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi74-ppc64/2095/console

We will also need to skip the tests like on AIX.

See: #60064

richardlau added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Sep 30, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2025

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69475/

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69479/

nodejs-github-bot commented Oct 1, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69483/

abmusse approved these changes Oct 1, 2025
View reviewed changes

abmusse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 1, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2025
nodejs-github-bot merged commit 0eda17b into nodejs:main Oct 2, 2025
65 checks passed

nodejs-github-bot commented Oct 2, 2025

Copy link
Copy Markdown
Collaborator

Landed in 0eda17b

sravani1510 deleted the ibmi-ngtcp2.gyp branch October 6, 2025 10:27
targos added the dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. label Oct 6, 2025

targos commented Oct 6, 2025

Copy link
Copy Markdown
Member

depends on #59946

richardlau added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Oct 6, 2025
sravani1510 mentioned this pull request Oct 8, 2025
Merged
RafaelGSS mentioned this pull request Oct 13, 2025
Merged
9 tasks
aduh95 mentioned this pull request Jul 22, 2026
Closed
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 30, 2026
build: fix flags for ngtcp2 on IBM i
db014fc 
PR-URL: nodejs#60073
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Abdirahim Musse <abdirahim.musse@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
build: fix flags for ngtcp2 on IBM i
91f5003 
PR-URL: #60073
Backport-PR-URL: #64675
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Abdirahim Musse <abdirahim.musse@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
github-actions Bot mentioned this pull request Aug 21, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
richardlau richardlau approved these changes
abmusse abmusse approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. ibm i Issues and PRs related to the IBM i platform. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL