win,build: add creation of zip and 7z package - #5995
Conversation
Sorry, something went wrong.
|
Should the zip also contain Node's license file? |
Sorry, something went wrong.
|
Updated missing files, PTAL |
Sorry, something went wrong.
|
@nodejs/build added 7zip to the release machines. Here is a test build: https://nodejs.org/download/test/v6.0.0-test20160411758655d70e88446a24d8dbbb07f1c1defd317293/ |
Sorry, something went wrong.
|
I think the bundle files should go in the parent directory, leaving win-x* for individual files (including the zipped pdb) |
Sorry, something went wrong.
|
Silly question perhaps, but are we completely OK here in terms of licensing? I remember 7z is an open LGPL format and IIRC there are open clients for opening it on all supported platforms but I want to make sure someone "from the loop" is aware. |
Sorry, something went wrong.
|
Moved the archives to parent directory. |
Sorry, something went wrong.
|
@benjamingr I'm not completely sure about anything related to licences. We are only using 7 Zip the executable, not linking against it or the dll. Is it an issue? |
Sorry, something went wrong.
|
I'm 99% sure that this is not an issue and I'm probably a lot more clueless than you about it - but since I haven't seen 7z files in the project before I think it would be a good idea to make sure with someone who is sure. |
Sorry, something went wrong.
|
@mikeal can you maybe help answer the licensing concern? |
Sorry, something went wrong.
|
From http://www.7-zip.org/license.txt :
Hence, we can move ahead if there are no more specific concerns. |
Sorry, something went wrong.
|
Rebased, a new test build is building: https://nodejs.org/download/test/v7.0.0-test20160505ef2e444e6dc4401519f2f28bcaf6d6b48b8f3590/ |
Sorry, something went wrong.
|
@nodejs/build @nodejs/platform-windows this is still in need of a LGTM, can you take a look? |
Sorry, something went wrong.
|
@rvagg After moving the zip and 7z files out of the win-x* directory, they are left in the staging server and do not appear online. Can you point us to the correct place to change to make this work? Thanks! |
Sorry, something went wrong.
Add a step in vcbuild.bat to create a minimal package including node and npm that can be used as an alternative to the MSI. Compress the node.pdb file as zip and 7z. All files are uploaded as part of build-release. Fixes: nodejs/build#299 Fixes: nodejs#5696
|
@joaocgreis I just ran another test @ https://nodejs.org/download/test/v7.0.0-test2016051536b525a781/ and managed to catch this state in staging before the *.done files were cleaned up—which is done every 5 minutes after the matching files are moved to dist. -rw-r--r-- 1 staging staging 6559346 May 15 09:52 node-v7.0.0-test2016051536b525a781-win-x64.7z -rw-r--r-- 1 staging staging 12007980 May 15 09:52 node-v7.0.0-test2016051536b525a781-win-x64.zip -rw-rw-r-- 1 staging staging 0 May 15 09:52 node-v7.0.0-test2016051536b525a781-x64.7z.done -rw-rw-r-- 1 staging staging 0 May 15 09:52 node-v7.0.0-test2016051536b525a781-x64.zip.done i.e. it's just a simple mismatch between the .done files and their promotables: node-v%FULLVERSION%-win-%target_arch%.7z and node-v%FULLVERSION%-win-%target_arch%.zip but the touch makes: node-v%FULLVERSION%-%target_arch%.zip.done and node-v%FULLVERSION%-%target_arch%.7z.done Put the win- in there and it should all work fine and we can run another test. |
Sorry, something went wrong.
|
I've updated the filenames, PTAL |
Sorry, something went wrong.
|
@rvagg Thanks! Started another build, this time it looks good: https://nodejs.org/download/test/v7.0.0-test201605168b733b76c753513ff87ed841e2bef69b12fe0460/ |
Sorry, something went wrong.
|
yes, lgtm, but let's give @nodejs/ctc a chance to jump in here before you merge since this is actually not a small deal. Once we start shipping .7z and .zip files for Windows we're not going to be able to undo that very easily in the future, so it's a big commitment. Our dist directories will start to look like this: ../ docs/ win-x64/ win-x86/ SHASUMS256.txt node-v7.0.0-darwin-x64.tar.gz node-v7.0.0-darwin-x64.tar.xz node-v7.0.0-headers.tar.gz node-v7.0.0-headers.tar.xz node-v7.0.0-linux-arm64.tar.gz node-v7.0.0-linux-arm64.tar.xz node-v7.0.0-linux-armv6l.tar.gz node-v7.0.0-linux-armv6l.tar.xz node-v7.0.0-linux-armv7l.tar.gz node-v7.0.0-linux-armv7l.tar.xz node-v7.0.0-linux-ppc64le.tar.gz node-v7.0.0-linux-ppc64le.tar.xz node-v7.0.0-linux-ppc64.tar.gz node-v7.0.0-linux-ppc64.tar.xz node-v7.0.0-linux-x64.tar.gz node-v7.0.0-linux-x64.tar.xz node-v7.0.0-linux-x86.tar.gz node-v7.0.0-linux-x86.tar.xz node-v7.0.0.pkg node-v7.0.0-sunos-x64.tar.gz node-v7.0.0-sunos-x64.tar.xz node-v7.0.0-sunos-x86.tar.gz node-v7.0.0-sunos-x86.tar.xz node-v7.0.0.tar.gz node-v7.0.0.tar.xz node-v7.0.0-win-x64.7z node-v7.0.0-win-x64.zip node-v7.0.0-win-x86.7z node-v7.0.0-win-x86.zip node-v7.0.0-x64.msi node-v7.0.0-x86.msi And both win-x64 and win-x86 have two new files, node_pdb.7z ~ 6.2M and node_pdb.zip ~ 10M. <= v0.12 we ship(ped) with uncompressed node.pdb files ~31M but we canned that from io.js onward due to skepticism that they were even being used, and we have had minimal call to add them back. Here's the one issue we've had filed about it: #5696. .pdb files contain debugging information for Windows applications. So, comment now before this all gets locked in. |
Sorry, something went wrong.
|
How large is x86 windows usage? Maybe we could just ship x64 zips? (I have no idea) |
Sorry, something went wrong.
|
How long does it take to produce node_pdb? Will that increase release build time significantly for the windows machines? |
Sorry, something went wrong.
|
@Fishrock123 I made a quick experiment, zipping (2 zip + 2 7z) takes 1m21s in our release machines. I don't know exactly how long the upload takes. The test build I ran took 19m, but the Pi1 still takes the longest with 52m. If the directory size is a concern, we can keep only the MSI in the main dir and move the others into the specific win dirs. |
Sorry, something went wrong.
|
@joaocgreis I'm not worried about the zipping, I was wondering about generating the pdb file. |
Sorry, something went wrong.
|
@Fishrock123 the pdb is always generated when compiling, no added delay there. |
Sorry, something went wrong.
|
basic stats are at https://nodejs.org/metrics/summaries/os.png & https://nodejs.org/metrics/summaries/arch.png but there's no combination graph, the data is available @ https://nodejs.org/metrics/ if someone wants to look at the win/arch numbers. My gut feel is that win x86 is still very high. Re directory size (in terms of number of entries) I'm not so concerned these days, we have a great downloads page that I think most people are using so they don't have to navigate a complex list if they are not capable of doing so. |
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
|
lgtm, make it so |
Sorry, something went wrong.
Add a step in vcbuild.bat to create a minimal package including node and npm that can be used as an alternative to the MSI. Compress the node.pdb file as zip and 7z. All files are uploaded as part of build-release. Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> PR-URL: #5995 Fixes: nodejs/build#299 Fixes: #5696
|
CI: https://ci.nodejs.org/job/node-test-pull-request/2871/ Landed as 2369f89 . |
Sorry, something went wrong.
Add a step in vcbuild.bat to create a minimal package including node and npm that can be used as an alternative to the MSI. Compress the node.pdb file as zip and 7z. All files are uploaded as part of build-release. Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> PR-URL: #5995 Fixes: nodejs/build#299 Fixes: #5696
Add a step in vcbuild.bat to create a minimal package including node and npm that can be used as an alternative to the MSI. Compress the node.pdb file as zip and 7z. All files are uploaded as part of build-release. Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> PR-URL: #5995 Fixes: nodejs/build#299 Fixes: #5696
|
oh, hey, these all came out in the latest release https://nodejs.org/download/release/latest-v6.x/ |
Sorry, something went wrong.
Add a step in vcbuild.bat to create a minimal package including node and npm that can be used as an alternative to the MSI. Compress the node.pdb file as zip and 7z. All files are uploaded as part of build-release. Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> PR-URL: nodejs#5995 Fixes: nodejs/build#299 Fixes: nodejs#5696
Add a step in vcbuild.bat to create a minimal package including node and npm that can be used as an alternative to the MSI. Compress the node.pdb file as zip and 7z. All files are uploaded as part of build-release. Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> PR-URL: #5995 Fixes: nodejs/build#299 Fixes: #5696
Add a step in vcbuild.bat to create a minimal package including node and npm that can be used as an alternative to the MSI. Compress the node.pdb file as zip and 7z. All files are uploaded as part of build-release. Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> PR-URL: #5995 Fixes: nodejs/build#299 Fixes: #5696
Add a step in vcbuild.bat to create a minimal package including node and npm that can be used as an alternative to the MSI. Compress the node.pdb file as zip and 7z. All files are uploaded as part of build-release. Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> PR-URL: #5995 Fixes: nodejs/build#299 Fixes: #5696
Add a step in vcbuild.bat to create a minimal package including node and npm that can be used as an alternative to the MSI. Compress the node.pdb file as zip and 7z. All files are uploaded as part of build-release. Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> PR-URL: #5995 Fixes: nodejs/build#299 Fixes: #5696
Add a step in vcbuild.bat to create a minimal package including node and npm that can be used as an alternative to the MSI. Compress the node.pdb file as zip and 7z. All files are uploaded as part of build-release. Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> PR-URL: #5995 Fixes: nodejs/build#299 Fixes: #5696
Pull Request check-list
this change (including linting)?
Affected core subsystem(s)
Windows, build.
Description of change
Add a step in vcbuild.bat to create a minimal package including node and npm that can be used as an alternative to the MSI, compress the node.pdb file as zip and 7z and upload all files as part of build-release.
This requires 7zip to be installed on the release machines. If there is no objection, I plan to add it and test this with a nightly. Files are included in the upload stage, do we need to do anything else to add them to releases @nodejs/build @nodejs/release ?
Fixes: nodejs/build#299
Fixes: #5696
cc @nodejs/platform-windows