| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
CI: https://ci.nodejs.org/job/node-test-pull-request/2872/ |
Sorry, something went wrong.
|
Let's leave 0.10 and 0.12 alone, we've tried to keep the dist directories fairly static and there's already some .pdb stuff in there anyway. I'm fine with this for v4.x but would much rather wait till we've had a few releases of v6 to verify that we've got it sorted out first. This looks like a straightforward backport without anything different from the original, is that correct @joaocgreis? If so, lgtm. |
Sorry, something went wrong.
@rvagg that is correct. I'm ok with waiting. This is ready to go in, but there's no reason to rush. I'll rebase and ping when there are a couple of releases of v6 out with this. |
Sorry, something went wrong.
|
@joaocgreis looks like this needs a rebase |
Sorry, something went wrong.
Add a step in vcbuild.bat to create a minimal package including node and npm that can be used as an alternative to the MSI. Compress the node.pdb file as zip and 7z. All files are uploaded as part of build-release. Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> PR-URL: nodejs#5995 Fixes: nodejs/build#299 Fixes: nodejs#5696
|
Rebased. Should we start another test build? |
Sorry, something went wrong.
Sorry, something went wrong.
|
CI green, here is another test build: https://nodejs.org/download/test/v4.4.8-test20160707c21b63cbf0770fcf0b9e4a4fbe160d6eb87bfd3e/ @rvagg @thealphanerd LGTY? (and should I land this myself?) |
Sorry, something went wrong.
|
lgtm pending an RC or test build |
Sorry, something went wrong.
|
landed in b69bcaf This will be included in the v4.5.0 rc's that will be put together soon |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Checklist
Affected core subsystem(s)
win, build
Description of change
@nodejs/lts
This is a backport of #5995. The commit applies almost cleanly (some context change), but I also want to start a test build and have a proper place for discussion.
Added the don't-land label to the original PR, please change if not appropriate.
I believe this should go into v4, but not sure about v0.12 and v0.10.