wasm: Revert enable JSPI as already enabled - #60014
Closed
guybedford wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
guybedford
force-pushed
the
disable-jspi
branch
from
ed56d7e to
c273e58
Compare
September 25, 2025 18:11
cjihrig
approved these changes
Sep 25, 2025
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #60014 +/- ##
==========================================
- Coverage 88.47% 88.46% -0.02%
==========================================
Files 703 703
Lines 207546 207545 -1
Branches 40006 40015 +9
==========================================
- Hits 183631 183601 -30
- Misses 15907 15946 +39
+ Partials 8008 7998 -10
... and 31 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
lpinca
approved these changes
Sep 25, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
anonrig
approved these changes
Sep 25, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Sep 28, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
guybedford
added a commit
that referenced
this pull request
Oct 1, 2025
PR-URL: #60014 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #59941, while keeping the test for good measure.
It turns out JSPI is already enabled on latest V8, I was just not carefully testing this between different versions.
#59941 should be considered fully reverted and backed out with this change.