wasm: enable JSPI - #59941
Closed
guybedford wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
jasnell
approved these changes
Sep 20, 2025
jasnell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Lgtm but the test could use a comment that explains the expectations a bit as most folks aren't familiar with jspi yet and won't have much context.
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #59941 +/- ##
==========================================
+ Coverage 88.25% 88.44% +0.19%
==========================================
Files 703 703
Lines 207412 207402 -10
Branches 39893 39991 +98
==========================================
+ Hits 183052 183445 +393
+ Misses 16313 15930 -383
+ Partials 8047 8027 -20
... and 41 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
anonrig
approved these changes
Sep 20, 2025
lpinca
approved these changes
Sep 20, 2025
Copy link
Copy Markdown
Contributor
Author
|
Sure, I've added some more documentation to the test. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
guybedford
added a commit
that referenced
this pull request
Sep 23, 2025
PR-URL: #59941 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
9 tasks
guybedford
added a commit
to guybedford/node
that referenced
this pull request
Aug 7, 2026
PR-URL: nodejs#59941 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
to guybedford/node
that referenced
this pull request
Aug 13, 2026
PR-URL: nodejs#59941 Backport-PR-URL: nodejs#65123 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot
added a commit
that referenced
this pull request
Aug 21, 2026
Notable changes: async_hooks: * (SEMVER-MINOR) add using scopes to AsyncLocalStorage (Stephen Belanger) #61674 benchmark: * (SEMVER-MINOR) add benchmarks for experimental stream/iter (James M Snell) #62066 buffer: * (SEMVER-MINOR) add end parameter (Robert Nagy) #62390 crypto: * update root certificates to NSS 3.125 (Node.js GitHub Bot) #64746 doc: * add MikeMcC399 as collaborator (Mike McCready) #64656 lib,permission: * (SEMVER-MINOR) add permission.drop (Rafael Gonzaga) #62672 loader: * (SEMVER-MINOR) implement package maps (Maël Nison) #62239 src,permission: * (SEMVER-MINOR) add --permission-audit (RafaelGSS) #61869 stream: * (SEMVER-MINOR) add stream/iter Implementation (James M Snell) #62066 test: * (SEMVER-MINOR) add tests for experimental stream/iter implementation (James M Snell) #62066 test_runner: * (SEMVER-MINOR) add context.log() and test:log event (Moshe Atlow) #64389 * (SEMVER-MINOR) report `entryFile` in `TestStream` events (Moshe Atlow) #64309 wasm: * (SEMVER-MINOR) enable JSPI (Guy Bedford) #59941 PR-URL: #65461
aduh95
pushed a commit
that referenced
this pull request
Aug 22, 2026
Notable changes: async_hooks: * (SEMVER-MINOR) add `using` scopes to `AsyncLocalStorage` (Stephen Belanger) #61674 benchmark: buffer: * (SEMVER-MINOR) add `end` parameter (Robert Nagy) #62390 crypto: * update root certificates to NSS 3.125 (Node.js GitHub Bot) #64746 doc: * add MikeMcC399 as collaborator (Mike McCready) #64656 lib,permission: * (SEMVER-MINOR) add `permission.drop` (Rafael Gonzaga) #62672 loader: * (SEMVER-MINOR) implement package maps (Maël Nison) #62239 src,permission: * (SEMVER-MINOR) add `--permission-audit` (RafaelGSS) #61869 stream: * (SEMVER-MINOR) implement `node:stream/iter` (James M Snell) #62066 test_runner: * (SEMVER-MINOR) add `context.log()` and `test:log` event (Moshe Atlow) #64389 * (SEMVER-MINOR) report `entryFile` in `TestStream` events (Moshe Atlow) #64309 wasm: * (SEMVER-MINOR) enable JSPI (Guy Bedford) #59941 PR-URL: #65461
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the WebAssembly JS Promise Integration Stage 4 WebAssembly proposal which is currently shipped in Chrome.
A new Wasm test is also included to verify that it works correctly.