[v24.x backport] wasm: enable JSPI - #65123
Merged
aduh95 merged 1 commit intoAug 13, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
jasnell
approved these changes
Aug 7, 2026
aduh95
approved these changes
Aug 7, 2026
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## v24.x-staging #65123 +/- ##
=================================================
+ Coverage 89.92% 90.31% +0.38%
=================================================
Files 686 711 +25
Lines 208389 228281 +19892
Branches 40077 43137 +3060
=================================================
+ Hits 187387 206162 +18775
- Misses 13238 14072 +834
- Partials 7764 8047 +283
... and 302 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
PR-URL: nodejs#59941 Backport-PR-URL: nodejs#65123 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports #59941 to Node.js 24, enabling WebAssembly Promise Integration (JSPI). While this was reverted on the v25+ lines due to V8 already enabling the feature, it is very much needed on the v24.x lines, and enabling it will significantly improve compatibility.
PR-URL: #59941
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com