test: deflake test-fs-promises-watch-iterator by lpinca · Pull Request #60060 · nodejs/node · GitHub

Add a delay before writing the files to ensure that the watcher receives the notifications.

If there was a reason for this I will add it back, but I don't see it.

The same is done in other fs.watch() tests, for example:

node/test/parallel/test-fs-watch-recursive-add-file.js

Lines 41 to 44 in c6316f9

    
           // Do the write with a delay to ensure that the OS is ready to notify us. 
        
           setTimeout(() => { 
        
             fs.writeFileSync(testFile, 'world'); 
        
           }, common.platformTimeout(200));

I think this deserves a TODO to investigate why this is occuring and whether or not this is a bug.

There already an open issue (#52601) linked in the commit message.

Thank you!

lgtm

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.45%. Comparing base (6f941fc) to head (dfdbb39).
⚠️ Report is 59 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #60060      +/-   ##
==========================================
- Coverage   88.45%   88.45%   -0.01%     
==========================================
  Files         703      703              
  Lines      207826   207826              
  Branches    40030    40038       +8     
==========================================
- Hits       183842   183826      -16     
+ Misses      15973    15972       -1     
- Partials     8011     8028      +17

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Add a delay before writing the files to ensure that the watcher receives the notifications. Fixes: nodejs#60051 Refs: nodejs#52601

Rebased, this needs new approvals.

CI: https://ci.nodejs.org/job/node-test-pull-request/69559/

Landed in f8a43f6

Add a delay before writing the files to ensure that the watcher receives the notifications. Fixes: #60051 Refs: #52601 PR-URL: #60060 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Refs: nodejs#60060

Refs: nodejs#60060 PR-URL: nodejs#61532 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>

Refs: #60060 PR-URL: #61532 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>

Add a delay before writing the files to ensure that the watcher receives the notifications. Fixes: #60051 Refs: #52601 PR-URL: #60060 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Refs: #60060 PR-URL: #61532 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 28, 2025

lpinca commented Sep 28, 2025

View reviewed changes

addaleax approved these changes Sep 28, 2025

View reviewed changes

gurgunday approved these changes Sep 28, 2025

View reviewed changes

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2025

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2025

This comment was marked as outdated.

Sign in to view

gurgunday added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 1, 2025

This comment was marked as outdated.

Sign in to view

test: deflake test-fs-promises-watch-iterator

dfdbb39

Add a delay before writing the files to ensure that the watcher receives the notifications. Fixes: nodejs#60051 Refs: nodejs#52601

lpinca force-pushed the deflake/test-fs-promises-watch-iterator branch from d3b5d31 to dfdbb39 Compare October 4, 2025 10:13

This comment was marked as outdated.

Sign in to view

lpinca added the review wanted PRs that need reviews. label Oct 8, 2025

joyeecheung approved these changes Oct 8, 2025

View reviewed changes

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2025

nodejs-github-bot merged commit f8a43f6 into nodejs:main Oct 9, 2025
60 checks passed

lpinca deleted the deflake/test-fs-promises-watch-iterator branch October 9, 2025 05:38

RafaelGSS mentioned this pull request Oct 13, 2025

2025-10-15, Version 25.0.0 (Current) #59896

Merged

9 tasks

github-actions Bot mentioned this pull request Nov 7, 2025

2025-11-11, Version 24.12.0 'Krypton' (LTS) #60615

Closed

github-actions Bot mentioned this pull request Nov 7, 2025

2025-11-11, Version 24.11.1 'Krypton' (LTS) #60622

Merged

lpinca added a commit to lpinca/node that referenced this pull request Jan 26, 2026

test: delay writing the files only on macOS

489a266

Refs: nodejs#60060

lpinca mentioned this pull request Jan 26, 2026

test: delay writing the files only on macOS #61532

Merged

pull Bot pushed a commit to Rashworld786/node that referenced this pull request Jan 28, 2026

test: delay writing the files only on macOS

a9dd48f

Refs: nodejs#60060 PR-URL: nodejs#61532 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>

aduh95 pushed a commit that referenced this pull request Jan 28, 2026

test: delay writing the files only on macOS

6fbb0b7

Refs: #60060 PR-URL: #61532 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>

aduh95 pushed a commit that referenced this pull request Feb 3, 2026

test: delay writing the files only on macOS

e4a7922

Refs: #60060 PR-URL: #61532 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>

aduh95 pushed a commit that referenced this pull request Feb 6, 2026

test: delay writing the files only on macOS

0035f3f

Refs: #60060 PR-URL: #61532 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>

aduh95 pushed a commit that referenced this pull request Feb 17, 2026

test: delay writing the files only on macOS

65248d9

Refs: #60060 PR-URL: #61532 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>

aduh95 pushed a commit that referenced this pull request Feb 19, 2026

test: delay writing the files only on macOS

275d3dd

Refs: #60060 PR-URL: #61532 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>

aduh95 pushed a commit that referenced this pull request Feb 21, 2026

test: delay writing the files only on macOS

3261ee5

Refs: #60060 PR-URL: #61532 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>

aduh95 pushed a commit that referenced this pull request Feb 21, 2026

test: delay writing the files only on macOS

2419284

Refs: #60060 PR-URL: #61532 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>

aduh95 mentioned this pull request Feb 22, 2026

V22.22.1 proposal #61947

Merged

aduh95 pushed a commit that referenced this pull request Feb 23, 2026

test: delay writing the files only on macOS

16c69f5

Refs: #60060 PR-URL: #61532 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>

aduh95 pushed a commit that referenced this pull request Feb 24, 2026

test: delay writing the files only on macOS

5fba382

Refs: #60060 PR-URL: #61532 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>

                   for (const fileName of [...this.files]) {
                     await writeFile(this.filePath(fileName), Date.now() + fileName.repeat(1e4));
                   }
-                  await setTimeout(common.platformTimeout(100));

		// Do the write with a delay to ensure that the OS is ready to notify us.
		await setTimeout(common.platformTimeout(100));

	// Do the write with a delay to ensure that the OS is ready to notify us.
	setTimeout(() => {
	fs.writeFileSync(testFile, 'world');
	}, common.platformTimeout(200));

test: deflake test-fs-promises-watch-iterator by lpinca · Pull Request #60060 · nodejs/node · GitHub

Uh oh!

Uh oh!

test: deflake test-fs-promises-watch-iterator - #60060

test: deflake test-fs-promises-watch-iterator#60060nodejs-github-bot merged 1 commit intonodejs:mainnodejs/node:mainfrom lpinca:deflake/test-fs-promises-watch-iteratorlpinca/node:deflake/test-fs-promises-watch-iteratorCopy head branch name to clipboard

Conversation

lpinca commented Sep 28, 2025

Uh oh!

lpinca Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lpinca Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anonrig Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

lpinca Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

gurgunday left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

lpinca commented Oct 4, 2025

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Oct 4, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

test: deflake test-fs-promises-watch-iterator#60060
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:deflake/test-fs-promises-watch-iterator

lpinca Sep 28, 2025 •
edited
Loading

lpinca Sep 28, 2025 •
edited
Loading

codecov Bot commented Sep 28, 2025 •
edited
Loading