FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: delay writing the files only on macOS by lpinca · Pull Request #61532 · nodejs/node · GitHub

/ node Public

test: delay writing the files only on macOS - #61532

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:delay/writing-only-on-macos
Jan 28, 2026
ConversationCommits (1)ChecksFiles changed
Merged

test: delay writing the files only on macOS#61532
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:delay/writing-only-on-macos

Conversation

lpinca commented Jan 26, 2026

Copy link
Copy Markdown
Member

Refs: #60060

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 26, 2026
juanarbol approved these changes Jan 26, 2026
View reviewed changes

juanarbol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

codecov Bot commented Jan 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.77%. Comparing base (c1402c6) to head (489a266).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61532      +/-   ##
==========================================
- Coverage   89.77%   89.77%   -0.01%     
==========================================
  Files         672      672              
  Lines      203930   203809     -121     
  Branches    39207    39186      -21     
==========================================
- Hits       183082   182973     -109     
+ Misses      13175    13170       -5     
+ Partials     7673     7666       -7

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 27, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 27, 2026

nodejs-github-bot commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71057/

nodejs-github-bot commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71061/

jakecastelli added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 27, 2026
lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 28, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 28, 2026
nodejs-github-bot merged commit a9dd48f into nodejs:main Jan 28, 2026
79 of 81 checks passed

nodejs-github-bot commented Jan 28, 2026

Copy link
Copy Markdown
Collaborator

Landed in a9dd48f

lpinca deleted the delay/writing-only-on-macos branch January 28, 2026 17:43
aduh95 pushed a commit that referenced this pull request Jan 28, 2026
test: delay writing the files only on macOS
6fbb0b7 
Refs: #60060
PR-URL: #61532
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
github-actions Bot mentioned this pull request Feb 2, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 3, 2026
test: delay writing the files only on macOS
e4a7922 
Refs: #60060
PR-URL: #61532
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
github-actions Bot mentioned this pull request Feb 3, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 6, 2026
test: delay writing the files only on macOS
0035f3f 
Refs: #60060
PR-URL: #61532
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 17, 2026
test: delay writing the files only on macOS
65248d9 
Refs: #60060
PR-URL: #61532
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 19, 2026
test: delay writing the files only on macOS
275d3dd 
Refs: #60060
PR-URL: #61532
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 21, 2026
test: delay writing the files only on macOS
3261ee5 
Refs: #60060
PR-URL: #61532
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 21, 2026
test: delay writing the files only on macOS
2419284 
Refs: #60060
PR-URL: #61532
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 mentioned this pull request Feb 22, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 23, 2026
test: delay writing the files only on macOS
16c69f5 
Refs: #60060
PR-URL: #61532
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 24, 2026
test: delay writing the files only on macOS
5fba382 
Refs: #60060
PR-URL: #61532
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

juanarbol juanarbol approved these changes
jakecastelli jakecastelli approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL