FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v20.x] doc: support toolchain with Visual Studio 2019 & 2022 only by MikeMcC399 · Pull Request #61450 · nodejs/node · GitHub

/ node Public

[v20.x] doc: support toolchain with Visual Studio 2019 & 2022 only - #61450

Closed
MikeMcC399 wants to merge 1 commit into
nodejs:v20.x-stagingfrom
MikeMcC399:v20.x-visual-studio-2022
Closed

[v20.x] doc: support toolchain with Visual Studio 2019 & 2022 only#61450
MikeMcC399 wants to merge 1 commit into
nodejs:v20.x-stagingfrom
MikeMcC399:v20.x-visual-studio-2022

Conversation

MikeMcC399 commented Jan 20, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Refs: #60869
Refs: #61449

Situation

The Supported toolchains section for v20.x lists Visual Studio >= 2019 with the Windows 10 SDK on a 64-bit host.

By implication, this includes also the latest release of Microsoft Visual Studio which is Visual Studio 2026.

.\vcbuild fails to run in the v20.x branch on Windows 11 25H2 in a PowerShell terminal with the Windows Prerequisites installed, and only using Visual Studio Build Tools 2026.

Support for Visual Studio Build Tools 2026 requires a minimum of gyp-next@0.21.0.

The Node.js v20.x branch includes gyp-next@0.16.2 in v20.x/tools/gyp and so lacks support for Visual Studio 2026.

Failure log

 .\vcbuild
Looking for Python
Python found in C:\Users\mikem\AppData\Local\Microsoft\WindowsApps\\python.exe
Python 3.14.2
Looking for NASM
Looking for Visual Studio 2022
Looking for Visual Studio 2019
Failed to find a suitable Visual Studio installation.
Try to run in a "Developer Command Prompt" or consult
https://github.com/nodejs/node/blob/HEAD/BUILDING.md#windows

Change

In BUILDING.md

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/build
  • @nodejs/tsc

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. v20.x labels Jan 20, 2026
MikeMcC399 marked this pull request as ready for review January 20, 2026 12:39
StefanStojanovic added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 5, 2026

Copy link
Copy Markdown
Contributor Author

@StefanStojanovic

Thanks for your support and follow-up! I think commit-queue Add this label to land a pull request using GitHub Actions. only works for PRs targeting the main branch (see Commit Queue), so I would expect that this PR would need to be manually picked up by the Releasers / Backporters team.

This comment was marked as outdated.

MikeMcC399 changed the title [v20.x] doc: supported toolchain with Visual Studio 2019 & 2022 only [v20.x] doc: support toolchain with Visual Studio 2019 & 2022 only Feb 25, 2026
MikeMcC399 force-pushed the v20.x-visual-studio-2022 branch from 0b906d4 to 4de61c7 Compare February 25, 2026 10:52

Copy link
Copy Markdown
Contributor Author

Modified commit message to use imperative verb and rebased

MikeMcC399 force-pushed the v20.x-visual-studio-2022 branch from 4de61c7 to 531ba50 Compare February 28, 2026 15:10
marco-ippolito pushed a commit that referenced this pull request Mar 2, 2026
PR-URL: #61450
Refs: #60869
Refs: #61449
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Copy link
Copy Markdown
Member

Landed in 0f4ffc0

MikeMcC399 deleted the v20.x-visual-studio-2022 branch March 2, 2026 14:02
marco-ippolito pushed a commit that referenced this pull request Mar 3, 2026
PR-URL: #61450
Refs: #60869
Refs: #61449
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Flarna removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL