FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: Clarify supported Visual Studio versions for windows by Prof2807 · Pull Request #61694 · nodejs/node · GitHub

/ node Public

doc: Clarify supported Visual Studio versions for windows - #61694

Closed
Prof2807 wants to merge 1 commit into
nodejs:mainfrom
Prof2807:doc-fix-VisualStudio-versions
Closed

doc: Clarify supported Visual Studio versions for windows#61694
Prof2807 wants to merge 1 commit into
nodejs:mainfrom
Prof2807:doc-fix-VisualStudio-versions

Conversation

Prof2807 commented Feb 5, 2026

Copy link
Copy Markdown

The current documentation uses ">=" which implies that any future version of Visual Studio will work. However, VS 2026 has been shown to cause build failures on certain branches. This change explicitly lists 2022 and 2026 as the supported versions to prevent user confusion.

Fixes: #61449

The current documentation uses ">=" which implies that any future
version of Visual Studio will work. However, VS 2026 has been
shown to cause build failures on certain branches. This change
explicitly lists 2022 and 2026 as the supported versions to
prevent user confusion.

Fixes: nodejs#61449

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/build
  • @nodejs/tsc

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Feb 5, 2026

MikeMcC399 commented Feb 5, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

I was actually waiting for the backport of

Refs: #61530
Refs: #60727

before proposing any change. At the moment the text is accurate. It needs some investigation though about future versions because Visual Studio updates are changing into in-place rather than side-by-side starting in Nov 2026.

I suggest to hold back on this PR for the moment or you can defer to me, as the author of the issue #61449 which I am still actively working on.

Also the branches where 2026 doesn't work, and are not planned to be compatible with the 2026, are covered specifically by

Refs: #61450
Refs: #61451

My tendency at the moment in any case is not to change the text, since it is currently correct. So I suggest to close this PR.

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor

@Prof2807

I would appreciate it if you would remove the line

Fixes: #61449

from your PR as it would automatically close my issue #61449 although your PR does not resolve all issues for all actively supported branches mentioned in the issue.

Since there are multiple aspects for Visual Studio 2026 support that I am currently handling in multiple related PRs, some of which I have not yet submitted, because of interdependencies, it may be simpler if you just close this PR. Otherwise we will need to coordinate our submissions step by step.

If you do leave this PR open, then you will need to reformat the table you have edited, as it fails linting.

I would also suggest updating the title / commit message to something more specific, such as

"doc: supported toolchain with Visual Studio 2022 & 2026 only"

The current title would provide little information in the change logs.

MikeMcC399 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please note my above comments

Prof2807 commented Feb 6, 2026

Copy link
Copy Markdown
Author

Thanks for the feedback, Mike. I didn't realize you were already managing a coordinated set of PRs for this. I'll close this now to avoid any conflicts and let you handle it through issue #61449.

Prof2807 closed this Feb 6, 2026

Copy link
Copy Markdown
Contributor

@Prof2807

Thank you for closing this PR! You can be sure that I will be following up, however due to the release cycles it may take another month, as I would like to make sure that all prerequisite changes are in place so that any PR can also be backported without problems.

I am quite new to contributing to this repo, however what I have learned is:

  • issues are not assigned to anybody
  • if you want to avoid clashes regarding an issue that somebody else has posted and you would like to submit a PR to resolve the issue, then first post into the issue, declare your intentions and wait a little bit before proceeding with any PR submission

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc: missing highest compatible Microsoft Visual Studio version

3 participants


Back | FazBrowse Home | New Git URL