buffer: remove unused param from copyActual - #62042
Closed
gurgunday wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
This change is being made as part of #62032. |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #62042 +/- ##
==========================================
+ Coverage 89.58% 89.64% +0.06%
==========================================
Files 674 676 +2
Lines 205159 206240 +1081
Branches 39352 39506 +154
==========================================
+ Hits 183792 184894 +1102
+ Misses 13583 13465 -118
- Partials 7784 7881 +97
... and 129 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@richardlau PTAL, that PR is closed for now |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/22575987214 |
Sorry, something went wrong.
ChALkeR
approved these changes
Apr 26, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@gurgunday Can you please resolve conflicts and force push? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
It's resolved |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #61721
We added this quirky parameter in #60399 when implementing an optimization to Buffer.concat and Buffer.copy with the intention of eventually removing it when .concat used TypedArrayPrototypeSet in all cases
The parameter was only used in one place until it was removed in #61721:
https://github.com/nodejs/node/pull/61721/changes#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630L635