FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: fix unclosed link in Test Runner documentation by KJyang-0114 · Pull Request #62168 · nodejs/node · GitHub

/ node Public

docs: fix unclosed link in Test Runner documentation - #62168

Closed
KJyang-0114 wants to merge 3 commits into
nodejs:mainfrom
KJyang-0114:fix/unclosed-link-test-docs
Closed

docs: fix unclosed link in Test Runner documentation#62168
KJyang-0114 wants to merge 3 commits into
nodejs:mainfrom
KJyang-0114:fix/unclosed-link-test-docs

Conversation

Copy link
Copy Markdown

Problem

There is an unclosed link tag in the Test Runner documentation (). This causes all text after the link to be underlined and clickable in the rendered HTML.

The issue was reported in: #62154

Root Cause

Line 291-294 had incorrect markdown: [<RegExp>] instead of [RegExp]. The extra < at the beginning of each link text breaks the link parsing.

Fix

Removed the stray < characters from the link text:

  • [<RegExp>] → [RegExp]
  • [<Function>] → [Function]
  • [<Object>] → [Object]
  • [<Error>] → [Error]

Testing

  • Documentation builds without errors (markdown lint not applicable for .md files in doc/api/)
  • This is a documentation-only fix, no code changes
  • Manually verified the fix by checking the rendered HTML would no longer have the unclosed link issue

Checklist

  • Minimal change (only fixed the broken links)
  • No new lint warnings (documentation-only)
  • Commit message follows repo conventions

When coverage threshold is not met, the dot reporter now outputs
the error message so users can understand why tests failed.

Refs: #60884
Add documentation explaining how to mock functions that throw errors
and validate them using assert.throws(). Includes examples showing
how mock tracks both successful calls and thrown errors.

PR-URL: #52358
Refs: #52357
Fixes an unclosed link tag that causes all text after it to be
underlined and clickable in the HTML documentation.

Before: [<RegExp>]
After: [RegExp]

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Mar 9, 2026

efekrskl commented Mar 9, 2026

Copy link
Copy Markdown
Member

Thanks for your contribution!

However this PR contains unrelated changes, and the linked issue is already resolved by #62100

Copy link
Copy Markdown
Member

Yes, this was already fixed.

Thanks but closing as a duplicate.

JakobJingleheimer added the duplicate Issues and PRs that are duplicates of other issues or PRs. label Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate Issues and PRs that are duplicates of other issues or PRs. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL