build: fix stray debug string in LIEF defines - #62683
Merged
nodejs-github-bot merged 1 commit intoApr 13, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
A stray debug string 'testtttt' in lief.gyp's defines list was missing a trailing comma, causing it to be concatenated with the adjacent MBEDTLS_CONFIG_FILE define via implicit string concatenation. This resulted in the compiler receiving: -DtestttttMBEDTLS_CONFIG_FILE="config/mbedtls/config.h" instead of: -DMBEDTLS_CONFIG_FILE="config/mbedtls/config.h" Remove the stray string so that MBEDTLS_CONFIG_FILE is defined correctly. Refs: nodejs#62129
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
joyeecheung
approved these changes
Apr 13, 2026
richardlau
approved these changes
Apr 13, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Apr 13, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
May 5, 2026
A stray debug string 'testtttt' in lief.gyp's defines list was missing a trailing comma, causing it to be concatenated with the adjacent MBEDTLS_CONFIG_FILE define via implicit string concatenation. This resulted in the compiler receiving: -DtestttttMBEDTLS_CONFIG_FILE="config/mbedtls/config.h" instead of: -DMBEDTLS_CONFIG_FILE="config/mbedtls/config.h" Remove the stray string so that MBEDTLS_CONFIG_FILE is defined correctly. Refs: #62129 PR-URL: #62683 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced May 5, 2026
aduh95
pushed a commit
to himself65/node
that referenced
this pull request
May 7, 2026
A stray debug string 'testtttt' in lief.gyp's defines list was missing a trailing comma, causing it to be concatenated with the adjacent MBEDTLS_CONFIG_FILE define via implicit string concatenation. This resulted in the compiler receiving: -DtestttttMBEDTLS_CONFIG_FILE="config/mbedtls/config.h" instead of: -DMBEDTLS_CONFIG_FILE="config/mbedtls/config.h" Remove the stray string so that MBEDTLS_CONFIG_FILE is defined correctly. Refs: nodejs#62129 PR-URL: nodejs#62683 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A stray debug string 'testtttt' in lief.gyp's defines list was missing
a trailing comma, causing it to be concatenated with the adjacent
MBEDTLS_CONFIG_FILE define via GYP's implicit string concatenation.
Current (broken): -DtestttttMBEDTLS_CONFIG_FILE="config/mbedtls/config.h"
Expected (fixed): -DMBEDTLS_CONFIG_FILE="config/mbedtls/config.h"
This means mbedtls was never receiving its intended config file path. Remove
the stray string so MBEDTLS_CONFIG_FILE is defined correctly.
Risk
Fixing this define may change mbedtls behavior if it was previously falling
back to a default config. Reviewers should verify that
config/mbedtls/config.h is the correct config path and that LIEF's mbedtls
usage works correctly with it.
Related: PR #62682 addresses the duplicate C++ standard flags in the same file.
Refs: #62129