FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

v8: add cpu profile options by IlyasShabi · Pull Request #62684 · nodejs/node · GitHub

/ node Public

v8: add cpu profile options - #62684

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
IlyasShabi:ishabi/cpu-profile-options
Apr 26, 2026
ConversationCommits (1)ChecksFiles changed
Merged

v8: add cpu profile options#62684
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
IlyasShabi:ishabi/cpu-profile-options

Conversation

IlyasShabi commented Apr 10, 2026

Copy link
Copy Markdown
Member

Add options support to v8.startCpuProfile() and worker.startCpuProfile():

  • sampleInterval: requested sampling interval in milliseconds
  • maxBufferSize: maximum number of samples to retain

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 10, 2026
IlyasShabi added the v8 module Issues and PRs related to the "v8" subsystem. label Apr 10, 2026
IlyasShabi marked this pull request as ready for review April 10, 2026 21:54

codecov Bot commented Apr 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.52336% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.68%. Comparing base (8c3cf47) to head (ad99597).
⚠️ Report is 179 commits behind head on main.

Files with missing lines Patch % Lines
src/util.cc 58.33% 0 Missing and 5 partials ⚠️
lib/internal/v8/cpu_profiler.js 94.64% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #62684      +/-   ##
==========================================
- Coverage   91.54%   89.68%   -1.87%     
==========================================
  Files         355      707     +352     
  Lines      149296   218221   +68925     
  Branches    23371    41747   +18376     
==========================================
+ Hits       136678   195712   +59034     
- Misses      12353    14417    +2064     
- Partials      265     8092    +7827
Files with missing lines Coverage Δ
lib/internal/worker.js 96.65% <100.00%> (+0.17%) ⬆️
lib/v8.js 98.77% <100.00%> (+0.02%) ⬆️
src/env.cc 85.24% <100.00%> (ø)
src/env.h 98.14% <ø> (ø)
src/node_v8.cc 82.15% <100.00%> (ø)
src/node_worker.cc 82.12% <100.00%> (ø)
src/util.h 91.40% <100.00%> (ø)
lib/internal/v8/cpu_profiler.js 94.64% <94.64%> (ø)
src/util.cc 86.53% <58.33%> (ø)

... and 473 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

IlyasShabi marked this pull request as draft April 12, 2026 17:54
IlyasShabi force-pushed the ishabi/cpu-profile-options branch from d360041 to ff06537 Compare April 12, 2026 18:32
IlyasShabi marked this pull request as ready for review April 12, 2026 18:49
IlyasShabi force-pushed the ishabi/cpu-profile-options branch from ff06537 to c49027e Compare April 14, 2026 09:31
IlyasShabi force-pushed the ishabi/cpu-profile-options branch from c49027e to ad99597 Compare April 14, 2026 13:05

IlyasShabi commented Apr 20, 2026

Copy link
Copy Markdown
Member Author

@Qard @jasnell Could you take a look please?

IlyasShabi added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2026

nodejs-github-bot commented Apr 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72929/

gurgunday added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 26, 2026
theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2026

nodejs-github-bot commented Apr 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72931/

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2026

nodejs-github-bot commented Apr 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72932/

IlyasShabi added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2026
nodejs-github-bot merged commit 4e332e0 into nodejs:main Apr 26, 2026
75 checks passed

nodejs-github-bot commented Apr 26, 2026

Copy link
Copy Markdown
Collaborator

Landed in 4e332e0

aduh95 pushed a commit that referenced this pull request May 5, 2026
v8: add cpu profile options
c1d6b3d 
PR-URL: #62684
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
aduh95 mentioned this pull request May 5, 2026
Merged
aduh95 added the backport-requested-v24.x PRs awaiting manual backport to the v24.x-staging branch. label May 9, 2026

aduh95 commented May 9, 2026

Copy link
Copy Markdown
Contributor

This would require a manual backport PR along #62273 if we want it on Node.js 24

aduh95 mentioned this pull request May 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Qard Qard approved these changes
theanarkh theanarkh approved these changes
jasnell Awaiting requested review from jasnell

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. backport-requested-v24.x PRs awaiting manual backport to the v24.x-staging branch. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v8 module Issues and PRs related to the "v8" subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL