FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: fix ffi dependency compilation by ShogunPanda · Pull Request #62731 · nodejs/node · GitHub

/ node Public

build: fix ffi dependency compilation - #62731

Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
ShogunPanda:ffi-compile
Apr 15, 2026
ConversationCommits (4)ChecksFiles changed
Merged

build: fix ffi dependency compilation#62731
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
ShogunPanda:ffi-compile

Conversation

ShogunPanda commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This fix a little build regression introduced in #62072.

build: fix ffi dependency compilation
3418d7e 
Signed-off-by: Paolo Insogna <paolo@cowtech.it>

nodejs-github-bot commented Apr 14, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg

nodejs-github-bot added build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Apr 14, 2026
ShogunPanda added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 14, 2026

github-actions Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @ShogunPanda. Please 👍 to approve.

aduh95 commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

I'm still getting an error when building with --shared-ffi on macOS:

../../src/node_metadata.cc:176:12: error: use of undeclared identifier 'FFI_VERSION_STRING'
  176 |   libffi = FFI_VERSION_STRING;
      |            ^~~~~~~~~~~~~~~~~~

ShogunPanda commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

@aduh95 That might happen if you have a local libffi lower than 3.5.x. Can you please verify that?

fixup
8305199 
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
aduh95 mentioned this pull request Apr 14, 2026
Merged

aduh95 commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

@aduh95 That might happen if you have a local libffi lower than 3.5.x. Can you please verify that?

Yeah we have it set to an Apple fork that's on version 3.4.1-rc for some reason. I've opened #62737 to fix that, I've confirmed locally it does build on top of this PR.

mcollina approved these changes Apr 14, 2026
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2026

nodejs-github-bot commented Apr 14, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72691/

fixup
9467757 
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
fixup
c68e4f7 
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
shrujalshah28 mentioned this pull request Apr 15, 2026
Closed
mertcanaltin mentioned this pull request Apr 15, 2026
Closed

nodejs-github-bot commented Apr 15, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72699/

nodejs-github-bot commented Apr 15, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72700/

ShogunPanda added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 15, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 15, 2026
nodejs-github-bot merged commit 3f52482 into nodejs:main Apr 15, 2026
65 checks passed

nodejs-github-bot commented Apr 15, 2026

Copy link
Copy Markdown
Collaborator

Landed in 3f52482

ShogunPanda deleted the ffi-compile branch April 15, 2026 11:07
addaleax added the ffi Issues and PRs related to experimental Foreign Function Interface support. label Apr 20, 2026
aduh95 pushed a commit that referenced this pull request May 5, 2026
build: fix ffi dependency compilation
d8f97e6 
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
PR-URL: #62731
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 mentioned this pull request May 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
bengl bengl approved these changes
panva panva approved these changes
aduh95 aduh95 approved these changes
atlowChemi atlowChemi approved these changes
+1 more reviewer
mertcanaltin mertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dependencies Pull requests that update a dependency file. fast-track PRs that do not need to wait for 48 hours to land. ffi Issues and PRs related to experimental Foreign Function Interface support. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL