tools: pass the Temporal disable flag when disabled in shell.nix - #62733
Merged
nodejs-github-bot merged 1 commit intoApr 16, 2026
Merged
tools: pass the Temporal disable flag when disabled in shell.nix#62733nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Renegade334
approved these changes
Apr 14, 2026
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Should we make withTemporal default to true, à la withSSL etc?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Eventually for sure; it might make sense to wait for the V8 update to land first |
Sorry, something went wrong.
panva
approved these changes
Apr 15, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
force-pushed
the
shell.nix-without-temporal
branch
from
d7eab38 to
afeed62
Compare
April 15, 2026 09:26
legendecas
approved these changes
Apr 15, 2026
aduh95
added a commit
that referenced
this pull request
May 5, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #62733 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #61806