src: simplify and fix FFI ArrayBuffer accesses - #62857
Merged
nodejs-github-bot merged 2 commits intoApr 22, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
`ArrayBufferViewContents` supports `ArrayBuffer`s, so we do not need to provide special treatment for those. Also, small typed arrays may not have backing stores until their corresponding `ArrayBuffer`s are accessed, so do that in order to avoid accidentally accessing arbitrary stack memory. Signed-off-by: Anna Henningsen <anna@addaleax.net>
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #62857 +/- ##
==========================================
- Coverage 89.64% 89.62% -0.03%
==========================================
Files 706 706
Lines 219137 219124 -13
Branches 41999 41981 -18
==========================================
- Hits 196453 196386 -67
- Misses 14574 14619 +45
- Partials 8110 8119 +9
... and 30 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
ShogunPanda
approved these changes
Apr 21, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
daeyeon
approved these changes
Apr 21, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
May 5, 2026
`ArrayBufferViewContents` supports `ArrayBuffer`s, so we do not need to provide special treatment for those. Also, small typed arrays may not have backing stores until their corresponding `ArrayBuffer`s are accessed, so do that in order to avoid accidentally accessing arbitrary stack memory. Signed-off-by: Anna Henningsen <anna@addaleax.net> PR-URL: #62857 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArrayBufferViewContents supports ArrayBuffers, so we do not need to provide special treatment for those.
Also, small typed arrays may not have backing stores until their corresponding ArrayBuffers are accessed, so do that in order to avoid accidentally accessing arbitrary stack memory.