FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: add non-default OpenSSL versions to the test-shared workflow by panva · Pull Request #62862 · nodejs/node · GitHub

/ node Public

tools: add non-default OpenSSL versions to the test-shared workflow - #62862

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
panva:additional-openssl-in-shared
Apr 26, 2026
ConversationCommits (3)ChecksFiles changed
Merged

tools: add non-default OpenSSL versions to the test-shared workflow#62862
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
panva:additional-openssl-in-shared

Conversation

panva commented Apr 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Adds an additional OpenSSL shared-libraries matrix to test-shared.yml so PRs run against additional supported OpenSSL releases. No more waiting for a full CI to find out a crypto/TLS change is broken on another version 🙏.

  • build-openssl now uses a committed matrix in test-shared.yml, regenerated by the existing weekly nixpkgs-unstable updater so the pin bump and tested OpenSSL variants stay in sync in a single PR.
  • The updater derives the matrix from the pinned nixpkgs and https://endoflife.date, dropping EOL versions, versions missing from the pinned nixpkgs, while keeping ones that still have extended support such as 1.1.1.
  • SUPPORTED_OPENSSL_VERSION remains a manually maintained value in tools/nix/collect-openssl-matrix.sh, and drives per-entry continue-on-error in the autogenerated matrix so releases newer than what we explicitly support do not fail GHA.

panva requested a review from aduh95 April 21, 2026 08:27

nodejs-github-bot commented Apr 21, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Apr 21, 2026
panva added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Apr 21, 2026
panva marked this pull request as ready for review April 21, 2026 11:32

aduh95 commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Adding extra GHA workflows comes at the expense of spending more minutes to prepare security releases. We can skip the test-shared workflow on the private repo, but idk if it's worth it given that there are some path that we only run on that workflow.
That being said, there's certainly some value to run more variants on GHA, maybe we need to gate them behind github.repository == 'nodejs/node'

aduh95 reviewed Apr 21, 2026
View reviewed changes
Comment thread tools/nix/collect-openssl-matrix.sh Outdated

panva commented Apr 21, 2026

Copy link
Copy Markdown
Member Author

but idk if it's worth it given that there are some path that we only run on that workflow

The OpenSSL versions are a big gap. Since we don't/can't keep up with the versions in CI.

aduh95 reviewed Apr 21, 2026
View reviewed changes
Comment thread .github/workflows/test-shared.yml Outdated
aduh95 reviewed Apr 21, 2026
View reviewed changes
Comment thread .github/workflows/test-shared.yml
panva force-pushed the additional-openssl-in-shared branch from 8bab015 to 1311e12 Compare April 22, 2026 15:40
panva requested a review from richardlau April 22, 2026 15:41
aduh95 reviewed Apr 22, 2026
View reviewed changes
Comment thread .github/workflows/test-shared.yml Outdated
aduh95 reviewed Apr 22, 2026
View reviewed changes
Comment thread .github/workflows/test-shared.yml

aduh95 commented Apr 25, 2026

Copy link
Copy Markdown
Contributor

I did another pass at this PR, and tested aduh95@a01a6ef. Could you have a look, and feel free to pull it and/or adapt from it

panva force-pushed the additional-openssl-in-shared branch from bc5e7eb to 85900e8 Compare April 25, 2026 20:22

panva commented Apr 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

@aduh95 looks great, i pulled it in and lint-fixed it

panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2026
nodejs-github-bot merged commit 0f68423 into nodejs:main Apr 26, 2026
34 checks passed

nodejs-github-bot commented Apr 26, 2026

Copy link
Copy Markdown
Collaborator

Landed in 0f68423

panva deleted the additional-openssl-in-shared branch April 26, 2026 06:01
aduh95 mentioned this pull request Apr 26, 2026
Merged
aduh95 pushed a commit that referenced this pull request May 5, 2026
tools: add non-default OpenSSL versions to the test-shared workflow
027bef4 
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #62862
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 mentioned this pull request May 5, 2026
Merged

Renegade334 commented May 12, 2026

Copy link
Copy Markdown
Member
  • The updater derives the matrix from the pinned nixpkgs and https://endoflife.date, dropping EOL versions, versions missing from the pinned nixpkgs, while keeping ones that still have extended support such as 1.1.1.

So where are we with OpenSSL 1.x support? The conversation in #56733 was approaching whether to withdraw this for v24.x, whereas we appear to be upping our integration a year later?

panva mentioned this pull request May 12, 2026
Open
panva mentioned this pull request Jul 27, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig approved these changes
aduh95 aduh95 approved these changes
richardlau Awaiting requested review from richardlau

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL