FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: remove outdated comments in contextify by legendecas · Pull Request #62932 · nodejs/node · GitHub

/ node Public

src: remove outdated comments in contextify - #62932

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:contextify-comment
Apr 27, 2026
ConversationCommits (1)ChecksFiles changed
Merged

src: remove outdated comments in contextify#62932
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:contextify-comment

Conversation

legendecas commented Apr 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

With https://chromium-review.googlesource.com/c/v8/v8/+/7718821, there is no need for Node.js to detect a contextual store in ContextifyContext::PropertySetterCallback.

Refs: #61898

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Apr 24, 2026
legendecas added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Apr 24, 2026

codecov Bot commented Apr 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.65%. Comparing base (fcff458) to head (e641303).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #62932      +/-   ##
==========================================
- Coverage   91.48%   89.65%   -1.83%     
==========================================
  Files         356      706     +350     
  Lines      150602   219220   +68618     
  Branches    23709    42019   +18310     
==========================================
+ Hits       137777   196543   +58766     
- Misses      12554    14595    +2041     
- Partials      271     8082    +7811
Files with missing lines Coverage Δ
src/node_contextify.cc 82.68% <ø> (ø)

... and 469 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

addaleax added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 24, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 24, 2026

nodejs-github-bot commented Apr 24, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72912/

nodejs-github-bot commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72942/

legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 27, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 27, 2026
nodejs-github-bot merged commit 85ae4cd into nodejs:main Apr 27, 2026
100 checks passed

nodejs-github-bot commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

Landed in 85ae4cd

legendecas deleted the contextify-comment branch April 27, 2026 04:09
aduh95 pushed a commit that referenced this pull request May 5, 2026
src: remove outdated comments in contextify
d89f719 
PR-URL: #62932
Refs: #61898
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
aduh95 mentioned this pull request May 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
anonrig anonrig approved these changes
IlyasShabi IlyasShabi approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL