lib: add Temporal to frozen intrinsics by Renegade334 · Pull Request #63029 · nodejs/node · GitHub

No description provided.

Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.64%. Comparing base (8173251) to head (66cce03).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #63029      +/-   ##
==========================================
- Coverage   91.49%   89.64%   -1.85%     
==========================================
  Files         358      708     +350     
  Lines      151574   220389   +68815     
  Branches    23921    42263   +18342     
==========================================
+ Hits       138679   197570   +58891     
- Misses      12619    14655    +2036     
- Partials      276     8164    +7888

Files with missing lines	Coverage Δ
lib/internal/freeze_intrinsics.js	96.97% <100.00%> (+0.08%)	⬆️

... and 471 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

CI: https://ci.nodejs.org/job/node-test-pull-request/73025/

you may also want to include Temporal.Now

CI: https://ci.nodejs.org/job/node-test-pull-request/73031/

you may also want to include Temporal.Now

It's recursively covered by deepFreeze().

Right, but i meant, you'd want to extract all the static methods inside Temporal.Now to be available as primordials.

Right, but i meant, you'd want to extract all the static methods inside Temporal.Now

Those are recursively covered by deepFreeze:

node/lib/internal/freeze_intrinsics.js

Line 378 in 66054cc

ArrayPrototypeForEach(intrinsics, deepFreeze);

node/lib/internal/freeze_intrinsics.js

Lines 389 to 469 in 66054cc

    
             function deepFreeze(root) { 
        
               /** 
        
                * "innerDeepFreeze()" acts like "Object.freeze()", except that: 
        
                * 
        
                * To deepFreeze an object is to freeze it and all objects transitively 
        
                * reachable from it via transitive reflective property and prototype 
        
                * traversal. 
        
                */ 
        
               function innerDeepFreeze(node) { 
        
                 // Objects that we have frozen in this round. 
        
                 const freezingSet = new SafeSet(); 
        
                 // If val is something we should be freezing but aren't yet, 
        
                 // add it to freezingSet. 
        
                 function enqueue(val) { 
        
                   if (Object(val) !== val) { 
        
                     // ignore primitives 
        
                     return; 
        
                   } 
        
                   const type = typeof val; 
        
                   if (type !== 'object' && type !== 'function') { 
        
                     // NB: handle for any new cases in future 
        
                   } 
        
                   if (frozenSet.has(val) || freezingSet.has(val)) { 
        
                     // TODO: Use uncurried form 
        
                     // Ignore if already frozen or freezing 
        
                     return; 
        
                   } 
        
                   freezingSet.add(val); // TODO: Use uncurried form 
        
                 } 
        
                 function doFreeze(obj) { 
        
                   // Immediately freeze the object to ensure reactive 
        
                   // objects such as proxies won't add properties 
        
                   // during traversal, before they get frozen. 
        
                   // Object are verified before being enqueued, 
        
                   // therefore this is a valid candidate. 
        
                   // Throws if this fails (strict mode). 
        
                   ObjectFreeze(obj); 
        
                   // We rely upon certain commitments of Object.freeze and proxies here 
        
                   // Get stable/immutable outbound links before a Proxy has a chance to do 
        
                   // something sneaky. 
        
                   const proto = ObjectGetPrototypeOf(obj); 
        
                   const descs = ObjectGetOwnPropertyDescriptors(obj); 
        
                   enqueue(proto); 
        
                   ArrayPrototypeForEach(ReflectOwnKeys(descs), (name) => { 
        
                     const desc = descs[name]; 
        
                     if (ObjectPrototypeHasOwnProperty(desc, 'value')) { 
        
                       // todo uncurried form 
        
                       enqueue(desc.value); 
        
                     } else { 
        
                       enqueue(desc.get); 
        
                       enqueue(desc.set); 
        
                     } 
        
                   }); 
        
                 } 
        
                 function dequeue() { 
        
                   // New values added before forEach() has finished will be visited. 
        
                   freezingSet.forEach(doFreeze); // TODO: Curried forEach 
        
                 } 
        
                 function commit() { 
        
                   // TODO: Curried forEach 
        
                   // We capture the real WeakSet.prototype.add above, in case someone 
        
                   // changes it. The two-argument form of forEach passes the second 
        
                   // argument as the 'this' binding, so we add to the correct set. 
        
                   freezingSet.forEach(frozenSet.add, frozenSet); 
        
                 } 
        
                 enqueue(node); 
        
                 dequeue(); 
        
                 commit(); 
        
               } 
        
               innerDeepFreeze(root); 
        
               return root; 
        
             }

to be available as primordials.

This has nothing to do with primordials though, it's about forbidding any mutation of intrinsics when node is run with --frozen-intrinsics.

ah, sorry for my confusion.

Landed in 637a98a

Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk> PR-URL: #63029 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

lib: add Temporal to frozen intrinsics

66cce03

Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>

Renegade334 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Apr 29, 2026

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 29, 2026

aduh95 reviewed Apr 29, 2026

View reviewed changes

Comment thread lib/internal/freeze_intrinsics.js

aduh95 approved these changes Apr 29, 2026

View reviewed changes

Renegade334 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2026

ljharb approved these changes Apr 29, 2026

View reviewed changes

anonrig approved these changes Apr 29, 2026

View reviewed changes

Renegade334 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 30, 2026

legendecas approved these changes Apr 30, 2026

View reviewed changes

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 1, 2026

nodejs-github-bot merged commit 637a98a into nodejs:main May 1, 2026
90 of 93 checks passed

Renegade334 deleted the freeze-temporal-intrinsics branch May 1, 2026 09:26

aduh95 mentioned this pull request May 5, 2026

2026-05-07, Version 26.1.0 #63137

Merged

lib: add Temporal to frozen intrinsics by Renegade334 · Pull Request #63029 · nodejs/node · GitHub

Uh oh!

Uh oh!

lib: add Temporal to frozen intrinsics - #63029

lib: add Temporal to frozen intrinsics#63029
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Renegade334:freeze-temporal-intrinsics

Renegade334 commented Apr 29, 2026

Uh oh!

codecov Bot commented Apr 29, 2026 •
edited
Loading

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 29, 2026

Uh oh!

ljharb left a comment

Uh oh!

nodejs-github-bot commented Apr 29, 2026

Uh oh!

Renegade334 commented Apr 30, 2026

Uh oh!

ljharb commented Apr 30, 2026

Uh oh!

aduh95 commented Apr 30, 2026

Uh oh!

ljharb commented Apr 30, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented May 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lib: add Temporal to frozen intrinsics by Renegade334 · Pull Request #63029 · nodejs/node · GitHub

Uh oh!

Uh oh!

lib: add Temporal to frozen intrinsics - #63029

lib: add Temporal to frozen intrinsics#63029nodejs-github-bot merged 1 commit intonodejs:mainnodejs/node:mainfrom Renegade334:freeze-temporal-intrinsicsRenegade334/node:freeze-temporal-intrinsicsCopy head branch name to clipboard

Conversation

Renegade334 commented Apr 29, 2026

Uh oh!

codecov Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 29, 2026

Uh oh!

ljharb left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Apr 29, 2026

Uh oh!

Renegade334 commented Apr 30, 2026

Uh oh!

ljharb commented Apr 30, 2026

Uh oh!

aduh95 commented Apr 30, 2026

Uh oh!

ljharb commented Apr 30, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented May 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lib: add Temporal to frozen intrinsics#63029
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Renegade334:freeze-temporal-intrinsics

codecov Bot commented Apr 29, 2026 •
edited
Loading