src: fix ContextifyContext property definer interception result - #63549
Merged
nodejs-github-bot merged 1 commit intoMay 27, 2026
Merged
src: fix ContextifyContext property definer interception result#63549nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: Chengzhong Wu <legendecas@gmail.com>
legendecas
force-pushed
the
vm-intercept-52634
branch
from
8baf29f to
3fb03c6
Compare
May 24, 2026 21:52
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #63549 +/- ##
==========================================
+ Coverage 90.31% 90.33% +0.01%
==========================================
Files 730 730
Lines 234161 234163 +2
Branches 43917 43924 +7
==========================================
+ Hits 211486 211525 +39
+ Misses 14408 14363 -45
- Partials 8267 8275 +8
... and 31 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
addaleax
approved these changes
May 26, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
approved these changes
May 27, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Jun 3, 2026
legendecas
added a commit
to legendecas/node
that referenced
this pull request
Jun 22, 2026
This fixes a long-standing issue that `ContextifyContext::PropertyDefinerCallback` incorrectly copies the `const PropertyDescriptor& desc`, assigning value to be `undefined` when no value present on the `PropertyDescriptor`. This is revealed after nodejs#63549 because returning `kYes` tells V8 that the definer handled it, and V8 no longer fixes it up. Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jun 29, 2026
This fixes a long-standing issue that `ContextifyContext::PropertyDefinerCallback` incorrectly copies the `const PropertyDescriptor& desc`, assigning value to be `undefined` when no value present on the `PropertyDescriptor`. This is revealed after #63549 because returning `kYes` tells V8 that the definer handled it, and V8 no longer fixes it up. Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> PR-URL: #64073 Fixes: #64008 Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 3, 2026
This fixes a long-standing issue that `ContextifyContext::PropertyDefinerCallback` incorrectly copies the `const PropertyDescriptor& desc`, assigning value to be `undefined` when no value present on the `PropertyDescriptor`. This is revealed after #63549 because returning `kYes` tells V8 that the definer handled it, and V8 no longer fixes it up. Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> PR-URL: #64073 Fixes: #64008 Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes that when defining a property, a definer callback
like a proxy handler would be invoked twice when the property
is writable.
Fixes: #52634