FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

vm: enable interception on global restricted properties by legendecas · Pull Request #64202 · nodejs/node · GitHub

/ node Public

vm: enable interception on global restricted properties - #64202

Closed
legendecas wants to merge 2 commits into
nodejs:mainfrom
legendecas:v8-vm-restricted-global
ConversationCommits (2)ChecksFiles changed
Closed

vm: enable interception on global restricted properties#64202
legendecas wants to merge 2 commits into
nodejs:mainfrom
legendecas:v8-vm-restricted-global

Conversation

legendecas commented Jun 29, 2026

Copy link
Copy Markdown
Member

deps: V8: backport a05321ebd98e

Original commit message:

[execution] Lookup interceptor for RestrictedGlobalProperty

When the script context looks up if a global property is
restricted, it should also query the global interceptor.

To avoid calling the interceptor for every declaration
unconditionally, an interceptor has to be defined with
`PropertyHandlerFlags::kHasDontDeleteProperty`
to intercept restricted global property queries.

Refs: https://github.com/nodejs/node/issues/63715
Refs: https://github.com/nodejs/node/issues/52634

Change-Id: I623ff285c4e8773d8ee7f681cbad68ba24bd3f40
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7898818
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#108280}

Refs: v8/v8@a05321e

vm: enable interception on global restricted properties

Fixes: #63715

deps: V8: backport a05321ebd98e
82bdd58 
Original commit message:

    [execution] Lookup interceptor for RestrictedGlobalProperty

    When the script context looks up if a global property is
    restricted, it should also query the global interceptor.

    To avoid calling the interceptor for every declaration
    unconditionally, an interceptor has to be defined with
    `PropertyHandlerFlags::kHasDontDeleteProperty`
    to intercept restricted global property queries.

    Refs: nodejs#63715
    Refs: nodejs#52634

    Change-Id: I623ff285c4e8773d8ee7f681cbad68ba24bd3f40
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7898818
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: Igor Sheludko <ishell@chromium.org>
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#108280}

Refs: v8/v8@a05321e
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>

nodejs-github-bot commented Jun 29, 2026 •
edited by legendecas
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update
  • @nodejs/vm

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 29, 2026
legendecas added the v8 engine Issues and PRs related to the V8 dependency. label Jun 29, 2026
vm: enable interception on global restricted properties
e5fe063 
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
legendecas force-pushed the v8-vm-restricted-global branch from 93e842e to e5fe063 Compare June 30, 2026 18:21
legendecas added the vm Issues and PRs related to the vm subsystem. label Jul 1, 2026
joyeecheung approved these changes Jul 2, 2026
View reviewed changes

joyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. I think this counts as semver-major?

joyeecheung added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 2, 2026

joyeecheung commented Jul 2, 2026

Copy link
Copy Markdown
Member

(Technically the V8 commit isn't semver-major)

legendecas commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

I'd count this as a fix to #63549 and the V8 API bit change is not ABI breaking (it's addition only).

I marked #63549 as v26.x only, so marking this as do-not-backport to earlier than v26.x, unless otherwise disagree?

joyeecheung commented Jul 2, 2026

Copy link
Copy Markdown
Member

I think do-not-backport to earlier than v26.x is a reasonable middle ground given the impact is limited to globals, yeah

legendecas added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. request-ci Add this label to start a Jenkins CI on a PR. and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Jul 2, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 2, 2026

nodejs-github-bot commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74523/

nodejs-github-bot commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7249/

nodejs-github-bot commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7249/

nodejs-github-bot commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7249/

nodejs-github-bot commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74637/

legendecas added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Jul 7, 2026

nodejs-github-bot commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74639/

legendecas added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 7, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 7, 2026

nodejs-github-bot commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Landed in f4c85d5...4ee2117

nodejs-github-bot pushed a commit that referenced this pull request Jul 7, 2026
deps: V8: backport a05321ebd98e
39d9e8c 
Original commit message:

    [execution] Lookup interceptor for RestrictedGlobalProperty

    When the script context looks up if a global property is
    restricted, it should also query the global interceptor.

    To avoid calling the interceptor for every declaration
    unconditionally, an interceptor has to be defined with
    `PropertyHandlerFlags::kHasDontDeleteProperty`
    to intercept restricted global property queries.

    Refs: #63715
    Refs: #52634

    Change-Id: I623ff285c4e8773d8ee7f681cbad68ba24bd3f40
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7898818
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: Igor Sheludko <ishell@chromium.org>
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#108280}

Refs: v8/v8@a05321e
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: #64202
Fixes: #63715
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Jul 7, 2026
vm: enable interception on global restricted properties
4ee2117 
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: #64202
Fixes: #63715
Refs: v8/v8@a05321e
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
legendecas deleted the v8-vm-restricted-global branch July 7, 2026 18:12
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
deps: V8: backport a05321ebd98e
dbd98ed 
Original commit message:

    [execution] Lookup interceptor for RestrictedGlobalProperty

    When the script context looks up if a global property is
    restricted, it should also query the global interceptor.

    To avoid calling the interceptor for every declaration
    unconditionally, an interceptor has to be defined with
    `PropertyHandlerFlags::kHasDontDeleteProperty`
    to intercept restricted global property queries.

    Refs: #63715
    Refs: #52634

    Change-Id: I623ff285c4e8773d8ee7f681cbad68ba24bd3f40
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7898818
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: Igor Sheludko <ishell@chromium.org>
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#108280}

Refs: v8/v8@a05321e
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: #64202
Fixes: #63715
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
vm: enable interception on global restricted properties
1ee27c2 
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: #64202
Fixes: #63715
Refs: v8/v8@a05321e
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
github-actions Bot mentioned this pull request Jul 21, 2026
Merged
RafaelGSS pushed a commit that referenced this pull request Jul 29, 2026
deps: V8: backport a05321ebd98e
d7a4b22 
Original commit message:

    [execution] Lookup interceptor for RestrictedGlobalProperty

    When the script context looks up if a global property is
    restricted, it should also query the global interceptor.

    To avoid calling the interceptor for every declaration
    unconditionally, an interceptor has to be defined with
    `PropertyHandlerFlags::kHasDontDeleteProperty`
    to intercept restricted global property queries.

    Refs: #63715
    Refs: #52634

    Change-Id: I623ff285c4e8773d8ee7f681cbad68ba24bd3f40
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7898818
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: Igor Sheludko <ishell@chromium.org>
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#108280}

Refs: v8/v8@a05321e
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: #64202
Fixes: #63715
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jul 29, 2026
vm: enable interception on global restricted properties
7be42b6 
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: #64202
Fixes: #63715
Refs: v8/v8@a05321e
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Aug 4, 2026
deps: V8: backport a05321ebd98e
1b70bc1 
Original commit message:

    [execution] Lookup interceptor for RestrictedGlobalProperty

    When the script context looks up if a global property is
    restricted, it should also query the global interceptor.

    To avoid calling the interceptor for every declaration
    unconditionally, an interceptor has to be defined with
    `PropertyHandlerFlags::kHasDontDeleteProperty`
    to intercept restricted global property queries.

    Refs: nodejs#63715
    Refs: nodejs#52634

    Change-Id: I623ff285c4e8773d8ee7f681cbad68ba24bd3f40
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7898818
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: Igor Sheludko <ishell@chromium.org>
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#108280}

Refs: v8/v8@a05321e
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: nodejs#64202
Fixes: nodejs#63715
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
hai-x mentioned this pull request Aug 4, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

joyeecheung joyeecheung approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

vm: let declaration no longer throws SyntaxError for non-configurable global property in vm context (regression in v26)

3 participants

Back | FazBrowse Home | New Git URL