FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add JacksonTian to collaborators by JacksonTian · Pull Request #6388 · nodejs/node · GitHub

/ node Public

doc: add JacksonTian to collaborators - #6388

Closed
JacksonTian wants to merge 1 commit into
nodejs:masterfrom
JacksonTian:collaborator
Closed

doc: add JacksonTian to collaborators#6388
JacksonTian wants to merge 1 commit into
nodejs:masterfrom
JacksonTian:collaborator

Conversation

JacksonTian commented Apr 26, 2016
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Added myself as a collaborator following the onboarding process.

Copy link
Copy Markdown
Member

LGTM - great to have you on board!

Trott commented Apr 26, 2016

Copy link
Copy Markdown
Member

LGTM. Welcome! Might be a good idea to make the commit message meaningful rather than just "Hi!" just to set a good example for others contributing to the project.

Copy link
Copy Markdown
Contributor Author

thanks @Trott .

Added myself as a collaborator following the onboarding process.

Copy link
Copy Markdown
Contributor

LGTM. Welcome aboard

JacksonTian added the doc Issues and PRs related to the documentations. label Apr 26, 2016
estliberitas force-pushed the master branch 2 times, most recently from 7da4fd4 to c7066fb Compare April 26, 2016 05:23

ChALkeR commented Apr 26, 2016

Copy link
Copy Markdown
Member

LGTM

JacksonTian added a commit that referenced this pull request Apr 26, 2016
Added myself as a collaborator following the onboarding process.

PR-URL: #6388
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

Copy link
Copy Markdown
Contributor Author

landed in bf3ffc2

JacksonTian added a commit that referenced this pull request Apr 26, 2016
Added myself as a collaborator following the onboarding process.

PR-URL: #6388
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
Added myself as a collaborator following the onboarding process.

PR-URL: #6388
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 1, 2016
Added myself as a collaborator following the onboarding process.

PR-URL: #6388
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins mentioned this pull request Jun 24, 2016
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
Added myself as a collaborator following the onboarding process.

PR-URL: #6388
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
Added myself as a collaborator following the onboarding process.

PR-URL: #6388
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
JacksonTian deleted the collaborator branch May 4, 2017 07:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL