v4.4.7 proposal - #7395
Merged
MylesBorins merged 92 commits intoJun 28, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Correct alignment on variable assignments that span multiple lines in preparation for lint rule to enforce such alignment. PR-URL: #6869 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Enforce alignment/indentation on variable assignments that span multiple lines. PR-URL: #6869 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
In debugger, the usage of `repl` very ugly. I'd like there is a `p`
like gdb. So the `exec` is coming.
Usage:
```
$ ./iojs debug ~/git/node_research/server.js
< Debugger listening on port 5858
connecting to 127.0.0.1:5858 ... ok
break in /Users/jacksontian/git/node_research/server.js:1
> 1 var http = require('http');
2
3 http.createServer(function (req, res) {
debug> exec process.title
/Users/jacksontian/git/io.js/out/Release/iojs
debug>
```
And the `repl`:
```
debug> repl
Press Ctrl + C to leave debug repl
> process.title
'/Users/jacksontian/git/io.js/out/Release/iojs'
debug>
(^C again to quit)
```
The enter and leave debug repl is superfluous.
R-URL: #1491
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Remove extra newlines that were causing rendering problems. PR-URL: #6958 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
`Object.prototype.__defineGetter__` is deprecated now, use `Object.defineProperty` instead. PR-URL: #6284 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Original commit message: [tools] Make gen-postmortem-metadata.py more reliable Instead of basing matches off of whitespace, walk the inheritance chain and include any classes that inherit from Object. R=machenbach@chromium.org,jkummerow@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1435643002 Cr-Commit-Position: refs/heads/master@{#31964} This adds some missing classes to postmortem info like JSMap and JSSet. PR-URL: #3792 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Set the mode bits on the history file to 0o600 instead of leaving it unspecified, which resulted in 0o755 on Unices. Test code mostly written by Trott: #3392 (comment). PR-URL: #3394 Fixes: #3392 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The Regex implementation is not faster than ascii code compare. the field name is shorter, the speed is faster. benchmark result here: https://bitbucket.org/snippets/JacksonTian/Rnbad/benchmark-result PR-URL: #4790 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
PR-URL: #5986 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* Test the toHTML function in html.js. Check that given valid markdown it produces the expected html. One test case will prevent regressions of #5873. * Check that when given valid markdown toJSON produces valid JSON with the expected schema. * Add doctool to the list of built in tests so it runs in CI. PR-URL: #6031 Fixes: #5955 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Rich Trott <rtrott@gmail.com>
`make binary` attempts to auto detect DESTCPU if not set, but was assuming being on an Intel architecture. PR-URL: #6310 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Copy link
Copy Markdown
Contributor
Author
|
ci: https://ci.nodejs.org/job/node-test-pull-request/3063/ |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
/cc @nodejs/lts |
Sorry, something went wrong.
PR-URL: #6194 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
PR-URL: #6224 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #6225 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #6226 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #6227 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
These files are created by VS 2015 and should be ignored by git. PR-URL: #6070 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This is created by vs 2015 for user & machine-specific files and should be ignored by git. PR-URL: #6070 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* Modify tools/license-builder.sh to support ICU 57.1's plain text license. (Separate issue to add ICU 57.1 in #6058) * Update/regenerate LICENSE to include ICU 57.1's license * Note that because the tool was rerun, the change in #6065 is already included here. PR-URL: #6068 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #6257 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #6386 Reviewed-By: Johan Bergström <bugs@bergstroem.nu Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com> PR-URL: #6385
PR-URL: #6389 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Also changed alias P.S.V.R to Minqi Pan. Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> PR-URL: #6387
Copy link
Copy Markdown
Contributor
|
lgtm |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@thealphanerd when will v4.5.0 with the updated async-wrap #7048 be released. I keep getting mails about it, and the only thing I can tell them is to be patient. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@thealphanerd We should release this next week and move towards a speedy minor... We keep holding this stuff up really really long... |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
The plan is to get this out ASAP as it includes fixes to a regression in
streams. We will then immediately turn around with a 4.5 rc which will
include the async wrap and minor changes. Considering a 3 week rc cycle.
Thoughts?
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
this all looks pretty vanilla, if citgm is happy then I'm happy, 👍 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
Replace '...' as invalid hostname with '***', which will give a more consisten error message on different systems. The hostname '...' returns EAI_AGAIN on musl libc and EAI_NONAME on most other systems. By changing the testcase we get same restult on all known platforms. PR-URL: #5099 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
The current layout is breaking the release post tool. This commit also removed erroneous entires in the main CHANGELOG for v4.4.6 and v5.12.0. PR-URL: #7394 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
force-pushed
the
v4.4.7-proposal
branch
from
e0ee375 to
f677d5f
Compare
June 27, 2016 20:33
Copy link
Copy Markdown
Contributor
Author
|
@saghul We'll be testing the update to libuv for v4.5.0 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
let's try this again ci: https://ci.nodejs.org/job/node-test-pull-request/3100/ |
Sorry, something went wrong.
This commit backports a fix to a crankshaft bug affects arm64 systems.
Original commit message:
[arm64] Fix jssp based spill slot accesses in Crankshaft
Review URL: https://codereview.chromium.org/1401703003
Cr-Commit-Position: refs/heads/master@{#31304}
Fixes: #7417
PR-URL: #7442
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
force-pushed
the
v4.4.7-proposal
branch
from
f677d5f to
313ecd9
Compare
June 28, 2016 19:57
Copy link
Copy Markdown
Contributor
Author
|
/cc @nodejs/collaborators can ya'll please take a look at the changelog and ensure everything is A OK |
Sorry, something went wrong.
PR-URL: #7412 Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins
force-pushed
the
v4.4.7-proposal
branch
2 times, most recently
from
867bcde to
45e78fa
Compare
June 28, 2016 20:16
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
This LTS release comes with 89 commits. This includes 46 commits that
are docs related, 11 commits that are test related, 8 commits that are
build related, and 4 commits that are benchmark related.
Notable Changes:
- debugger:
- All properties of an array (aside from length) can now be printed
in the repl (cjihrig)
#6448
- npm:
- Upgrade npm to 2.15.8 (Rebecca Turner)
#7412
- stream:
- Fix for a bug that became more prevalent with the stream changes
that landed in v4.4.5. (Anna Henningsen)
#7160
- V8:
- Fix for a bug in crankshaft that was causing crashes on arm64
(Myles Borins)
#7442
- Add missing classes to postmortem info such as JSMap and JSSet
(evan.lucas)
#3792
MylesBorins
force-pushed
the
v4.4.7-proposal
branch
from
45e78fa to
0974fc6
Compare
June 28, 2016 20:51
Copy link
Copy Markdown
Contributor
|
looks like what one would expect from a patch release on an LTS stream 👍 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
geminiyellow
added a commit
to ilivebox/heroku-nodejs
that referenced
this pull request
Jul 5, 2016
geminiyellow
added a commit
to ilivebox/heroku-nodejs
that referenced
this pull request
Jul 5, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2016-06-28, Version 4.4.7 'Argon' (LTS), @thealphanerd
This LTS release comes with 89 commits. This includes 46 commits that are docs related, 11 commits that are test related, 8 commits that are build related, and 4 commits that are benchmark related.
Notable Changes
Commits