FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix a typo in the api/globals by toyota790 · Pull Request #6473 · nodejs/node · GitHub

/ node Public

doc: fix a typo in the api/globals - #6473

Closed
toyota790 wants to merge 1 commit into
nodejs:masterfrom
toyota790:master
Closed

doc: fix a typo in the api/globals#6473
toyota790 wants to merge 1 commit into
nodejs:masterfrom
toyota790:master

Conversation

toyota790 commented Apr 29, 2016
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)
  • doc
Description of change

There is a typo in __dirname section.
This fixes #6431 issue.

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 29, 2016

cjihrig commented Apr 29, 2016

Copy link
Copy Markdown
Contributor

LGTM. I remember this. What issue does it reference?

Copy link
Copy Markdown
Contributor Author

Fixes #6431

mscdex commented Apr 29, 2016

Copy link
Copy Markdown
Contributor

Wasn't there some discussion somewhere about replacing these username-specific paths? Seems like that would be a better solution?

jasnell commented Apr 29, 2016

Copy link
Copy Markdown
Member

Should happen for sure /cc @nodejs/documentation
This particular change LGTM

Copy link
Copy Markdown
Contributor

@mscdex that was here nodejs/docs#102. Don't why there are usernames, I don't find that very good, but some collaborators voiced concerns over removing them.

Copy link
Copy Markdown
Contributor

LGTM. Generally can be removed later, if decided respectively.

jasnell pushed a commit that referenced this pull request May 1, 2016
PR-URL: #6473
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>

jasnell commented May 1, 2016

Copy link
Copy Markdown
Member

Landed in 81aef8c

jasnell closed this May 1, 2016
Fishrock123 pushed a commit that referenced this pull request May 4, 2016
PR-URL: #6473
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request May 4, 2016
PR-URL: nodejs#6473
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 1, 2016
PR-URL: #6473
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
MylesBorins mentioned this pull request Jun 24, 2016
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
PR-URL: #6473
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
PR-URL: #6473
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

misprint in documentation

7 participants


Back | FazBrowse Home | New Git URL